[INFO] crate cdg_renderer 0.1.0 is already in cache [INFO] extracting crate cdg_renderer 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/cdg_renderer/0.1.0 [INFO] extracting crate cdg_renderer 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cdg_renderer/0.1.0 [INFO] validating manifest of cdg_renderer-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cdg_renderer-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cdg_renderer-0.1.0 [INFO] removed path dependency cdg from cdg_renderer-0.1.0 [INFO] finished frobbing cdg_renderer-0.1.0 [INFO] frobbed toml for cdg_renderer-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/cdg_renderer/0.1.0/Cargo.toml [INFO] started frobbing cdg_renderer-0.1.0 [INFO] removed path dependency cdg from cdg_renderer-0.1.0 [INFO] finished frobbing cdg_renderer-0.1.0 [INFO] frobbed toml for cdg_renderer-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cdg_renderer/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cdg_renderer-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cdg_renderer/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4be0a26836abfeb616ad61a2c7e30ede84342eb61a2e0a532b0a317ba60d8701 [INFO] running `"docker" "start" "-a" "4be0a26836abfeb616ad61a2c7e30ede84342eb61a2e0a532b0a317ba60d8701"` [INFO] [stderr] Checking cdg v0.1.0 [INFO] [stderr] Checking cdg_renderer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | Position{x: x, y: y} [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:25:24 [INFO] [stderr] | [INFO] [stderr] 25 | Position{x: x, y: y} [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | Position{x: x, y: y} [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:25:24 [INFO] [stderr] | [INFO] [stderr] 25 | Position{x: x, y: y} [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | / fn index<'a>(&'a self, pos: (u8,u8)) -> &'a u8 { [INFO] [stderr] 90 | | assert!(pos.0 < 6 && pos.1 < 12); [INFO] [stderr] 91 | | unsafe { [INFO] [stderr] 92 | | self.interp.content.get_unchecked(self.y + pos.1 as usize).get_unchecked(self.x + pos.0 as usize) [INFO] [stderr] 93 | | } [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | / fn index_mut<'a>(&'a mut self, pos: (u8,u8)) -> &'a mut u8 { [INFO] [stderr] 99 | | assert!(pos.0 < 6 && pos.1 < 12); [INFO] [stderr] 100 | | unsafe { [INFO] [stderr] 101 | | self.interp.content.get_unchecked_mut(self.y + pos.1 as usize).get_unchecked_mut(self.x + pos.0 as usize) [INFO] [stderr] 102 | | } [INFO] [stderr] 103 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `CdgInterpreter` [INFO] [stderr] --> src/lib.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | / pub fn new() -> Self { [INFO] [stderr] 110 | | use cdg::RgbColor; [INFO] [stderr] 111 | | CdgInterpreter { [INFO] [stderr] 112 | | tile_shift: Position::new(0,0), [INFO] [stderr] ... | [INFO] [stderr] 136 | | } [INFO] [stderr] 137 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 108 | impl Default for CdgInterpreter { [INFO] [stderr] 109 | fn default() -> Self { [INFO] [stderr] 110 | Self::new() [INFO] [stderr] 111 | } [INFO] [stderr] 112 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:185:18 [INFO] [stderr] | [INFO] [stderr] 185 | let x = (pos.0 as u16 + self.tile_shift.x) as usize % TILE_COLS; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(pos.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:186:18 [INFO] [stderr] | [INFO] [stderr] 186 | let y = (pos.1 as u16 + self.tile_shift.y) as usize % TILE_ROWS; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(pos.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:200:38 [INFO] [stderr] | [INFO] [stderr] 200 | let new_tile = Position::new(pos.0 as u16, pos.1 as u16); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(pos.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:200:52 [INFO] [stderr] | [INFO] [stderr] 200 | let new_tile = Position::new(pos.0 as u16, pos.1 as u16); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(pos.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:201:39 [INFO] [stderr] | [INFO] [stderr] 201 | let new_tilep = Position::new(pos.0 as u16 + 1, pos.1 as u16 + 1); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(pos.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:201:57 [INFO] [stderr] | [INFO] [stderr] 201 | let new_tilep = Position::new(pos.0 as u16 + 1, pos.1 as u16 + 1); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(pos.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:204:14 [INFO] [stderr] | [INFO] [stderr] 204 | .or(Some(Rectangle::new(new_tile,new_tilep))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(Rectangle::new(new_tile,new_tilep)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:310:50 [INFO] [stderr] | [INFO] [stderr] 310 | self.pixel_shift = Position::new(xo as u16 % 6, yo as u16 % 12); [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(xo)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:310:65 [INFO] [stderr] | [INFO] [stderr] 310 | self.pixel_shift = Position::new(xo as u16 % 6, yo as u16 % 12); [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(yo)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | / fn index<'a>(&'a self, pos: (u8,u8)) -> &'a u8 { [INFO] [stderr] 90 | | assert!(pos.0 < 6 && pos.1 < 12); [INFO] [stderr] 91 | | unsafe { [INFO] [stderr] 92 | | self.interp.content.get_unchecked(self.y + pos.1 as usize).get_unchecked(self.x + pos.0 as usize) [INFO] [stderr] 93 | | } [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | / fn index_mut<'a>(&'a mut self, pos: (u8,u8)) -> &'a mut u8 { [INFO] [stderr] 99 | | assert!(pos.0 < 6 && pos.1 < 12); [INFO] [stderr] 100 | | unsafe { [INFO] [stderr] 101 | | self.interp.content.get_unchecked_mut(self.y + pos.1 as usize).get_unchecked_mut(self.x + pos.0 as usize) [INFO] [stderr] 102 | | } [INFO] [stderr] 103 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `CdgInterpreter` [INFO] [stderr] --> src/lib.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | / pub fn new() -> Self { [INFO] [stderr] 110 | | use cdg::RgbColor; [INFO] [stderr] 111 | | CdgInterpreter { [INFO] [stderr] 112 | | tile_shift: Position::new(0,0), [INFO] [stderr] ... | [INFO] [stderr] 136 | | } [INFO] [stderr] 137 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 108 | impl Default for CdgInterpreter { [INFO] [stderr] 109 | fn default() -> Self { [INFO] [stderr] 110 | Self::new() [INFO] [stderr] 111 | } [INFO] [stderr] 112 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:185:18 [INFO] [stderr] | [INFO] [stderr] 185 | let x = (pos.0 as u16 + self.tile_shift.x) as usize % TILE_COLS; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(pos.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:186:18 [INFO] [stderr] | [INFO] [stderr] 186 | let y = (pos.1 as u16 + self.tile_shift.y) as usize % TILE_ROWS; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(pos.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:200:38 [INFO] [stderr] | [INFO] [stderr] 200 | let new_tile = Position::new(pos.0 as u16, pos.1 as u16); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(pos.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:200:52 [INFO] [stderr] | [INFO] [stderr] 200 | let new_tile = Position::new(pos.0 as u16, pos.1 as u16); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(pos.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:201:39 [INFO] [stderr] | [INFO] [stderr] 201 | let new_tilep = Position::new(pos.0 as u16 + 1, pos.1 as u16 + 1); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(pos.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:201:57 [INFO] [stderr] | [INFO] [stderr] 201 | let new_tilep = Position::new(pos.0 as u16 + 1, pos.1 as u16 + 1); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(pos.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:204:14 [INFO] [stderr] | [INFO] [stderr] 204 | .or(Some(Rectangle::new(new_tile,new_tilep))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(Rectangle::new(new_tile,new_tilep)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:310:50 [INFO] [stderr] | [INFO] [stderr] 310 | self.pixel_shift = Position::new(xo as u16 % 6, yo as u16 % 12); [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(xo)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:310:65 [INFO] [stderr] | [INFO] [stderr] 310 | self.pixel_shift = Position::new(xo as u16 % 6, yo as u16 % 12); [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(yo)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.11s [INFO] running `"docker" "inspect" "4be0a26836abfeb616ad61a2c7e30ede84342eb61a2e0a532b0a317ba60d8701"` [INFO] running `"docker" "rm" "-f" "4be0a26836abfeb616ad61a2c7e30ede84342eb61a2e0a532b0a317ba60d8701"` [INFO] [stdout] 4be0a26836abfeb616ad61a2c7e30ede84342eb61a2e0a532b0a317ba60d8701