[INFO] crate cdchunking 0.2.1 is already in cache [INFO] extracting crate cdchunking 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/cdchunking/0.2.1 [INFO] extracting crate cdchunking 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cdchunking/0.2.1 [INFO] validating manifest of cdchunking-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cdchunking-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cdchunking-0.2.1 [INFO] finished frobbing cdchunking-0.2.1 [INFO] frobbed toml for cdchunking-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/cdchunking/0.2.1/Cargo.toml [INFO] started frobbing cdchunking-0.2.1 [INFO] finished frobbing cdchunking-0.2.1 [INFO] frobbed toml for cdchunking-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cdchunking/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cdchunking-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cdchunking/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 78cf821f76b1797aad206b2f9bd9120c7f72fe467ae71b11e8bf5350af059df1 [INFO] running `"docker" "start" "-a" "78cf821f76b1797aad206b2f9bd9120c7f72fe467ae71b11e8bf5350af059df1"` [INFO] [stderr] Checking cdchunking v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:213:13 [INFO] [stderr] | [INFO] [stderr] 213 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:243:13 [INFO] [stderr] | [INFO] [stderr] 243 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:396:48 [INFO] [stderr] | [INFO] [stderr] 396 | return Some(Ok(ChunkInfo { start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:213:13 [INFO] [stderr] | [INFO] [stderr] 213 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:243:13 [INFO] [stderr] | [INFO] [stderr] 243 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:396:48 [INFO] [stderr] | [INFO] [stderr] 396 | return Some(Ok(ChunkInfo { start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:417:16 [INFO] [stderr] | [INFO] [stderr] 417 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 418 | | if let Some(split) = self.inner.find_boundary( [INFO] [stderr] 419 | | &self.buffer[self.pos..]) [INFO] [stderr] 420 | | { [INFO] [stderr] ... | [INFO] [stderr] 430 | | } [INFO] [stderr] 431 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 417 | } else if let Some(split) = self.inner.find_boundary( [INFO] [stderr] 418 | &self.buffer[self.pos..]) [INFO] [stderr] 419 | { [INFO] [stderr] 420 | assert!(self.pos + split < self.buffer.len()); [INFO] [stderr] 421 | let start = self.pos; [INFO] [stderr] 422 | self.pos += split + 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:479:36 [INFO] [stderr] | [INFO] [stderr] 479 | const HM: Wrapping = Wrapping(123456791); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_791` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:417:16 [INFO] [stderr] | [INFO] [stderr] 417 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 418 | | if let Some(split) = self.inner.find_boundary( [INFO] [stderr] 419 | | &self.buffer[self.pos..]) [INFO] [stderr] 420 | | { [INFO] [stderr] ... | [INFO] [stderr] 430 | | } [INFO] [stderr] 431 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 417 | } else if let Some(split) = self.inner.find_boundary( [INFO] [stderr] 418 | &self.buffer[self.pos..]) [INFO] [stderr] 419 | { [INFO] [stderr] 420 | assert!(self.pos + split < self.buffer.len()); [INFO] [stderr] 421 | let start = self.pos; [INFO] [stderr] 422 | self.pos += split + 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:479:36 [INFO] [stderr] | [INFO] [stderr] 479 | const HM: Wrapping = Wrapping(123456791); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_791` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused variable: `chunk` [INFO] [stderr] --> src/lib.rs:661:13 [INFO] [stderr] | [INFO] [stderr] 661 | for chunk in chunker.whole_chunks(random) { [INFO] [stderr] | ^^^^^ help: consider using `_chunk` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:444:12 [INFO] [stderr] | [INFO] [stderr] 444 | if data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:500:45 [INFO] [stderr] | [INFO] [stderr] 500 | self.h = self.h * HM + Wrapping(byte as u32 + 1); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:502:59 [INFO] [stderr] | [INFO] [stderr] 502 | self.h = self.h * HM * Wrapping(2) + Wrapping(byte as u32 + 1); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:538:18 [INFO] [stderr] | [INFO] [stderr] 538 | fn base() -> (Chunker, &'static [u8], [INFO] [stderr] | __________________^ [INFO] [stderr] 539 | | io::Cursor<&'static [u8]>, &'static [u8]) { [INFO] [stderr] | |___________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: the variable `count` is used as a loop counter. Consider using `for (count, item) in chunker.whole_chunks(random).enumerate()` or similar iterators [INFO] [stderr] --> src/lib.rs:661:22 [INFO] [stderr] | [INFO] [stderr] 661 | for chunk in chunker.whole_chunks(random) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:444:12 [INFO] [stderr] | [INFO] [stderr] 444 | if data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:500:45 [INFO] [stderr] | [INFO] [stderr] 500 | self.h = self.h * HM + Wrapping(byte as u32 + 1); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:502:59 [INFO] [stderr] | [INFO] [stderr] 502 | self.h = self.h * HM * Wrapping(2) + Wrapping(byte as u32 + 1); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.51s [INFO] running `"docker" "inspect" "78cf821f76b1797aad206b2f9bd9120c7f72fe467ae71b11e8bf5350af059df1"` [INFO] running `"docker" "rm" "-f" "78cf821f76b1797aad206b2f9bd9120c7f72fe467ae71b11e8bf5350af059df1"` [INFO] [stdout] 78cf821f76b1797aad206b2f9bd9120c7f72fe467ae71b11e8bf5350af059df1