[INFO] crate cdb 0.6.0 is already in cache [INFO] extracting crate cdb 0.6.0 into work/ex/clippy-test-run/sources/stable/reg/cdb/0.6.0 [INFO] extracting crate cdb 0.6.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cdb/0.6.0 [INFO] validating manifest of cdb-0.6.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cdb-0.6.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cdb-0.6.0 [INFO] finished frobbing cdb-0.6.0 [INFO] frobbed toml for cdb-0.6.0 written to work/ex/clippy-test-run/sources/stable/reg/cdb/0.6.0/Cargo.toml [INFO] started frobbing cdb-0.6.0 [INFO] finished frobbing cdb-0.6.0 [INFO] frobbed toml for cdb-0.6.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cdb/0.6.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cdb-0.6.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cdb/0.6.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 07a65a9a29688b302cd00cd1ab0ae5b6267575759f9670106a9bfe80053f5abd [INFO] running `"docker" "start" "-a" "07a65a9a29688b302cd00cd1ab0ae5b6267575759f9670106a9bfe80053f5abd"` [INFO] [stderr] Checking filebuffer v0.4.0 [INFO] [stderr] Checking cdb v0.6.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | cdb: cdb, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cdb` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | khash: khash, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `khash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | kpos: kpos, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kpos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | hpos: hpos, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hpos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | hslots: hslots, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `hslots` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/writer.rs:76:60 [INFO] [stderr] | [INFO] [stderr] 76 | self.entries[(hash & 0xff) as usize].push(HashPos{ hash: hash, pos: self.pos }); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | cdb: cdb, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cdb` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | khash: khash, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `khash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | kpos: kpos, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kpos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | hpos: hpos, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hpos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | hslots: hslots, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `hslots` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/writer.rs:76:60 [INFO] [stderr] | [INFO] [stderr] 76 | self.entries[(hash & 0xff) as usize].push(HashPos{ hash: hash, pos: self.pos }); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader.rs:44:54 [INFO] [stderr] | [INFO] [stderr] 44 | if file.len() < 2048 + 8 + 8 || file.len() > 0xffffffff { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/reader.rs:207:17 [INFO] [stderr] | [INFO] [stderr] 207 | / if klen as usize == self.key.len() { [INFO] [stderr] 208 | | if iter_try!(self.cdb.match_key(&self.key[..], pos + 8)) { [INFO] [stderr] 209 | | self.dlen = dlen; [INFO] [stderr] 210 | | self.dpos = pos + 8 + self.key.len() as u32; [INFO] [stderr] 211 | | return Some(self.read_vec()); [INFO] [stderr] 212 | | } [INFO] [stderr] 213 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 207 | if klen as usize == self.key.len() && match $e { [INFO] [stderr] 208 | Err(x) => { return Some(Err(x)); }, [INFO] [stderr] 209 | Ok(y) => y [INFO] [stderr] 210 | } { [INFO] [stderr] 211 | self.dlen = dlen; [INFO] [stderr] 212 | self.dpos = pos + 8 + self.key.len() as u32; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer.rs:92:25 [INFO] [stderr] | [INFO] [stderr] 92 | if key.len() >= 0xffffffff || data.len() >= 0xffffffff { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer.rs:92:53 [INFO] [stderr] | [INFO] [stderr] 92 | if key.len() >= 0xffffffff || data.len() >= 0xffffffff { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer.rs:112:31 [INFO] [stderr] | [INFO] [stderr] 112 | if maxsize + count > (0xffffffff / 8) { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:18:27 [INFO] [stderr] | [INFO] [stderr] 18 | assert_eq!(hash(b""), 0x0001505); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x0000_1505` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:19:40 [INFO] [stderr] | [INFO] [stderr] 19 | assert_eq!(hash(b"Hello, world!"), 0x564369e8); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5643_69e8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:20:59 [INFO] [stderr] | [INFO] [stderr] 20 | assert_eq!(hash(b"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"), 0x40032705); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4003_2705` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader.rs:44:54 [INFO] [stderr] | [INFO] [stderr] 44 | if file.len() < 2048 + 8 + 8 || file.len() > 0xffffffff { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/reader.rs:207:17 [INFO] [stderr] | [INFO] [stderr] 207 | / if klen as usize == self.key.len() { [INFO] [stderr] 208 | | if iter_try!(self.cdb.match_key(&self.key[..], pos + 8)) { [INFO] [stderr] 209 | | self.dlen = dlen; [INFO] [stderr] 210 | | self.dpos = pos + 8 + self.key.len() as u32; [INFO] [stderr] 211 | | return Some(self.read_vec()); [INFO] [stderr] 212 | | } [INFO] [stderr] 213 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 207 | if klen as usize == self.key.len() && match $e { [INFO] [stderr] 208 | Err(x) => { return Some(Err(x)); }, [INFO] [stderr] 209 | Ok(y) => y [INFO] [stderr] 210 | } { [INFO] [stderr] 211 | self.dlen = dlen; [INFO] [stderr] 212 | self.dpos = pos + 8 + self.key.len() as u32; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer.rs:92:25 [INFO] [stderr] | [INFO] [stderr] 92 | if key.len() >= 0xffffffff || data.len() >= 0xffffffff { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer.rs:92:53 [INFO] [stderr] | [INFO] [stderr] 92 | if key.len() >= 0xffffffff || data.len() >= 0xffffffff { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer.rs:112:31 [INFO] [stderr] | [INFO] [stderr] 112 | if maxsize + count > (0xffffffff / 8) { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/uint32.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | (data[0] as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(data[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/uint32.rs:8:12 [INFO] [stderr] | [INFO] [stderr] 8 | | ((data[1] as u32) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(data[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/uint32.rs:9:12 [INFO] [stderr] | [INFO] [stderr] 9 | | ((data[2] as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(data[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/uint32.rs:10:12 [INFO] [stderr] | [INFO] [stderr] 10 | | ((data[3] as u32) << 24) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(data[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hash.rs:5:41 [INFO] [stderr] | [INFO] [stderr] 5 | h.wrapping_shl(5).wrapping_add(h) ^ (c as u32) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/reader.rs:161:18 [INFO] [stderr] | [INFO] [stderr] 161 | key: key.into_iter().map(|x| *x).collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `key.into_iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/reader.rs:161:22 [INFO] [stderr] | [INFO] [stderr] 161 | key: key.into_iter().map(|x| *x).collect(), [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/writer.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | fn pack(&self, buf: &mut [u8]) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | try!(w.write(&buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | try!(self.file.write(&buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | try!(self.file.write(key)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | try!(self.file.write(data)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | try!(self.file.write(&buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | try!(self.file.write(&header)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/writer.rs:233:16 [INFO] [stderr] | [INFO] [stderr] 233 | if let Some(_) = self.cdb { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 234 | | fs::remove_file(&self.tmpname); [INFO] [stderr] 235 | | } [INFO] [stderr] | |_________- help: try this: `if self.cdb.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `cdb`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/uint32.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | (data[0] as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(data[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/uint32.rs:8:12 [INFO] [stderr] | [INFO] [stderr] 8 | | ((data[1] as u32) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(data[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/uint32.rs:9:12 [INFO] [stderr] | [INFO] [stderr] 9 | | ((data[2] as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(data[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/uint32.rs:10:12 [INFO] [stderr] | [INFO] [stderr] 10 | | ((data[3] as u32) << 24) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(data[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hash.rs:5:41 [INFO] [stderr] | [INFO] [stderr] 5 | h.wrapping_shl(5).wrapping_add(h) ^ (c as u32) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/reader.rs:161:18 [INFO] [stderr] | [INFO] [stderr] 161 | key: key.into_iter().map(|x| *x).collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `key.into_iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/reader.rs:161:22 [INFO] [stderr] | [INFO] [stderr] 161 | key: key.into_iter().map(|x| *x).collect(), [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/writer.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | fn pack(&self, buf: &mut [u8]) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | try!(w.write(&buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | try!(self.file.write(&buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | try!(self.file.write(key)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | try!(self.file.write(data)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | try!(self.file.write(&buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/writer.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | try!(self.file.write(&header)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/writer.rs:233:16 [INFO] [stderr] | [INFO] [stderr] 233 | if let Some(_) = self.cdb { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 234 | | fs::remove_file(&self.tmpname); [INFO] [stderr] 235 | | } [INFO] [stderr] | |_________- help: try this: `if self.cdb.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `cdb`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "07a65a9a29688b302cd00cd1ab0ae5b6267575759f9670106a9bfe80053f5abd"` [INFO] running `"docker" "rm" "-f" "07a65a9a29688b302cd00cd1ab0ae5b6267575759f9670106a9bfe80053f5abd"` [INFO] [stdout] 07a65a9a29688b302cd00cd1ab0ae5b6267575759f9670106a9bfe80053f5abd