[INFO] crate ccwd 0.1.2 is already in cache [INFO] extracting crate ccwd 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/ccwd/0.1.2 [INFO] extracting crate ccwd 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ccwd/0.1.2 [INFO] validating manifest of ccwd-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ccwd-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ccwd-0.1.2 [INFO] finished frobbing ccwd-0.1.2 [INFO] frobbed toml for ccwd-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/ccwd/0.1.2/Cargo.toml [INFO] started frobbing ccwd-0.1.2 [INFO] finished frobbing ccwd-0.1.2 [INFO] frobbed toml for ccwd-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ccwd/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ccwd-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ccwd/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d7c9553f12d38643e5010a20ce2f8e90e506dcf76147f030e19aad49c6f97c33 [INFO] running `"docker" "start" "-a" "d7c9553f12d38643e5010a20ce2f8e90e506dcf76147f030e19aad49c6f97c33"` [INFO] [stderr] Checking ccwd v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:17:16 [INFO] [stderr] | [INFO] [stderr] 17 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 18 | | if let Ok(n) = is_program_in_path("xclip") { [INFO] [stderr] 19 | | Clipboard { [INFO] [stderr] 20 | | cmd: n.to_owned(), [INFO] [stderr] ... | [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 17 | } else if let Ok(n) = is_program_in_path("xclip") { [INFO] [stderr] 18 | Clipboard { [INFO] [stderr] 19 | cmd: n.to_owned(), [INFO] [stderr] 20 | args: &["-selection", "c"], [INFO] [stderr] 21 | } [INFO] [stderr] 22 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Clipboard<'a>` [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> Self { [INFO] [stderr] 12 | | if let Ok(n) = is_program_in_path("xsel") { [INFO] [stderr] 13 | | Clipboard { [INFO] [stderr] 14 | | cmd: n.to_owned(), [INFO] [stderr] ... | [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:71:29 [INFO] [stderr] | [INFO] [stderr] 71 | for p in path.split(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:17:16 [INFO] [stderr] | [INFO] [stderr] 17 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 18 | | if let Ok(n) = is_program_in_path("xclip") { [INFO] [stderr] 19 | | Clipboard { [INFO] [stderr] 20 | | cmd: n.to_owned(), [INFO] [stderr] ... | [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 17 | } else if let Ok(n) = is_program_in_path("xclip") { [INFO] [stderr] 18 | Clipboard { [INFO] [stderr] 19 | cmd: n.to_owned(), [INFO] [stderr] 20 | args: &["-selection", "c"], [INFO] [stderr] 21 | } [INFO] [stderr] 22 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Clipboard<'a>` [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> Self { [INFO] [stderr] 12 | | if let Ok(n) = is_program_in_path("xsel") { [INFO] [stderr] 13 | | Clipboard { [INFO] [stderr] 14 | | cmd: n.to_owned(), [INFO] [stderr] ... | [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:71:29 [INFO] [stderr] | [INFO] [stderr] 71 | for p in path.split(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.06s [INFO] running `"docker" "inspect" "d7c9553f12d38643e5010a20ce2f8e90e506dcf76147f030e19aad49c6f97c33"` [INFO] running `"docker" "rm" "-f" "d7c9553f12d38643e5010a20ce2f8e90e506dcf76147f030e19aad49c6f97c33"` [INFO] [stdout] d7c9553f12d38643e5010a20ce2f8e90e506dcf76147f030e19aad49c6f97c33