[INFO] crate cc 1.0.25 is already in cache
[INFO] extracting crate cc 1.0.25 into work/ex/clippy-test-run/sources/stable/reg/cc/1.0.25
[INFO] extracting crate cc 1.0.25 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cc/1.0.25
[INFO] validating manifest of cc-1.0.25 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of cc-1.0.25 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing cc-1.0.25
[INFO] finished frobbing cc-1.0.25
[INFO] frobbed toml for cc-1.0.25 written to work/ex/clippy-test-run/sources/stable/reg/cc/1.0.25/Cargo.toml
[INFO] started frobbing cc-1.0.25
[INFO] finished frobbing cc-1.0.25
[INFO] frobbed toml for cc-1.0.25 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cc/1.0.25/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting cc-1.0.25 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cc/1.0.25:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c3cf2fc4bc1eb9a487fe6920ebe3037f7134bc856009d8f41d6fe2224606a3ed
[INFO] running `"docker" "start" "-a" "c3cf2fc4bc1eb9a487fe6920ebe3037f7134bc856009d8f41d6fe2224606a3ed"`
[INFO] [stderr]     Checking cc v1.0.25 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/windows_registry.rs:191:17
[INFO] [stderr]     |
[INFO] [stderr] 191 |                 tool: tool,
[INFO] [stderr]     |                 ^^^^^^^^^^ help: replace it with: `tool`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:151:13
[INFO] [stderr]     |
[INFO] [stderr] 151 |             kind: kind,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:287:18
[INFO] [stderr]     |
[INFO] [stderr] 287 |         Object { src: src, dst: dst }
[INFO] [stderr]     |                  ^^^^^^^^ help: replace it with: `src`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:287:28
[INFO] [stderr]     |
[INFO] [stderr] 287 |         Object { src: src, dst: dst }
[INFO] [stderr]     |                            ^^^^^^^^ help: replace it with: `dst`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:2025:13
[INFO] [stderr]      |
[INFO] [stderr] 2025 |             path: path,
[INFO] [stderr]      |             ^^^^^^^^^^ help: replace it with: `path`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:2030:13
[INFO] [stderr]      |
[INFO] [stderr] 2030 |             family: family,
[INFO] [stderr]      |             ^^^^^^^^^^^^^^ help: replace it with: `family`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:2031:13
[INFO] [stderr]      |
[INFO] [stderr] 2031 |             cuda: cuda,
[INFO] [stderr]      |             ^^^^^^^^^^ help: replace it with: `cuda`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]     --> src/lib.rs:2235:21
[INFO] [stderr]      |
[INFO] [stderr] 2235 |                     println!("");
[INFO] [stderr]      |                     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] error: redundant field names in struct initialization
[INFO] [stderr]    --> src/windows_registry.rs:191:17
[INFO] [stderr]     |
[INFO] [stderr] 191 |                 tool: tool,
[INFO] [stderr]     |                 ^^^^^^^^^^ help: replace it with: `tool`
[INFO] [stderr]     |
[INFO] [stderr] note: lint level defined here
[INFO] [stderr]    --> src/lib.rs:57:24
[INFO] [stderr]     |
[INFO] [stderr] 57  | #![cfg_attr(test, deny(warnings))]
[INFO] [stderr]     |                        ^^^^^^^^
[INFO] [stderr]     = note: #[deny(clippy::redundant_field_names)] implied by #[deny(warnings)]
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] error: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:151:13
[INFO] [stderr]     |
[INFO] [stderr] 151 |             kind: kind,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] error: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:287:18
[INFO] [stderr]     |
[INFO] [stderr] 287 |         Object { src: src, dst: dst }
[INFO] [stderr]     |                  ^^^^^^^^ help: replace it with: `src`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] error: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:287:28
[INFO] [stderr]     |
[INFO] [stderr] 287 |         Object { src: src, dst: dst }
[INFO] [stderr]     |                            ^^^^^^^^ help: replace it with: `dst`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] error: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:2025:13
[INFO] [stderr]      |
[INFO] [stderr] 2025 |             path: path,
[INFO] [stderr]      |             ^^^^^^^^^^ help: replace it with: `path`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] error: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:2030:13
[INFO] [stderr]      |
[INFO] [stderr] 2030 |             family: family,
[INFO] [stderr]      |             ^^^^^^^^^^^^^^ help: replace it with: `family`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] error: redundant field names in struct initialization
[INFO] [stderr]     --> src/lib.rs:2031:13
[INFO] [stderr]      |
[INFO] [stderr] 2031 |             cuda: cuda,
[INFO] [stderr]      |             ^^^^^^^^^^ help: replace it with: `cuda`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] error: using `println!("")`
[INFO] [stderr]     --> src/lib.rs:2235:21
[INFO] [stderr]      |
[INFO] [stderr] 2235 |                     println!("");
[INFO] [stderr]      |                     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]      |
[INFO] [stderr] note: lint level defined here
[INFO] [stderr]     --> src/lib.rs:57:24
[INFO] [stderr]      |
[INFO] [stderr] 57   | #![cfg_attr(test, deny(warnings))]
[INFO] [stderr]      |                        ^^^^^^^^
[INFO] [stderr]      = note: #[deny(clippy::println_empty_string)] implied by #[deny(warnings)]
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]     --> src/lib.rs:1157:24
[INFO] [stderr]      |
[INFO] [stderr] 1157 |                   } else {
[INFO] [stderr]      |  ________________________^
[INFO] [stderr] 1158 | |                     if target.contains("i586") {
[INFO] [stderr] 1159 | |                         cmd.args.push("/ARCH:IA32".into());
[INFO] [stderr] 1160 | |                     }
[INFO] [stderr] 1161 | |                 }
[INFO] [stderr]      | |_________________^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]      |
[INFO] [stderr] 1157 |                 } else if target.contains("i586") {
[INFO] [stderr] 1158 |     cmd.args.push("/ARCH:IA32".into());
[INFO] [stderr] 1159 | }
[INFO] [stderr]      |
[INFO] [stderr] 
[INFO] [stderr] error: this `else { if .. }` block can be collapsed
[INFO] [stderr]     --> src/lib.rs:1157:24
[INFO] [stderr]      |
[INFO] [stderr] 1157 |                   } else {
[INFO] [stderr]      |  ________________________^
[INFO] [stderr] 1158 | |                     if target.contains("i586") {
[INFO] [stderr] 1159 | |                         cmd.args.push("/ARCH:IA32".into());
[INFO] [stderr] 1160 | |                     }
[INFO] [stderr] 1161 | |                 }
[INFO] [stderr]      | |_________________^
[INFO] [stderr]      |
[INFO] [stderr] note: lint level defined here
[INFO] [stderr]     --> src/lib.rs:57:24
[INFO] [stderr]      |
[INFO] [stderr] 57   | #![cfg_attr(test, deny(warnings))]
[INFO] [stderr]      |                        ^^^^^^^^
[INFO] [stderr]      = note: #[deny(clippy::collapsible_if)] implied by #[deny(warnings)]
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]      |
[INFO] [stderr] 1157 |                 } else if target.contains("i586") {
[INFO] [stderr] 1158 |     cmd.args.push("/ARCH:IA32".into());
[INFO] [stderr] 1159 | }
[INFO] [stderr]      |
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/windows_registry.rs:121:9
[INFO] [stderr]     |
[INFO] [stderr] 121 |     Err(format!("not windows"))
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"not windows".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: consider using `Option<T>` instead of `Option<Option<T>>` or a custom enum if you need to distinguish all 3 cases
[INFO] [stderr]    --> src/lib.rs:102:22
[INFO] [stderr]     |
[INFO] [stderr] 102 |     cpp_link_stdlib: Option<Option<String>>,
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::option_option)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:200:24
[INFO] [stderr]     |
[INFO] [stderr] 200 |     fn add_debug_flags(&self, cmd: &mut Tool) {
[INFO] [stderr]     |                        ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:213:21
[INFO] [stderr]     |
[INFO] [stderr] 213 |     fn include_flag(&self) -> &'static str {
[INFO] [stderr]     |                     ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:221:20
[INFO] [stderr]     |
[INFO] [stderr] 221 |     fn expand_flag(&self) -> &'static str {
[INFO] [stderr]     |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:229:23
[INFO] [stderr]     |
[INFO] [stderr] 229 |     fn warnings_flags(&self) -> &'static str {
[INFO] [stderr]     |                       ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:237:29
[INFO] [stderr]     |
[INFO] [stderr] 237 |     fn extra_warnings_flags(&self) -> Option<&'static str> {
[INFO] [stderr]     |                             ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:245:32
[INFO] [stderr]     |
[INFO] [stderr] 245 |     fn warnings_to_errors_flag(&self) -> &'static str {
[INFO] [stderr]     |                                ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:254:24
[INFO] [stderr]     |
[INFO] [stderr] 254 |     fn nvcc_debug_flag(&self) -> &'static str {
[INFO] [stderr]     |                        ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:263:27
[INFO] [stderr]     |
[INFO] [stderr] 263 |     fn nvcc_redirect_flag(&self) -> &'static str {
[INFO] [stderr]     |                           ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:270:23
[INFO] [stderr]     |
[INFO] [stderr] 270 |     fn verbose_stderr(&self) -> bool {
[INFO] [stderr]     |                       ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 61
[INFO] [stderr]     --> src/lib.rs:1073:5
[INFO] [stderr]      |
[INFO] [stderr] 1073 | /     pub fn try_get_compiler(&self) -> Result<Tool, Error> {
[INFO] [stderr] 1074 | |         let opt_level = self.get_opt_level()?;
[INFO] [stderr] 1075 | |         let target = self.get_target()?;
[INFO] [stderr] 1076 | |
[INFO] [stderr] ...    |
[INFO] [stderr] 1373 | |         Ok(cmd)
[INFO] [stderr] 1374 | |     }
[INFO] [stderr]      | |_____^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]      = help: you could split it up into multiple smaller functions
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 9 previous errors
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]     --> src/lib.rs:1093:29
[INFO] [stderr]      |
[INFO] [stderr] 1093 |                             env::var("CARGO_CFG_TARGET_FEATURE").unwrap_or(String::new());
[INFO] [stderr]      |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `env::var("CARGO_CFG_TARGET_FEATURE").unwrap_or_default()`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]     --> src/lib.rs:1173:36
[INFO] [stderr]      |
[INFO] [stderr] 1173 |                     let features = env::var("CARGO_CFG_TARGET_FEATURE").unwrap_or(String::new());
[INFO] [stderr]      |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `env::var("CARGO_CFG_TARGET_FEATURE").unwrap_or_default()`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]     --> src/lib.rs:1334:36
[INFO] [stderr]      |
[INFO] [stderr] 1334 |         if self.warnings.unwrap_or(if self.has_flags() { false } else { true }) {
[INFO] [stderr]      |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `!self.has_flags()`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]     --> src/lib.rs:1339:42
[INFO] [stderr]      |
[INFO] [stderr] 1339 |         if self.extra_warnings.unwrap_or(if self.has_flags() { false } else { true }) {
[INFO] [stderr]      |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `!self.has_flags()`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `cc`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]     --> src/lib.rs:1379:16
[INFO] [stderr]      |
[INFO] [stderr] 1379 |         if let Ok(_) = flags_env_var_value { true } else { false }
[INFO] [stderr]      |         -------^^^^^---------------------------------------------- help: try this: `if flags_env_var_value.is_ok()`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]     --> src/lib.rs:1768:17
[INFO] [stderr]      |
[INFO] [stderr] 1768 |                 tool.env.len() == 0 &&
[INFO] [stderr]      |                 ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tool.env.is_empty()`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]     --> src/lib.rs:1800:9
[INFO] [stderr]      |
[INFO] [stderr] 1800 | /         self.get_var(name)
[INFO] [stderr] 1801 | |             .unwrap_or(String::new())
[INFO] [stderr]      | |_____________________________________^ help: try this: `self.get_var(name).unwrap_or_default()`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]     --> src/lib.rs:1890:58
[INFO] [stderr]      |
[INFO] [stderr] 1890 |                       } else if target.contains("freebsd") {
[INFO] [stderr]      |  __________________________________________________________^
[INFO] [stderr] 1891 | |                         Ok(Some("c++".to_string()))
[INFO] [stderr] 1892 | |                     } else if target.contains("openbsd") {
[INFO] [stderr]      | |_____________________^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr]     --> src/lib.rs:1888:56
[INFO] [stderr]      |
[INFO] [stderr] 1888 |                       } else if target.contains("apple") {
[INFO] [stderr]      |  ________________________________________________________^
[INFO] [stderr] 1889 | |                         Ok(Some("c++".to_string()))
[INFO] [stderr] 1890 | |                     } else if target.contains("freebsd") {
[INFO] [stderr]      | |_____________________^
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `cc`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "c3cf2fc4bc1eb9a487fe6920ebe3037f7134bc856009d8f41d6fe2224606a3ed"`
[INFO] running `"docker" "rm" "-f" "c3cf2fc4bc1eb9a487fe6920ebe3037f7134bc856009d8f41d6fe2224606a3ed"`
[INFO] [stdout] c3cf2fc4bc1eb9a487fe6920ebe3037f7134bc856009d8f41d6fe2224606a3ed