[INFO] crate cbor-codec 0.7.1 is already in cache [INFO] extracting crate cbor-codec 0.7.1 into work/ex/clippy-test-run/sources/stable/reg/cbor-codec/0.7.1 [INFO] extracting crate cbor-codec 0.7.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cbor-codec/0.7.1 [INFO] validating manifest of cbor-codec-0.7.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cbor-codec-0.7.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cbor-codec-0.7.1 [INFO] removed 0 missing tests [INFO] finished frobbing cbor-codec-0.7.1 [INFO] frobbed toml for cbor-codec-0.7.1 written to work/ex/clippy-test-run/sources/stable/reg/cbor-codec/0.7.1/Cargo.toml [INFO] started frobbing cbor-codec-0.7.1 [INFO] removed 0 missing tests [INFO] finished frobbing cbor-codec-0.7.1 [INFO] frobbed toml for cbor-codec-0.7.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cbor-codec/0.7.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cbor-codec-0.7.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cbor-codec/0.7.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8e26a8d0fdbfb1650fa4db0be67f96100dc410e514962db1de015dff18db2d1c [INFO] running `"docker" "start" "-a" "8e26a8d0fdbfb1650fa4db0be67f96100dc410e514962db1de015dff18db2d1c"` [INFO] [stderr] warning: An explicit [[test]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other test targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a test target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/tests/unit.rs [INFO] [stderr] * /opt/crater/workdir/tests/util.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a test target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autotests = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Checking json-codec v0.5.0 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking cbor-codec v0.7.1 (/opt/crater/workdir) [INFO] [stderr] Compiling quickcheck_macros v0.8.0 [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value.rs:348:25 [INFO] [stderr] | [INFO] [stderr] 348 | let ref m = a[1]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_chacha v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_os v0.1.1 [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/types.rs:70:21 [INFO] [stderr] | [INFO] [stderr] 70 | match ((b & 0b111_00000) >> 5, b & 0b000_11111) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_digit_groups)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/types.rs:70:44 [INFO] [stderr] | [INFO] [stderr] 70 | match ((b & 0b111_00000) >> 5, b & 0b000_11111) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0001_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:133:22 [INFO] [stderr] | [INFO] [stderr] 133 | , max_len_bytes: 0x500000 [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0050_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:134:21 [INFO] [stderr] | [INFO] [stderr] 134 | , max_len_text: 0x500000 [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0050_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:186:13 [INFO] [stderr] | [INFO] [stderr] 186 | 0x100000...0xFFFFFFFF => w.write_u8(26).and(w.write_u32::(x as u32)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:186:24 [INFO] [stderr] | [INFO] [stderr] 186 | 0x100000...0xFFFFFFFF => w.write_u8(26).and(w.write_u32::(x as u32)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:197:42 [INFO] [stderr] | [INFO] [stderr] 197 | n @ 0...23 => w.write_u8(0b001_00000 | n).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:198:42 [INFO] [stderr] | [INFO] [stderr] 198 | n => w.write_u8(0b001_00000 | 24).and(w.write_u8(n)).map_err(From::from) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:209:45 [INFO] [stderr] | [INFO] [stderr] 209 | n @ 0...23 => w.write_u8(0b001_00000 | n as u8).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:210:45 [INFO] [stderr] | [INFO] [stderr] 210 | n @ 24...0xFF => w.write_u8(0b001_00000 | 24).and(w.write_u8(n as u8)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:211:45 [INFO] [stderr] | [INFO] [stderr] 211 | n => w.write_u8(0b001_00000 | 25).and(w.write_u16::(n)).map_err(From::from) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:222:50 [INFO] [stderr] | [INFO] [stderr] 222 | n @ 0...23 => w.write_u8(0b001_00000 | n as u8).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:223:50 [INFO] [stderr] | [INFO] [stderr] 223 | n @ 24...0xFF => w.write_u8(0b001_00000 | 24).and(w.write_u8(n as u8)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:224:50 [INFO] [stderr] | [INFO] [stderr] 224 | n @ 0x100...0xFFFF => w.write_u8(0b001_00000 | 25).and(w.write_u16::(n as u16)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:225:50 [INFO] [stderr] | [INFO] [stderr] 225 | n => w.write_u8(0b001_00000 | 26).and(w.write_u32::(n)).map_err(From::from) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:236:57 [INFO] [stderr] | [INFO] [stderr] 236 | n @ 0...23 => w.write_u8(0b001_00000 | n as u8).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:237:57 [INFO] [stderr] | [INFO] [stderr] 237 | n @ 24...0xFF => w.write_u8(0b001_00000 | 24).and(w.write_u8(n as u8)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:238:57 [INFO] [stderr] | [INFO] [stderr] 238 | n @ 0x100...0xFFFF => w.write_u8(0b001_00000 | 25).and(w.write_u16::(n as u16)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:239:21 [INFO] [stderr] | [INFO] [stderr] 239 | n @ 0x100000...0xFFFFFFFF => w.write_u8(0b001_00000 | 26).and(w.write_u32::(n as u32)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:239:32 [INFO] [stderr] | [INFO] [stderr] 239 | n @ 0x100000...0xFFFFFFFF => w.write_u8(0b001_00000 | 26).and(w.write_u32::(n as u32)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:239:57 [INFO] [stderr] | [INFO] [stderr] 239 | n @ 0x100000...0xFFFFFFFF => w.write_u8(0b001_00000 | 26).and(w.write_u32::(n as u32)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:240:57 [INFO] [stderr] | [INFO] [stderr] 240 | n => w.write_u8(0b001_00000 | 27).and(w.write_u64::(n)).map_err(From::from) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:251:61 [INFO] [stderr] | [INFO] [stderr] 251 | n @ 0...23 => w.write_u8(0b001_00000 | n as u8).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:252:61 [INFO] [stderr] | [INFO] [stderr] 252 | n @ 24...0xFF => w.write_u8(0b001_00000 | 24).and(w.write_u8(n as u8)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:253:61 [INFO] [stderr] | [INFO] [stderr] 253 | n @ 0x100...0xFFFF => w.write_u8(0b001_00000 | 25).and(w.write_u16::(n as u16)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:254:25 [INFO] [stderr] | [INFO] [stderr] 254 | n @ 0x100000...0xFFFFFFFF => w.write_u8(0b001_00000 | 26).and(w.write_u32::(n as u32)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:254:36 [INFO] [stderr] | [INFO] [stderr] 254 | n @ 0x100000...0xFFFFFFFF => w.write_u8(0b001_00000 | 26).and(w.write_u32::(n as u32)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:254:61 [INFO] [stderr] | [INFO] [stderr] 254 | n @ 0x100000...0xFFFFFFFF => w.write_u8(0b001_00000 | 26).and(w.write_u32::(n as u32)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:255:61 [INFO] [stderr] | [INFO] [stderr] 255 | n => w.write_u8(0b001_00000 | 27).and(w.write_u64::(n)).map_err(From::from) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:262:30 [INFO] [stderr] | [INFO] [stderr] 262 | self.writer.write_u8(0b111_00000 | 26) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:268:30 [INFO] [stderr] | [INFO] [stderr] 268 | self.writer.write_u8(0b111_00000 | 27) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:274:30 [INFO] [stderr] | [INFO] [stderr] 274 | self.writer.write_u8(0b111_00000 | if x {21} else {20}).map_err(From::from) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:281:48 [INFO] [stderr] | [INFO] [stderr] 281 | 0...19 | 28...30 => w.write_u8(0b111_00000 | n).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:282:48 [INFO] [stderr] | [INFO] [stderr] 282 | 32...255 => w.write_u8(0b111_00000 | 24).and(w.write_u8(n)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:286:38 [INFO] [stderr] | [INFO] [stderr] 286 | 0...31 => w.write_u8(0b111_00000 | 24).and(w.write_u8(n)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:299:30 [INFO] [stderr] | [INFO] [stderr] 299 | self.writer.write_u8(0b010_11111)?; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0101_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:303:30 [INFO] [stderr] | [INFO] [stderr] 303 | self.writer.write_u8(0b111_11111).map_err(From::from) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:313:30 [INFO] [stderr] | [INFO] [stderr] 313 | self.writer.write_u8(0b011_11111)?; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:317:30 [INFO] [stderr] | [INFO] [stderr] 317 | self.writer.write_u8(0b111_11111).map_err(From::from) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:321:30 [INFO] [stderr] | [INFO] [stderr] 321 | self.writer.write_u8(0b111_00000 | 22).map_err(From::from) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:325:30 [INFO] [stderr] | [INFO] [stderr] 325 | self.writer.write_u8(0b111_00000 | 23).map_err(From::from) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:338:30 [INFO] [stderr] | [INFO] [stderr] 338 | self.writer.write_u8(0b100_11111).map_err(From::from) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1001_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:343:30 [INFO] [stderr] | [INFO] [stderr] 343 | self.writer.write_u8(0b111_11111).map_err(From::from) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:352:30 [INFO] [stderr] | [INFO] [stderr] 352 | self.writer.write_u8(0b101_11111).map_err(From::from) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1011_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:357:30 [INFO] [stderr] | [INFO] [stderr] 357 | self.writer.write_u8(0b111_11111).map_err(From::from) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:366:13 [INFO] [stderr] | [INFO] [stderr] 366 | 0x100000...0xFFFFFFFF => w.write_u8(t.major() << 5 | 26).and(w.write_u32::(x as u32)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:366:24 [INFO] [stderr] | [INFO] [stderr] 366 | 0x100000...0xFFFFFFFF => w.write_u8(t.major() << 5 | 26).and(w.write_u32::(x as u32)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types.rs:40:18 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn major(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/value.rs:347:21 [INFO] [stderr] | [INFO] [stderr] 347 | let ref e = a[0]; [INFO] [stderr] | ----^^^^^-------- help: try: `let e = &a[0];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/value.rs:348:21 [INFO] [stderr] | [INFO] [stderr] 348 | let ref m = a[1]; [INFO] [stderr] | ----^^^^^-------- help: try: `let m = &a[1];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoder.rs:383:34 [INFO] [stderr] | [INFO] [stderr] 383 | pub fn simple(&mut self, ti: &TypeInfo) -> DecodeResult { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `TypeInfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoder.rs:391:32 [INFO] [stderr] | [INFO] [stderr] 391 | pub fn bool(&mut self, ti: &TypeInfo) -> DecodeResult { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `TypeInfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoder.rs:399:30 [INFO] [stderr] | [INFO] [stderr] 399 | pub fn u8(&mut self, ti: &TypeInfo) -> DecodeResult { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `TypeInfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoder.rs:407:31 [INFO] [stderr] | [INFO] [stderr] 407 | pub fn u16(&mut self, ti: &TypeInfo) -> DecodeResult { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `TypeInfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:409:45 [INFO] [stderr] | [INFO] [stderr] 409 | (Type::UInt8, n @ 0...23) => Ok(n as u16), [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:410:65 [INFO] [stderr] | [INFO] [stderr] 410 | (Type::UInt8, 24) => self.reader.read_u8().map(|n| n as u16).map_err(From::from), [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoder.rs:416:31 [INFO] [stderr] | [INFO] [stderr] 416 | pub fn u32(&mut self, ti: &TypeInfo) -> DecodeResult { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `TypeInfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:418:45 [INFO] [stderr] | [INFO] [stderr] 418 | (Type::UInt8, n @ 0...23) => Ok(n as u32), [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:419:65 [INFO] [stderr] | [INFO] [stderr] 419 | (Type::UInt8, 24) => self.reader.read_u8().map(|n| n as u32).map_err(From::from), [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:420:79 [INFO] [stderr] | [INFO] [stderr] 420 | (Type::UInt16, 25) => self.reader.read_u16::().map(|n| n as u32).map_err(From::from), [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoder.rs:426:31 [INFO] [stderr] | [INFO] [stderr] 426 | pub fn u64(&mut self, ti: &TypeInfo) -> DecodeResult { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `TypeInfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:428:45 [INFO] [stderr] | [INFO] [stderr] 428 | (Type::UInt8, n @ 0...23) => Ok(n as u64), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:429:65 [INFO] [stderr] | [INFO] [stderr] 429 | (Type::UInt8, 24) => self.reader.read_u8().map(|n| n as u64).map_err(From::from), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:430:79 [INFO] [stderr] | [INFO] [stderr] 430 | (Type::UInt16, 25) => self.reader.read_u16::().map(|n| n as u64).map_err(From::from), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:431:79 [INFO] [stderr] | [INFO] [stderr] 431 | (Type::UInt32, 26) => self.reader.read_u32::().map(|n| n as u64).map_err(From::from), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoder.rs:437:30 [INFO] [stderr] | [INFO] [stderr] 437 | pub fn i8(&mut self, ti: &TypeInfo) -> DecodeResult { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `TypeInfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:320:50 [INFO] [stderr] | [INFO] [stderr] 320 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 440 | (Type::Int8, 24) => read_signed_byte!(self, u8, i8, i8), [INFO] [stderr] | ----------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:349:50 [INFO] [stderr] | [INFO] [stderr] 349 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 441 | (Type::UInt8, _) => cast_unsigned!(self, u8, ti, u8, i8, i8), [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoder.rs:446:31 [INFO] [stderr] | [INFO] [stderr] 446 | pub fn i16(&mut self, ti: &TypeInfo) -> DecodeResult { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `TypeInfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:448:49 [INFO] [stderr] | [INFO] [stderr] 448 | (Type::Int8, n @ 0...23) => Ok(-1 - n as i16), [INFO] [stderr] | ^^^^^^^^ help: try: `i16::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:320:50 [INFO] [stderr] | [INFO] [stderr] 320 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 449 | (Type::Int8, 24) => read_signed_byte!(self, u8, i16, i16), [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:322:29 [INFO] [stderr] | [INFO] [stderr] 322 | Ok(-1 - n as $to_type) [INFO] [stderr] | ^ help: try: `i16::from(n)` [INFO] [stderr] ... [INFO] [stderr] 449 | (Type::Int8, 24) => read_signed_byte!(self, u8, i16, i16), [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:335:50 [INFO] [stderr] | [INFO] [stderr] 335 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 450 | (Type::Int16, 25) => read_signed!(self, read_u16, u16, i16, i16), [INFO] [stderr] | ------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:349:50 [INFO] [stderr] | [INFO] [stderr] 349 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 451 | (Type::UInt8, _) => cast_unsigned!(self, u8, ti, u8, i16, i16), [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:351:24 [INFO] [stderr] | [INFO] [stderr] 351 | Ok(n as $to_type) [INFO] [stderr] | ^ help: try: `i16::from(n)` [INFO] [stderr] ... [INFO] [stderr] 451 | (Type::UInt8, _) => cast_unsigned!(self, u8, ti, u8, i16, i16), [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:349:50 [INFO] [stderr] | [INFO] [stderr] 349 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 452 | (Type::UInt16, _) => cast_unsigned!(self, u16, ti, u16, i16, i16), [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoder.rs:457:31 [INFO] [stderr] | [INFO] [stderr] 457 | pub fn i32(&mut self, ti: &TypeInfo) -> DecodeResult { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `TypeInfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:459:49 [INFO] [stderr] | [INFO] [stderr] 459 | (Type::Int8, n @ 0...23) => Ok(-1 - n as i32), [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:320:50 [INFO] [stderr] | [INFO] [stderr] 320 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 460 | (Type::Int8, 24) => read_signed_byte!(self, u8, i32, i32), [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:322:29 [INFO] [stderr] | [INFO] [stderr] 322 | Ok(-1 - n as $to_type) [INFO] [stderr] | ^ help: try: `i32::from(n)` [INFO] [stderr] ... [INFO] [stderr] 460 | (Type::Int8, 24) => read_signed_byte!(self, u8, i32, i32), [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:335:50 [INFO] [stderr] | [INFO] [stderr] 335 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 461 | (Type::Int16, 25) => read_signed!(self, read_u16, u16, i32, i32), [INFO] [stderr] | ------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:337:29 [INFO] [stderr] | [INFO] [stderr] 337 | Ok(-1 - n as $to_type) [INFO] [stderr] | ^ help: try: `i32::from(n)` [INFO] [stderr] ... [INFO] [stderr] 461 | (Type::Int16, 25) => read_signed!(self, read_u16, u16, i32, i32), [INFO] [stderr] | ------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:335:50 [INFO] [stderr] | [INFO] [stderr] 335 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 462 | (Type::Int32, 26) => read_signed!(self, read_u32, u32, i32, i32), [INFO] [stderr] | ------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:349:50 [INFO] [stderr] | [INFO] [stderr] 349 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 463 | (Type::UInt8, _) => cast_unsigned!(self, u8, ti, u8, i32, i32), [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:351:24 [INFO] [stderr] | [INFO] [stderr] 351 | Ok(n as $to_type) [INFO] [stderr] | ^ help: try: `i32::from(n)` [INFO] [stderr] ... [INFO] [stderr] 463 | (Type::UInt8, _) => cast_unsigned!(self, u8, ti, u8, i32, i32), [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:349:50 [INFO] [stderr] | [INFO] [stderr] 349 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 464 | (Type::UInt16, _) => cast_unsigned!(self, u16, ti, u16, i32, i32), [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:351:24 [INFO] [stderr] | [INFO] [stderr] 351 | Ok(n as $to_type) [INFO] [stderr] | ^ help: try: `i32::from(n)` [INFO] [stderr] ... [INFO] [stderr] 464 | (Type::UInt16, _) => cast_unsigned!(self, u16, ti, u16, i32, i32), [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:349:50 [INFO] [stderr] | [INFO] [stderr] 349 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 465 | (Type::UInt32, _) => cast_unsigned!(self, u32, ti, u32, i32, i32), [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoder.rs:470:31 [INFO] [stderr] | [INFO] [stderr] 470 | pub fn i64(&mut self, ti: &TypeInfo) -> DecodeResult { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `TypeInfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:472:49 [INFO] [stderr] | [INFO] [stderr] 472 | (Type::Int8, n @ 0...23) => Ok(-1 - n as i64), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:320:50 [INFO] [stderr] | [INFO] [stderr] 320 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 473 | (Type::Int8, 24) => read_signed_byte!(self, u8, i64, i64), [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:322:29 [INFO] [stderr] | [INFO] [stderr] 322 | Ok(-1 - n as $to_type) [INFO] [stderr] | ^ help: try: `i64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 473 | (Type::Int8, 24) => read_signed_byte!(self, u8, i64, i64), [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:335:50 [INFO] [stderr] | [INFO] [stderr] 335 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 474 | (Type::Int16, 25) => read_signed!(self, read_u16, u16, i64, i64), [INFO] [stderr] | ------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:337:29 [INFO] [stderr] | [INFO] [stderr] 337 | Ok(-1 - n as $to_type) [INFO] [stderr] | ^ help: try: `i64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 474 | (Type::Int16, 25) => read_signed!(self, read_u16, u16, i64, i64), [INFO] [stderr] | ------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:335:50 [INFO] [stderr] | [INFO] [stderr] 335 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 475 | (Type::Int32, 26) => read_signed!(self, read_u32, u32, i64, i64), [INFO] [stderr] | ------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:337:29 [INFO] [stderr] | [INFO] [stderr] 337 | Ok(-1 - n as $to_type) [INFO] [stderr] | ^ help: try: `i64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 475 | (Type::Int32, 26) => read_signed!(self, read_u32, u32, i64, i64), [INFO] [stderr] | ------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:349:50 [INFO] [stderr] | [INFO] [stderr] 349 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 477 | (Type::UInt8, _) => cast_unsigned!(self, u8, ti, u8, i64, i64), [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:351:24 [INFO] [stderr] | [INFO] [stderr] 351 | Ok(n as $to_type) [INFO] [stderr] | ^ help: try: `i64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 477 | (Type::UInt8, _) => cast_unsigned!(self, u8, ti, u8, i64, i64), [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:349:50 [INFO] [stderr] | [INFO] [stderr] 349 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 478 | (Type::UInt16, _) => cast_unsigned!(self, u16, ti, u16, i64, i64), [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:351:24 [INFO] [stderr] | [INFO] [stderr] 351 | Ok(n as $to_type) [INFO] [stderr] | ^ help: try: `i64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 478 | (Type::UInt16, _) => cast_unsigned!(self, u16, ti, u16, i64, i64), [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:349:50 [INFO] [stderr] | [INFO] [stderr] 349 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 479 | (Type::UInt32, _) => cast_unsigned!(self, u32, ti, u32, i64, i64), [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:351:24 [INFO] [stderr] | [INFO] [stderr] 351 | Ok(n as $to_type) [INFO] [stderr] | ^ help: try: `i64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 479 | (Type::UInt32, _) => cast_unsigned!(self, u32, ti, u32, i64, i64), [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoder.rs:485:31 [INFO] [stderr] | [INFO] [stderr] 485 | pub fn int(&mut self, ti: &TypeInfo) -> DecodeResult { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `TypeInfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoder.rs:503:31 [INFO] [stderr] | [INFO] [stderr] 503 | pub fn f16(&mut self, ti: &TypeInfo) -> DecodeResult { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `TypeInfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:511:41 [INFO] [stderr] | [INFO] [stderr] 511 | 0 => ffi::c_ldexpf(mant as f32, -24), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(mant)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:513:41 [INFO] [stderr] | [INFO] [stderr] 513 | _ => ffi::c_ldexpf(mant as f32 + 1024.0, exp as isize - 25) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(mant)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoder.rs:521:31 [INFO] [stderr] | [INFO] [stderr] 521 | pub fn f32(&mut self, ti: &TypeInfo) -> DecodeResult { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `TypeInfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoder.rs:528:31 [INFO] [stderr] | [INFO] [stderr] 528 | pub fn f64(&mut self, ti: &TypeInfo) -> DecodeResult { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `TypeInfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:539:30 [INFO] [stderr] | [INFO] [stderr] 539 | n @ 0...23 => Ok(n as u64), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:540:49 [INFO] [stderr] | [INFO] [stderr] 540 | 24 => self.reader.read_u8().map(|n| n as u64).map_err(From::from), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:541:63 [INFO] [stderr] | [INFO] [stderr] 541 | 25 => self.reader.read_u16::().map(|n| n as u64).map_err(From::from), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:542:63 [INFO] [stderr] | [INFO] [stderr] 542 | 26 => self.reader.read_u32::().map(|n| n as u64).map_err(From::from), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoder.rs:626:27 [INFO] [stderr] | [INFO] [stderr] 626 | fn unexpected_type(ti: &TypeInfo) -> DecodeResult { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `TypeInfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: defining a method called `borrow_mut` on this type; consider implementing the `std::borrow::BorrowMut` trait or choosing a less ambiguous name [INFO] [stderr] --> src/decoder.rs:1054:5 [INFO] [stderr] | [INFO] [stderr] 1054 | / pub fn borrow_mut(&mut self) -> &mut Decoder { [INFO] [stderr] 1055 | | &mut self.decoder [INFO] [stderr] 1056 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:1079:32 [INFO] [stderr] | [INFO] [stderr] 1079 | if n > i8::MAX as i16 || n < i8::MIN as i16 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i16::from(i8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:1079:54 [INFO] [stderr] | [INFO] [stderr] 1079 | if n > i8::MAX as i16 || n < i8::MIN as i16 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i16::from(i8::MIN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:1088:32 [INFO] [stderr] | [INFO] [stderr] 1088 | if n > i16::MAX as i32 || n < i16::MIN as i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(i16::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:1088:55 [INFO] [stderr] | [INFO] [stderr] 1088 | if n > i16::MAX as i32 || n < i16::MIN as i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(i16::MIN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:1097:32 [INFO] [stderr] | [INFO] [stderr] 1097 | if n > i32::MAX as i64 || n < i32::MIN as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(i32::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:1097:55 [INFO] [stderr] | [INFO] [stderr] 1097 | if n > i32::MAX as i64 || n < i32::MIN as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(i32::MIN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:1254:44 [INFO] [stderr] | [INFO] [stderr] 1254 | Value::I8(x) => Ok(Key::i64(x as i64)), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:1255:44 [INFO] [stderr] | [INFO] [stderr] 1255 | Value::I16(x) => Ok(Key::i64(x as i64)), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:1256:44 [INFO] [stderr] | [INFO] [stderr] 1256 | Value::I32(x) => Ok(Key::i64(x as i64)), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:1258:44 [INFO] [stderr] | [INFO] [stderr] 1258 | Value::U8(x) => Ok(Key::u64(x as u64)), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:1259:44 [INFO] [stderr] | [INFO] [stderr] 1259 | Value::U16(x) => Ok(Key::u64(x as u64)), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:1260:44 [INFO] [stderr] | [INFO] [stderr] 1260 | Value::U32(x) => Ok(Key::u64(x as u64)), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/encoder.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | let ref mut w = self.writer; [INFO] [stderr] | ----^^^^^^^^^--------------- help: try: `let w = &mut self.writer;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/encoder.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | let ref mut w = self.writer; [INFO] [stderr] | ----^^^^^^^^^--------------- help: try: `let w = &mut self.writer;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/encoder.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | let ref mut w = self.writer; [INFO] [stderr] | ----^^^^^^^^^--------------- help: try: `let w = &mut self.writer;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/encoder.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | let ref mut w = self.writer; [INFO] [stderr] | ----^^^^^^^^^--------------- help: try: `let w = &mut self.writer;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/encoder.rs:195:17 [INFO] [stderr] | [INFO] [stderr] 195 | let ref mut w = self.writer; [INFO] [stderr] | ----^^^^^^^^^--------------- help: try: `let w = &mut self.writer;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/encoder.rs:207:17 [INFO] [stderr] | [INFO] [stderr] 207 | let ref mut w = self.writer; [INFO] [stderr] | ----^^^^^^^^^--------------- help: try: `let w = &mut self.writer;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/encoder.rs:220:17 [INFO] [stderr] | [INFO] [stderr] 220 | let ref mut w = self.writer; [INFO] [stderr] | ----^^^^^^^^^--------------- help: try: `let w = &mut self.writer;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/encoder.rs:234:17 [INFO] [stderr] | [INFO] [stderr] 234 | let ref mut w = self.writer; [INFO] [stderr] | ----^^^^^^^^^--------------- help: try: `let w = &mut self.writer;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/encoder.rs:249:21 [INFO] [stderr] | [INFO] [stderr] 249 | let ref mut w = self.writer; [INFO] [stderr] | ----^^^^^^^^^--------------- help: try: `let w = &mut self.writer;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/encoder.rs:278:13 [INFO] [stderr] | [INFO] [stderr] 278 | let ref mut w = self.writer; [INFO] [stderr] | ----^^^^^^^^^--------------- help: try: `let w = &mut self.writer;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/encoder.rs:361:13 [INFO] [stderr] | [INFO] [stderr] 361 | let ref mut w = self.writer; [INFO] [stderr] | ----^^^^^^^^^--------------- help: try: `let w = &mut self.writer;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: defining a method called `borrow_mut` on this type; consider implementing the `std::borrow::BorrowMut` trait or choosing a less ambiguous name [INFO] [stderr] --> src/encoder.rs:392:5 [INFO] [stderr] | [INFO] [stderr] 392 | / pub fn borrow_mut(&mut self) -> &mut Encoder { [INFO] [stderr] 393 | | &mut self.encoder [INFO] [stderr] 394 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] Checking rand_pcg v0.1.1 [INFO] [stderr] Checking rand v0.6.5 [INFO] [stderr] Checking quickcheck v0.8.0 [INFO] [stderr] error: /opt/crater/target/debug/deps/libquickcheck_macros-362838aae9874166.so: undefined symbol: __rustc_plugin_registrar_ef77e7f38cff0715cf62d85d28077422__ [INFO] [stderr] --> tests/lib.rs:7:11 [INFO] [stderr] | [INFO] [stderr] 7 | #![plugin(quickcheck_macros)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `cbor-codec`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value.rs:348:25 [INFO] [stderr] | [INFO] [stderr] 348 | let ref m = a[1]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/types.rs:70:21 [INFO] [stderr] | [INFO] [stderr] 70 | match ((b & 0b111_00000) >> 5, b & 0b000_11111) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_digit_groups)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/types.rs:70:44 [INFO] [stderr] | [INFO] [stderr] 70 | match ((b & 0b111_00000) >> 5, b & 0b000_11111) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0001_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:133:22 [INFO] [stderr] | [INFO] [stderr] 133 | , max_len_bytes: 0x500000 [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0050_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:134:21 [INFO] [stderr] | [INFO] [stderr] 134 | , max_len_text: 0x500000 [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0050_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:1291:25 [INFO] [stderr] | [INFO] [stderr] 1291 | assert_eq!(Some(1000000), decoder("1a000f4240").u32().ok()); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:1292:25 [INFO] [stderr] | [INFO] [stderr] 1292 | assert_eq!(Some(1000000000000), decoder("1b000000e8d4a51000").u64().ok()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_000_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:1293:25 [INFO] [stderr] | [INFO] [stderr] 1293 | assert_eq!(Some(18446744073709551615), decoder("1bffffffffffffffff").u64().ok()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `18_446_744_073_709_551_615` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:1303:26 [INFO] [stderr] | [INFO] [stderr] 1303 | assert_eq!(Some(-343434), decoder("3a00053d89").i32().ok()); [INFO] [stderr] | ^^^^^^ help: consider: `343_434` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:1304:26 [INFO] [stderr] | [INFO] [stderr] 1304 | assert_eq!(Some(-23764523654), decoder("3b000000058879da85").i64().ok()) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `23_764_523_654` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:1317:25 [INFO] [stderr] | [INFO] [stderr] 1317 | assert_eq!(Some(1000000), decoder("1a000f4240").i32().ok()); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:1330:30 [INFO] [stderr] | [INFO] [stderr] 1330 | assert_eq!(Some(Some(1000000)), decoder("1a000f4240").int().ok().map(|n| n.i64())); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:1331:30 [INFO] [stderr] | [INFO] [stderr] 1331 | assert_eq!(Some(Some(1000000000000)), decoder("1b000000e8d4a51000").int().ok().map(|n| n.i64())); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_000_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:1333:30 [INFO] [stderr] | [INFO] [stderr] 1333 | assert_eq!(Some(Some(0xffffffffffffffff)), decoder("1bffffffffffffffff").int().ok().map(|n| n.u64())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:1334:30 [INFO] [stderr] | [INFO] [stderr] 1334 | assert_eq!(Some(Some(0x7fffffffffffffff)), decoder("1b7fffffffffffffff").int().ok().map(|n| n.i64())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x7fff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:1335:31 [INFO] [stderr] | [INFO] [stderr] 1335 | assert_eq!(Some(Some(-9223372036854775808)), decoder("3b7fffffffffffffff").int().ok().map(|n| n.i64())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_808` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:1342:31 [INFO] [stderr] | [INFO] [stderr] 1342 | assert_eq!(Some(Some(-343434)), decoder("3a00053d89").int().ok().map(|n| n.i64())); [INFO] [stderr] | ^^^^^^ help: consider: `343_434` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:1343:31 [INFO] [stderr] | [INFO] [stderr] 1343 | assert_eq!(Some(Some(-23764523654)), decoder("3b000000058879da85").int().ok().map(|n| n.i64())); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `23_764_523_654` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:1358:25 [INFO] [stderr] | [INFO] [stderr] 1358 | assert_eq!(Some(100000.0), decoder("fa47c35000").f32().ok()); [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:1359:25 [INFO] [stderr] | [INFO] [stderr] 1359 | assert_eq!(Some(3.4028234663852886e+38), decoder("fa7f7fffff").f32().ok()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `3.402_823_466_385_288_6e+38` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:1516:25 [INFO] [stderr] | [INFO] [stderr] 1516 | assert_eq!(Some(1363896240), decoder("c11a514b67b0").u32().ok()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_363_896_240` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:1520:25 [INFO] [stderr] | [INFO] [stderr] 1520 | assert_eq!(Some(1363896240), d.u32().ok()) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_363_896_240` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:1526:77 [INFO] [stderr] | [INFO] [stderr] 1526 | Some(Value::Tagged(Tag::Timestamp, ref v)) if **v == Value::U32(1363896240) => (), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_363_896_240` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:1530:77 [INFO] [stderr] | [INFO] [stderr] 1530 | Some(Value::Tagged(Tag::Timestamp, ref v)) if **v == Value::F64(1363896240.5) => (), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `1_363_896_240.5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:186:13 [INFO] [stderr] | [INFO] [stderr] 186 | 0x100000...0xFFFFFFFF => w.write_u8(26).and(w.write_u32::(x as u32)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:186:24 [INFO] [stderr] | [INFO] [stderr] 186 | 0x100000...0xFFFFFFFF => w.write_u8(26).and(w.write_u32::(x as u32)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:197:42 [INFO] [stderr] | [INFO] [stderr] 197 | n @ 0...23 => w.write_u8(0b001_00000 | n).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:198:42 [INFO] [stderr] | [INFO] [stderr] 198 | n => w.write_u8(0b001_00000 | 24).and(w.write_u8(n)).map_err(From::from) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:209:45 [INFO] [stderr] | [INFO] [stderr] 209 | n @ 0...23 => w.write_u8(0b001_00000 | n as u8).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:210:45 [INFO] [stderr] | [INFO] [stderr] 210 | n @ 24...0xFF => w.write_u8(0b001_00000 | 24).and(w.write_u8(n as u8)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:211:45 [INFO] [stderr] | [INFO] [stderr] 211 | n => w.write_u8(0b001_00000 | 25).and(w.write_u16::(n)).map_err(From::from) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:222:50 [INFO] [stderr] | [INFO] [stderr] 222 | n @ 0...23 => w.write_u8(0b001_00000 | n as u8).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:223:50 [INFO] [stderr] | [INFO] [stderr] 223 | n @ 24...0xFF => w.write_u8(0b001_00000 | 24).and(w.write_u8(n as u8)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:224:50 [INFO] [stderr] | [INFO] [stderr] 224 | n @ 0x100...0xFFFF => w.write_u8(0b001_00000 | 25).and(w.write_u16::(n as u16)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:225:50 [INFO] [stderr] | [INFO] [stderr] 225 | n => w.write_u8(0b001_00000 | 26).and(w.write_u32::(n)).map_err(From::from) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:236:57 [INFO] [stderr] | [INFO] [stderr] 236 | n @ 0...23 => w.write_u8(0b001_00000 | n as u8).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:237:57 [INFO] [stderr] | [INFO] [stderr] 237 | n @ 24...0xFF => w.write_u8(0b001_00000 | 24).and(w.write_u8(n as u8)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:238:57 [INFO] [stderr] | [INFO] [stderr] 238 | n @ 0x100...0xFFFF => w.write_u8(0b001_00000 | 25).and(w.write_u16::(n as u16)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:239:21 [INFO] [stderr] | [INFO] [stderr] 239 | n @ 0x100000...0xFFFFFFFF => w.write_u8(0b001_00000 | 26).and(w.write_u32::(n as u32)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:239:32 [INFO] [stderr] | [INFO] [stderr] 239 | n @ 0x100000...0xFFFFFFFF => w.write_u8(0b001_00000 | 26).and(w.write_u32::(n as u32)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:239:57 [INFO] [stderr] | [INFO] [stderr] 239 | n @ 0x100000...0xFFFFFFFF => w.write_u8(0b001_00000 | 26).and(w.write_u32::(n as u32)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:240:57 [INFO] [stderr] | [INFO] [stderr] 240 | n => w.write_u8(0b001_00000 | 27).and(w.write_u64::(n)).map_err(From::from) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:251:61 [INFO] [stderr] | [INFO] [stderr] 251 | n @ 0...23 => w.write_u8(0b001_00000 | n as u8).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:252:61 [INFO] [stderr] | [INFO] [stderr] 252 | n @ 24...0xFF => w.write_u8(0b001_00000 | 24).and(w.write_u8(n as u8)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:253:61 [INFO] [stderr] | [INFO] [stderr] 253 | n @ 0x100...0xFFFF => w.write_u8(0b001_00000 | 25).and(w.write_u16::(n as u16)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:254:25 [INFO] [stderr] | [INFO] [stderr] 254 | n @ 0x100000...0xFFFFFFFF => w.write_u8(0b001_00000 | 26).and(w.write_u32::(n as u32)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:254:36 [INFO] [stderr] | [INFO] [stderr] 254 | n @ 0x100000...0xFFFFFFFF => w.write_u8(0b001_00000 | 26).and(w.write_u32::(n as u32)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:254:61 [INFO] [stderr] | [INFO] [stderr] 254 | n @ 0x100000...0xFFFFFFFF => w.write_u8(0b001_00000 | 26).and(w.write_u32::(n as u32)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:255:61 [INFO] [stderr] | [INFO] [stderr] 255 | n => w.write_u8(0b001_00000 | 27).and(w.write_u64::(n)).map_err(From::from) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:262:30 [INFO] [stderr] | [INFO] [stderr] 262 | self.writer.write_u8(0b111_00000 | 26) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:268:30 [INFO] [stderr] | [INFO] [stderr] 268 | self.writer.write_u8(0b111_00000 | 27) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:274:30 [INFO] [stderr] | [INFO] [stderr] 274 | self.writer.write_u8(0b111_00000 | if x {21} else {20}).map_err(From::from) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:281:48 [INFO] [stderr] | [INFO] [stderr] 281 | 0...19 | 28...30 => w.write_u8(0b111_00000 | n).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:282:48 [INFO] [stderr] | [INFO] [stderr] 282 | 32...255 => w.write_u8(0b111_00000 | 24).and(w.write_u8(n)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:286:38 [INFO] [stderr] | [INFO] [stderr] 286 | 0...31 => w.write_u8(0b111_00000 | 24).and(w.write_u8(n)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:299:30 [INFO] [stderr] | [INFO] [stderr] 299 | self.writer.write_u8(0b010_11111)?; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0101_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:303:30 [INFO] [stderr] | [INFO] [stderr] 303 | self.writer.write_u8(0b111_11111).map_err(From::from) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:313:30 [INFO] [stderr] | [INFO] [stderr] 313 | self.writer.write_u8(0b011_11111)?; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:317:30 [INFO] [stderr] | [INFO] [stderr] 317 | self.writer.write_u8(0b111_11111).map_err(From::from) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:321:30 [INFO] [stderr] | [INFO] [stderr] 321 | self.writer.write_u8(0b111_00000 | 22).map_err(From::from) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:325:30 [INFO] [stderr] | [INFO] [stderr] 325 | self.writer.write_u8(0b111_00000 | 23).map_err(From::from) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:338:30 [INFO] [stderr] | [INFO] [stderr] 338 | self.writer.write_u8(0b100_11111).map_err(From::from) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1001_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:343:30 [INFO] [stderr] | [INFO] [stderr] 343 | self.writer.write_u8(0b111_11111).map_err(From::from) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:352:30 [INFO] [stderr] | [INFO] [stderr] 352 | self.writer.write_u8(0b101_11111).map_err(From::from) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1011_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encoder.rs:357:30 [INFO] [stderr] | [INFO] [stderr] 357 | self.writer.write_u8(0b111_11111).map_err(From::from) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:366:13 [INFO] [stderr] | [INFO] [stderr] 366 | 0x100000...0xFFFFFFFF => w.write_u8(t.major() << 5 | 26).and(w.write_u32::(x as u32)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:366:24 [INFO] [stderr] | [INFO] [stderr] 366 | 0x100000...0xFFFFFFFF => w.write_u8(t.major() << 5 | 26).and(w.write_u32::(x as u32)).map_err(From::from), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:472:45 [INFO] [stderr] | [INFO] [stderr] 472 | encoded("1a000f4240", |mut e| e.u32(1000000)); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:473:53 [INFO] [stderr] | [INFO] [stderr] 473 | encoded("1b000000e8d4a51000", |mut e| e.u64(1000000000000)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_000_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:474:53 [INFO] [stderr] | [INFO] [stderr] 474 | encoded("1bffffffffffffffff", |mut e| e.u64(18446744073709551615)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `18_446_744_073_709_551_615` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:484:46 [INFO] [stderr] | [INFO] [stderr] 484 | encoded("3a00053d89", |mut e| e.i32(-343434)); [INFO] [stderr] | ^^^^^^ help: consider: `343_434` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:485:54 [INFO] [stderr] | [INFO] [stderr] 485 | encoded("3b000000058879da85", |mut e| e.i64(-23764523654)) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `23_764_523_654` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:503:45 [INFO] [stderr] | [INFO] [stderr] 503 | encoded("fa47c35000", |mut e| e.f32(100000.0)); [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:504:45 [INFO] [stderr] | [INFO] [stderr] 504 | encoded("fa7f7fffff", |mut e| e.f32(3.4028234663852886e+38)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `3.402_823_466_385_288_6e+38` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoder.rs:552:19 [INFO] [stderr] | [INFO] [stderr] 552 | e.u32(1363896240) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_363_896_240` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types.rs:40:18 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn major(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error[E0432]: unresolved import `cbor::random` [INFO] [stderr] --> benches/lib.rs:13:11 [INFO] [stderr] | [INFO] [stderr] 13 | use cbor::random::gen_value; [INFO] [stderr] | ^^^^^^ could not find `random` in `cbor` [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/lib.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] Some errors occurred: E0432, E0554. [INFO] [stderr] For more information about an error, try `rustc --explain E0432`. [INFO] [stderr] error: Could not compile `cbor-codec`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/value.rs:347:21 [INFO] [stderr] | [INFO] [stderr] 347 | let ref e = a[0]; [INFO] [stderr] | ----^^^^^-------- help: try: `let e = &a[0];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/value.rs:348:21 [INFO] [stderr] | [INFO] [stderr] 348 | let ref m = a[1]; [INFO] [stderr] | ----^^^^^-------- help: try: `let m = &a[1];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoder.rs:383:34 [INFO] [stderr] | [INFO] [stderr] 383 | pub fn simple(&mut self, ti: &TypeInfo) -> DecodeResult { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `TypeInfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoder.rs:391:32 [INFO] [stderr] | [INFO] [stderr] 391 | pub fn bool(&mut self, ti: &TypeInfo) -> DecodeResult { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `TypeInfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoder.rs:399:30 [INFO] [stderr] | [INFO] [stderr] 399 | pub fn u8(&mut self, ti: &TypeInfo) -> DecodeResult { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `TypeInfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoder.rs:407:31 [INFO] [stderr] | [INFO] [stderr] 407 | pub fn u16(&mut self, ti: &TypeInfo) -> DecodeResult { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `TypeInfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:409:45 [INFO] [stderr] | [INFO] [stderr] 409 | (Type::UInt8, n @ 0...23) => Ok(n as u16), [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:410:65 [INFO] [stderr] | [INFO] [stderr] 410 | (Type::UInt8, 24) => self.reader.read_u8().map(|n| n as u16).map_err(From::from), [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoder.rs:416:31 [INFO] [stderr] | [INFO] [stderr] 416 | pub fn u32(&mut self, ti: &TypeInfo) -> DecodeResult { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `TypeInfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:418:45 [INFO] [stderr] | [INFO] [stderr] 418 | (Type::UInt8, n @ 0...23) => Ok(n as u32), [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:419:65 [INFO] [stderr] | [INFO] [stderr] 419 | (Type::UInt8, 24) => self.reader.read_u8().map(|n| n as u32).map_err(From::from), [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:420:79 [INFO] [stderr] | [INFO] [stderr] 420 | (Type::UInt16, 25) => self.reader.read_u16::().map(|n| n as u32).map_err(From::from), [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoder.rs:426:31 [INFO] [stderr] | [INFO] [stderr] 426 | pub fn u64(&mut self, ti: &TypeInfo) -> DecodeResult { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `TypeInfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:428:45 [INFO] [stderr] | [INFO] [stderr] 428 | (Type::UInt8, n @ 0...23) => Ok(n as u64), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:429:65 [INFO] [stderr] | [INFO] [stderr] 429 | (Type::UInt8, 24) => self.reader.read_u8().map(|n| n as u64).map_err(From::from), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:430:79 [INFO] [stderr] | [INFO] [stderr] 430 | (Type::UInt16, 25) => self.reader.read_u16::().map(|n| n as u64).map_err(From::from), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:431:79 [INFO] [stderr] | [INFO] [stderr] 431 | (Type::UInt32, 26) => self.reader.read_u32::().map(|n| n as u64).map_err(From::from), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoder.rs:437:30 [INFO] [stderr] | [INFO] [stderr] 437 | pub fn i8(&mut self, ti: &TypeInfo) -> DecodeResult { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `TypeInfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:320:50 [INFO] [stderr] | [INFO] [stderr] 320 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 440 | (Type::Int8, 24) => read_signed_byte!(self, u8, i8, i8), [INFO] [stderr] | ----------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:349:50 [INFO] [stderr] | [INFO] [stderr] 349 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 441 | (Type::UInt8, _) => cast_unsigned!(self, u8, ti, u8, i8, i8), [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoder.rs:446:31 [INFO] [stderr] | [INFO] [stderr] 446 | pub fn i16(&mut self, ti: &TypeInfo) -> DecodeResult { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `TypeInfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:448:49 [INFO] [stderr] | [INFO] [stderr] 448 | (Type::Int8, n @ 0...23) => Ok(-1 - n as i16), [INFO] [stderr] | ^^^^^^^^ help: try: `i16::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:320:50 [INFO] [stderr] | [INFO] [stderr] 320 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 449 | (Type::Int8, 24) => read_signed_byte!(self, u8, i16, i16), [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:322:29 [INFO] [stderr] | [INFO] [stderr] 322 | Ok(-1 - n as $to_type) [INFO] [stderr] | ^ help: try: `i16::from(n)` [INFO] [stderr] ... [INFO] [stderr] 449 | (Type::Int8, 24) => read_signed_byte!(self, u8, i16, i16), [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:335:50 [INFO] [stderr] | [INFO] [stderr] 335 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 450 | (Type::Int16, 25) => read_signed!(self, read_u16, u16, i16, i16), [INFO] [stderr] | ------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:349:50 [INFO] [stderr] | [INFO] [stderr] 349 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 451 | (Type::UInt8, _) => cast_unsigned!(self, u8, ti, u8, i16, i16), [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:351:24 [INFO] [stderr] | [INFO] [stderr] 351 | Ok(n as $to_type) [INFO] [stderr] | ^ help: try: `i16::from(n)` [INFO] [stderr] ... [INFO] [stderr] 451 | (Type::UInt8, _) => cast_unsigned!(self, u8, ti, u8, i16, i16), [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:349:50 [INFO] [stderr] | [INFO] [stderr] 349 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 452 | (Type::UInt16, _) => cast_unsigned!(self, u16, ti, u16, i16, i16), [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoder.rs:457:31 [INFO] [stderr] | [INFO] [stderr] 457 | pub fn i32(&mut self, ti: &TypeInfo) -> DecodeResult { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `TypeInfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:459:49 [INFO] [stderr] | [INFO] [stderr] 459 | (Type::Int8, n @ 0...23) => Ok(-1 - n as i32), [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:320:50 [INFO] [stderr] | [INFO] [stderr] 320 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 460 | (Type::Int8, 24) => read_signed_byte!(self, u8, i32, i32), [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:322:29 [INFO] [stderr] | [INFO] [stderr] 322 | Ok(-1 - n as $to_type) [INFO] [stderr] | ^ help: try: `i32::from(n)` [INFO] [stderr] ... [INFO] [stderr] 460 | (Type::Int8, 24) => read_signed_byte!(self, u8, i32, i32), [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:335:50 [INFO] [stderr] | [INFO] [stderr] 335 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 461 | (Type::Int16, 25) => read_signed!(self, read_u16, u16, i32, i32), [INFO] [stderr] | ------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:337:29 [INFO] [stderr] | [INFO] [stderr] 337 | Ok(-1 - n as $to_type) [INFO] [stderr] | ^ help: try: `i32::from(n)` [INFO] [stderr] ... [INFO] [stderr] 461 | (Type::Int16, 25) => read_signed!(self, read_u16, u16, i32, i32), [INFO] [stderr] | ------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:335:50 [INFO] [stderr] | [INFO] [stderr] 335 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 462 | (Type::Int32, 26) => read_signed!(self, read_u32, u32, i32, i32), [INFO] [stderr] | ------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:349:50 [INFO] [stderr] | [INFO] [stderr] 349 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 463 | (Type::UInt8, _) => cast_unsigned!(self, u8, ti, u8, i32, i32), [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:351:24 [INFO] [stderr] | [INFO] [stderr] 351 | Ok(n as $to_type) [INFO] [stderr] | ^ help: try: `i32::from(n)` [INFO] [stderr] ... [INFO] [stderr] 463 | (Type::UInt8, _) => cast_unsigned!(self, u8, ti, u8, i32, i32), [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:349:50 [INFO] [stderr] | [INFO] [stderr] 349 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 464 | (Type::UInt16, _) => cast_unsigned!(self, u16, ti, u16, i32, i32), [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:351:24 [INFO] [stderr] | [INFO] [stderr] 351 | Ok(n as $to_type) [INFO] [stderr] | ^ help: try: `i32::from(n)` [INFO] [stderr] ... [INFO] [stderr] 464 | (Type::UInt16, _) => cast_unsigned!(self, u16, ti, u16, i32, i32), [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:349:50 [INFO] [stderr] | [INFO] [stderr] 349 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 465 | (Type::UInt32, _) => cast_unsigned!(self, u32, ti, u32, i32, i32), [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoder.rs:470:31 [INFO] [stderr] | [INFO] [stderr] 470 | pub fn i64(&mut self, ti: &TypeInfo) -> DecodeResult { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `TypeInfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:472:49 [INFO] [stderr] | [INFO] [stderr] 472 | (Type::Int8, n @ 0...23) => Ok(-1 - n as i64), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:320:50 [INFO] [stderr] | [INFO] [stderr] 320 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 473 | (Type::Int8, 24) => read_signed_byte!(self, u8, i64, i64), [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:322:29 [INFO] [stderr] | [INFO] [stderr] 322 | Ok(-1 - n as $to_type) [INFO] [stderr] | ^ help: try: `i64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 473 | (Type::Int8, 24) => read_signed_byte!(self, u8, i64, i64), [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:335:50 [INFO] [stderr] | [INFO] [stderr] 335 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 474 | (Type::Int16, 25) => read_signed!(self, read_u16, u16, i64, i64), [INFO] [stderr] | ------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:337:29 [INFO] [stderr] | [INFO] [stderr] 337 | Ok(-1 - n as $to_type) [INFO] [stderr] | ^ help: try: `i64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 474 | (Type::Int16, 25) => read_signed!(self, read_u16, u16, i64, i64), [INFO] [stderr] | ------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:335:50 [INFO] [stderr] | [INFO] [stderr] 335 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 475 | (Type::Int32, 26) => read_signed!(self, read_u32, u32, i64, i64), [INFO] [stderr] | ------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:337:29 [INFO] [stderr] | [INFO] [stderr] 337 | Ok(-1 - n as $to_type) [INFO] [stderr] | ^ help: try: `i64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 475 | (Type::Int32, 26) => read_signed!(self, read_u32, u32, i64, i64), [INFO] [stderr] | ------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:349:50 [INFO] [stderr] | [INFO] [stderr] 349 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 477 | (Type::UInt8, _) => cast_unsigned!(self, u8, ti, u8, i64, i64), [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:351:24 [INFO] [stderr] | [INFO] [stderr] 351 | Ok(n as $to_type) [INFO] [stderr] | ^ help: try: `i64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 477 | (Type::UInt8, _) => cast_unsigned!(self, u8, ti, u8, i64, i64), [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:349:50 [INFO] [stderr] | [INFO] [stderr] 349 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 478 | (Type::UInt16, _) => cast_unsigned!(self, u16, ti, u16, i64, i64), [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:351:24 [INFO] [stderr] | [INFO] [stderr] 351 | Ok(n as $to_type) [INFO] [stderr] | ^ help: try: `i64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 478 | (Type::UInt16, _) => cast_unsigned!(self, u16, ti, u16, i64, i64), [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:349:50 [INFO] [stderr] | [INFO] [stderr] 349 | Err(DecodeError::IntOverflow(n as u64)) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 479 | (Type::UInt32, _) => cast_unsigned!(self, u32, ti, u32, i64, i64), [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:351:24 [INFO] [stderr] | [INFO] [stderr] 351 | Ok(n as $to_type) [INFO] [stderr] | ^ help: try: `i64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 479 | (Type::UInt32, _) => cast_unsigned!(self, u32, ti, u32, i64, i64), [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoder.rs:485:31 [INFO] [stderr] | [INFO] [stderr] 485 | pub fn int(&mut self, ti: &TypeInfo) -> DecodeResult { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `TypeInfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoder.rs:503:31 [INFO] [stderr] | [INFO] [stderr] 503 | pub fn f16(&mut self, ti: &TypeInfo) -> DecodeResult { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `TypeInfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:511:41 [INFO] [stderr] | [INFO] [stderr] 511 | 0 => ffi::c_ldexpf(mant as f32, -24), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(mant)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:513:41 [INFO] [stderr] | [INFO] [stderr] 513 | _ => ffi::c_ldexpf(mant as f32 + 1024.0, exp as isize - 25) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(mant)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoder.rs:521:31 [INFO] [stderr] | [INFO] [stderr] 521 | pub fn f32(&mut self, ti: &TypeInfo) -> DecodeResult { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `TypeInfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoder.rs:528:31 [INFO] [stderr] | [INFO] [stderr] 528 | pub fn f64(&mut self, ti: &TypeInfo) -> DecodeResult { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `TypeInfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:539:30 [INFO] [stderr] | [INFO] [stderr] 539 | n @ 0...23 => Ok(n as u64), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:540:49 [INFO] [stderr] | [INFO] [stderr] 540 | 24 => self.reader.read_u8().map(|n| n as u64).map_err(From::from), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:541:63 [INFO] [stderr] | [INFO] [stderr] 541 | 25 => self.reader.read_u16::().map(|n| n as u64).map_err(From::from), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:542:63 [INFO] [stderr] | [INFO] [stderr] 542 | 26 => self.reader.read_u32::().map(|n| n as u64).map_err(From::from), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoder.rs:626:27 [INFO] [stderr] | [INFO] [stderr] 626 | fn unexpected_type(ti: &TypeInfo) -> DecodeResult { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `TypeInfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: defining a method called `borrow_mut` on this type; consider implementing the `std::borrow::BorrowMut` trait or choosing a less ambiguous name [INFO] [stderr] --> src/decoder.rs:1054:5 [INFO] [stderr] | [INFO] [stderr] 1054 | / pub fn borrow_mut(&mut self) -> &mut Decoder { [INFO] [stderr] 1055 | | &mut self.decoder [INFO] [stderr] 1056 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:1079:32 [INFO] [stderr] | [INFO] [stderr] 1079 | if n > i8::MAX as i16 || n < i8::MIN as i16 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i16::from(i8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:1079:54 [INFO] [stderr] | [INFO] [stderr] 1079 | if n > i8::MAX as i16 || n < i8::MIN as i16 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i16::from(i8::MIN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:1088:32 [INFO] [stderr] | [INFO] [stderr] 1088 | if n > i16::MAX as i32 || n < i16::MIN as i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(i16::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:1088:55 [INFO] [stderr] | [INFO] [stderr] 1088 | if n > i16::MAX as i32 || n < i16::MIN as i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(i16::MIN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:1097:32 [INFO] [stderr] | [INFO] [stderr] 1097 | if n > i32::MAX as i64 || n < i32::MIN as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(i32::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:1097:55 [INFO] [stderr] | [INFO] [stderr] 1097 | if n > i32::MAX as i64 || n < i32::MIN as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(i32::MIN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:1254:44 [INFO] [stderr] | [INFO] [stderr] 1254 | Value::I8(x) => Ok(Key::i64(x as i64)), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:1255:44 [INFO] [stderr] | [INFO] [stderr] 1255 | Value::I16(x) => Ok(Key::i64(x as i64)), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:1256:44 [INFO] [stderr] | [INFO] [stderr] 1256 | Value::I32(x) => Ok(Key::i64(x as i64)), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:1258:44 [INFO] [stderr] | [INFO] [stderr] 1258 | Value::U8(x) => Ok(Key::u64(x as u64)), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:1259:44 [INFO] [stderr] | [INFO] [stderr] 1259 | Value::U16(x) => Ok(Key::u64(x as u64)), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:1260:44 [INFO] [stderr] | [INFO] [stderr] 1260 | Value::U32(x) => Ok(Key::u64(x as u64)), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/decoder.rs:1359:25 [INFO] [stderr] | [INFO] [stderr] 1359 | assert_eq!(Some(3.4028234663852886e+38), decoder("fa7f7fffff").f32().ok()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `3.402_823_5e38` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/encoder.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | let ref mut w = self.writer; [INFO] [stderr] | ----^^^^^^^^^--------------- help: try: `let w = &mut self.writer;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/encoder.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | let ref mut w = self.writer; [INFO] [stderr] | ----^^^^^^^^^--------------- help: try: `let w = &mut self.writer;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/encoder.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | let ref mut w = self.writer; [INFO] [stderr] | ----^^^^^^^^^--------------- help: try: `let w = &mut self.writer;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/encoder.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | let ref mut w = self.writer; [INFO] [stderr] | ----^^^^^^^^^--------------- help: try: `let w = &mut self.writer;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/encoder.rs:195:17 [INFO] [stderr] | [INFO] [stderr] 195 | let ref mut w = self.writer; [INFO] [stderr] | ----^^^^^^^^^--------------- help: try: `let w = &mut self.writer;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/encoder.rs:207:17 [INFO] [stderr] | [INFO] [stderr] 207 | let ref mut w = self.writer; [INFO] [stderr] | ----^^^^^^^^^--------------- help: try: `let w = &mut self.writer;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/encoder.rs:220:17 [INFO] [stderr] | [INFO] [stderr] 220 | let ref mut w = self.writer; [INFO] [stderr] | ----^^^^^^^^^--------------- help: try: `let w = &mut self.writer;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/encoder.rs:234:17 [INFO] [stderr] | [INFO] [stderr] 234 | let ref mut w = self.writer; [INFO] [stderr] | ----^^^^^^^^^--------------- help: try: `let w = &mut self.writer;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/encoder.rs:249:21 [INFO] [stderr] | [INFO] [stderr] 249 | let ref mut w = self.writer; [INFO] [stderr] | ----^^^^^^^^^--------------- help: try: `let w = &mut self.writer;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/encoder.rs:278:13 [INFO] [stderr] | [INFO] [stderr] 278 | let ref mut w = self.writer; [INFO] [stderr] | ----^^^^^^^^^--------------- help: try: `let w = &mut self.writer;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/encoder.rs:361:13 [INFO] [stderr] | [INFO] [stderr] 361 | let ref mut w = self.writer; [INFO] [stderr] | ----^^^^^^^^^--------------- help: try: `let w = &mut self.writer;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: defining a method called `borrow_mut` on this type; consider implementing the `std::borrow::BorrowMut` trait or choosing a less ambiguous name [INFO] [stderr] --> src/encoder.rs:392:5 [INFO] [stderr] | [INFO] [stderr] 392 | / pub fn borrow_mut(&mut self) -> &mut Encoder { [INFO] [stderr] 393 | | &mut self.encoder [INFO] [stderr] 394 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/encoder.rs:504:45 [INFO] [stderr] | [INFO] [stderr] 504 | encoded("fa7f7fffff", |mut e| e.f32(3.4028234663852886e+38)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `3.402_823_5e38` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/encoder.rs:539:31 [INFO] [stderr] | [INFO] [stderr] 539 | e.bytes_iter(vec!["strea".as_bytes(), "ming".as_bytes()].into_iter()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"strea"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/encoder.rs:539:51 [INFO] [stderr] | [INFO] [stderr] 539 | e.bytes_iter(vec!["strea".as_bytes(), "ming".as_bytes()].into_iter()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"ming"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "8e26a8d0fdbfb1650fa4db0be67f96100dc410e514962db1de015dff18db2d1c"` [INFO] running `"docker" "rm" "-f" "8e26a8d0fdbfb1650fa4db0be67f96100dc410e514962db1de015dff18db2d1c"` [INFO] [stdout] 8e26a8d0fdbfb1650fa4db0be67f96100dc410e514962db1de015dff18db2d1c