[INFO] crate cbitset 0.1.0 is already in cache [INFO] extracting crate cbitset 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/cbitset/0.1.0 [INFO] extracting crate cbitset 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cbitset/0.1.0 [INFO] validating manifest of cbitset-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cbitset-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cbitset-0.1.0 [INFO] finished frobbing cbitset-0.1.0 [INFO] frobbed toml for cbitset-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/cbitset/0.1.0/Cargo.toml [INFO] started frobbing cbitset-0.1.0 [INFO] finished frobbing cbitset-0.1.0 [INFO] frobbed toml for cbitset-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cbitset/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cbitset-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cbitset/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c7912e56d7ec2d9f4f17f4433589e8815ac6130bd06ca5b8fb36280d31e891a1 [INFO] running `"docker" "start" "-a" "c7912e56d7ec2d9f4f17f4433589e8815ac6130bd06ca5b8fb36280d31e891a1"` [INFO] [stderr] Checking cbitset v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:129:54 [INFO] [stderr] | [INFO] [stderr] 129 | self.inner.get(index) | Self::from(1 << (bit & Self::item_size() - 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `bit & (Self::item_size() - 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:145:56 [INFO] [stderr] | [INFO] [stderr] 145 | self.inner.get(index) & Self::from(!(1 << (bit & Self::item_size() - 1))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `bit & (Self::item_size() - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:159:37 [INFO] [stderr] | [INFO] [stderr] 159 | let mask = Self::from(1 << (bit & Self::item_size() - 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `bit & (Self::item_size() - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/lib.rs:199:25 [INFO] [stderr] | [INFO] [stderr] 199 | assert!(i + 1 <= Self::capacity(), "start bound is too big for capacity"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::int_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 199 | assert!(i < Self::capacity(), "start bound is too big for capacity"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:91:18 [INFO] [stderr] | [INFO] [stderr] 91 | unsafe { mem::transmute(inner) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(inner as *mut T as *mut BitSet)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:129:54 [INFO] [stderr] | [INFO] [stderr] 129 | self.inner.get(index) | Self::from(1 << (bit & Self::item_size() - 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `bit & (Self::item_size() - 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:145:56 [INFO] [stderr] | [INFO] [stderr] 145 | self.inner.get(index) & Self::from(!(1 << (bit & Self::item_size() - 1))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `bit & (Self::item_size() - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:159:37 [INFO] [stderr] | [INFO] [stderr] 159 | let mask = Self::from(1 << (bit & Self::item_size() - 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `bit & (Self::item_size() - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/lib.rs:199:25 [INFO] [stderr] | [INFO] [stderr] 199 | assert!(i + 1 <= Self::capacity(), "start bound is too big for capacity"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::int_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 199 | assert!(i < Self::capacity(), "start bound is too big for capacity"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:91:18 [INFO] [stderr] | [INFO] [stderr] 91 | unsafe { mem::transmute(inner) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(inner as *mut T as *mut BitSet)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.18s [INFO] running `"docker" "inspect" "c7912e56d7ec2d9f4f17f4433589e8815ac6130bd06ca5b8fb36280d31e891a1"` [INFO] running `"docker" "rm" "-f" "c7912e56d7ec2d9f4f17f4433589e8815ac6130bd06ca5b8fb36280d31e891a1"` [INFO] [stdout] c7912e56d7ec2d9f4f17f4433589e8815ac6130bd06ca5b8fb36280d31e891a1