[INFO] crate cavity 1.1.0 is already in cache [INFO] extracting crate cavity 1.1.0 into work/ex/clippy-test-run/sources/stable/reg/cavity/1.1.0 [INFO] extracting crate cavity 1.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cavity/1.1.0 [INFO] validating manifest of cavity-1.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cavity-1.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cavity-1.1.0 [INFO] finished frobbing cavity-1.1.0 [INFO] frobbed toml for cavity-1.1.0 written to work/ex/clippy-test-run/sources/stable/reg/cavity/1.1.0/Cargo.toml [INFO] started frobbing cavity-1.1.0 [INFO] finished frobbing cavity-1.1.0 [INFO] frobbed toml for cavity-1.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cavity/1.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cavity-1.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cavity/1.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 03a37a0fc38803d098e1b615e162923bb04f5eccd1ba8578c10be063ad0ed597 [INFO] running `"docker" "start" "-a" "03a37a0fc38803d098e1b615e162923bb04f5eccd1ba8578c10be063ad0ed597"` [INFO] [stderr] Checking cavity v1.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | / return match *self { [INFO] [stderr] 51 | | Bytes::KiloBytes(e) => e * 1024, [INFO] [stderr] 52 | | Bytes::MegaBytes(e) => e * 1024 * 1024, [INFO] [stderr] 53 | | Bytes::GigaBytes(e) => e * 1024 * 1024 * 1024, [INFO] [stderr] 54 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 50 | match *self { [INFO] [stderr] 51 | Bytes::KiloBytes(e) => e * 1024, [INFO] [stderr] 52 | Bytes::MegaBytes(e) => e * 1024 * 1024, [INFO] [stderr] 53 | Bytes::GigaBytes(e) => e * 1024 * 1024 * 1024, [INFO] [stderr] 54 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | / return match *self { [INFO] [stderr] 51 | | Bytes::KiloBytes(e) => e * 1024, [INFO] [stderr] 52 | | Bytes::MegaBytes(e) => e * 1024 * 1024, [INFO] [stderr] 53 | | Bytes::GigaBytes(e) => e * 1024 * 1024 * 1024, [INFO] [stderr] 54 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 50 | match *self { [INFO] [stderr] 51 | Bytes::KiloBytes(e) => e * 1024, [INFO] [stderr] 52 | Bytes::MegaBytes(e) => e * 1024 * 1024, [INFO] [stderr] 53 | Bytes::GigaBytes(e) => e * 1024 * 1024 * 1024, [INFO] [stderr] 54 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:97:32 [INFO] [stderr] | [INFO] [stderr] 97 | let buf_size = buffer_size.unwrap_or(Bytes::KiloBytes(BUF_SIZE_KB)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Bytes::KiloBytes(BUF_SIZE_KB))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:97:32 [INFO] [stderr] | [INFO] [stderr] 97 | let buf_size = buffer_size.unwrap_or(Bytes::KiloBytes(BUF_SIZE_KB)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Bytes::KiloBytes(BUF_SIZE_KB))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.65s [INFO] running `"docker" "inspect" "03a37a0fc38803d098e1b615e162923bb04f5eccd1ba8578c10be063ad0ed597"` [INFO] running `"docker" "rm" "-f" "03a37a0fc38803d098e1b615e162923bb04f5eccd1ba8578c10be063ad0ed597"` [INFO] [stdout] 03a37a0fc38803d098e1b615e162923bb04f5eccd1ba8578c10be063ad0ed597