[INFO] crate catalog 0.1.2 is already in cache [INFO] extracting crate catalog 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/catalog/0.1.2 [INFO] extracting crate catalog 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/catalog/0.1.2 [INFO] validating manifest of catalog-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of catalog-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing catalog-0.1.2 [INFO] finished frobbing catalog-0.1.2 [INFO] frobbed toml for catalog-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/catalog/0.1.2/Cargo.toml [INFO] started frobbing catalog-0.1.2 [INFO] finished frobbing catalog-0.1.2 [INFO] frobbed toml for catalog-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/catalog/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting catalog-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/catalog/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 811203a88e6923179bac59f4882ff345326dbb133b6c19b73e015d952260bee5 [INFO] running `"docker" "start" "-a" "811203a88e6923179bac59f4882ff345326dbb133b6c19b73e015d952260bee5"` [INFO] [stderr] Checking catalog v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hash_file.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hash_file.rs:282:13 [INFO] [stderr] | [INFO] [stderr] 282 | data_path: data_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hash_file.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hash_file.rs:282:13 [INFO] [stderr] | [INFO] [stderr] 282 | data_path: data_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/hash_file.rs:17:21 [INFO] [stderr] | [INFO] [stderr] 17 | const TEMP_SUFFIX: &'static str = ".hash_file"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/hash_file.rs:18:20 [INFO] [stderr] | [INFO] [stderr] 18 | const DAT_SUFFIX: &'static str = ".dat"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/hash_file.rs:17:21 [INFO] [stderr] | [INFO] [stderr] 17 | const TEMP_SUFFIX: &'static str = ".hash_file"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/hash_file.rs:18:20 [INFO] [stderr] | [INFO] [stderr] 18 | const DAT_SUFFIX: &'static str = ".dat"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/hash_file.rs:52:48 [INFO] [stderr] | [INFO] [stderr] 52 | .map_err(|_| format!("Cannot parse the key!"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Cannot parse the key!".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/hash_file.rs:55:48 [INFO] [stderr] | [INFO] [stderr] 55 | .map_err(|_| format!("Cannot parse the index!"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Cannot parse the index!".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/hash_file.rs:58:50 [INFO] [stderr] | [INFO] [stderr] 58 | .map_err(|_| format!("Cannot parse 'overwritten' count"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Cannot parse 'overwritten' count".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/hash_file.rs:52:48 [INFO] [stderr] | [INFO] [stderr] 52 | .map_err(|_| format!("Cannot parse the key!"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Cannot parse the key!".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/hash_file.rs:55:48 [INFO] [stderr] | [INFO] [stderr] 55 | .map_err(|_| format!("Cannot parse the index!"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Cannot parse the index!".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/hash_file.rs:270:26 [INFO] [stderr] | [INFO] [stderr] 270 | line_length: match file_size > 0 { [INFO] [stderr] | __________________________^ [INFO] [stderr] 271 | | true => { [INFO] [stderr] 272 | | let line = try!(read_one_line(&mut file)); [INFO] [stderr] 273 | | line.len() [INFO] [stderr] 274 | | }, [INFO] [stderr] 275 | | false => 0, [INFO] [stderr] 276 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 270 | line_length: if file_size > 0 { [INFO] [stderr] 271 | let line = try!(read_one_line(&mut file)); [INFO] [stderr] 272 | line.len() [INFO] [stderr] 273 | } else { 0 }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/hash_file.rs:58:50 [INFO] [stderr] | [INFO] [stderr] 58 | .map_err(|_| format!("Cannot parse 'overwritten' count"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Cannot parse 'overwritten' count".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/hash_file.rs:270:26 [INFO] [stderr] | [INFO] [stderr] 270 | line_length: match file_size > 0 { [INFO] [stderr] | __________________________^ [INFO] [stderr] 271 | | true => { [INFO] [stderr] 272 | | let line = try!(read_one_line(&mut file)); [INFO] [stderr] 273 | | line.len() [INFO] [stderr] 274 | | }, [INFO] [stderr] 275 | | false => 0, [INFO] [stderr] 276 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 270 | line_length: if file_size > 0 { [INFO] [stderr] 271 | let line = try!(read_one_line(&mut file)); [INFO] [stderr] 272 | line.len() [INFO] [stderr] 273 | } else { 0 }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/hash_file.rs:333:12 [INFO] [stderr] | [INFO] [stderr] 333 | if self.hashed.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.hashed.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/hash_file.rs:348:17 [INFO] [stderr] | [INFO] [stderr] 348 | for ref line in buf_reader.lines().filter_map(|l| l.ok()) { [INFO] [stderr] | ^^^^^^^^ ----------------------------------------- help: try: `let line = &buf_reader.lines().filter_map(|l| l.ok());` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/hash_file.rs:333:12 [INFO] [stderr] | [INFO] [stderr] 333 | if self.hashed.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.hashed.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/hash_file.rs:348:17 [INFO] [stderr] | [INFO] [stderr] 348 | for ref line in buf_reader.lines().filter_map(|l| l.ok()) { [INFO] [stderr] | ^^^^^^^^ ----------------------------------------- help: try: `let line = &buf_reader.lines().filter_map(|l| l.ok());` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/hash_file.rs:507:48 [INFO] [stderr] | [INFO] [stderr] 507 | .map_err(|_| format!("Cannot parse the key from file!"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Cannot parse the key from file!".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/hash_file.rs:507:48 [INFO] [stderr] | [INFO] [stderr] 507 | .map_err(|_| format!("Cannot parse the key from file!"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Cannot parse the key from file!".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/hash_file.rs:515:51 [INFO] [stderr] | [INFO] [stderr] 515 | .map_err(|_| format!("Cannot parse the value from file!"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Cannot parse the value from file!".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/hash_file.rs:515:51 [INFO] [stderr] | [INFO] [stderr] 515 | .map_err(|_| format!("Cannot parse the value from file!"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Cannot parse the value from file!".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.06s [INFO] running `"docker" "inspect" "811203a88e6923179bac59f4882ff345326dbb133b6c19b73e015d952260bee5"` [INFO] running `"docker" "rm" "-f" "811203a88e6923179bac59f4882ff345326dbb133b6c19b73e015d952260bee5"` [INFO] [stdout] 811203a88e6923179bac59f4882ff345326dbb133b6c19b73e015d952260bee5