[INFO] crate castor 0.3.1 is already in cache [INFO] extracting crate castor 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/castor/0.3.1 [INFO] extracting crate castor 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/castor/0.3.1 [INFO] validating manifest of castor-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of castor-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing castor-0.3.1 [INFO] finished frobbing castor-0.3.1 [INFO] frobbed toml for castor-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/castor/0.3.1/Cargo.toml [INFO] started frobbing castor-0.3.1 [INFO] finished frobbing castor-0.3.1 [INFO] frobbed toml for castor-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/castor/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting castor-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/castor/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9d979389066568e44fa22f6627ff29a51c9d15e4a5597fd73036cdef705980a1 [INFO] running `"docker" "start" "-a" "9d979389066568e44fa22f6627ff29a51c9d15e4a5597fd73036cdef705980a1"` [INFO] [stderr] Checking kv v0.6.1 [INFO] [stderr] Checking castor v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/token.rs:19:20 [INFO] [stderr] | [INFO] [stderr] 19 | Token::new(String::from(format!("{:x}", hash))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{:x}", hash)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/store.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn read_txn<'a>(&'a self) -> Result, kv::Error> { [INFO] [stderr] 24 | | Ok(Txn(self.0.read_txn()?)) [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/store.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn write_txn<'a>(&'a mut self) -> Result, kv::Error> { [INFO] [stderr] 29 | | Ok(Txn(self.0.write_txn()?)) [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/token.rs:19:20 [INFO] [stderr] | [INFO] [stderr] 19 | Token::new(String::from(format!("{:x}", hash))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{:x}", hash)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/store.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn read_txn<'a>(&'a self) -> Result, kv::Error> { [INFO] [stderr] 24 | | Ok(Txn(self.0.read_txn()?)) [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/store.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn write_txn<'a>(&'a mut self) -> Result, kv::Error> { [INFO] [stderr] 29 | | Ok(Txn(self.0.write_txn()?)) [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.66s [INFO] running `"docker" "inspect" "9d979389066568e44fa22f6627ff29a51c9d15e4a5597fd73036cdef705980a1"` [INFO] running `"docker" "rm" "-f" "9d979389066568e44fa22f6627ff29a51c9d15e4a5597fd73036cdef705980a1"` [INFO] [stdout] 9d979389066568e44fa22f6627ff29a51c9d15e4a5597fd73036cdef705980a1