[INFO] crate casimir-fdfd 0.2.0 is already in cache [INFO] extracting crate casimir-fdfd 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/casimir-fdfd/0.2.0 [INFO] extracting crate casimir-fdfd 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/casimir-fdfd/0.2.0 [INFO] validating manifest of casimir-fdfd-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of casimir-fdfd-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing casimir-fdfd-0.2.0 [INFO] finished frobbing casimir-fdfd-0.2.0 [INFO] frobbed toml for casimir-fdfd-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/casimir-fdfd/0.2.0/Cargo.toml [INFO] started frobbing casimir-fdfd-0.2.0 [INFO] finished frobbing casimir-fdfd-0.2.0 [INFO] frobbed toml for casimir-fdfd-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/casimir-fdfd/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting casimir-fdfd-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/casimir-fdfd/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] be98bd849b132a9d8f0931adc4e499ce118aa0cf487bd392997a42822420c8ec [INFO] running `"docker" "start" "-a" "be98bd849b132a9d8f0931adc4e499ce118aa0cf487bd392997a42822420c8ec"` [INFO] [stderr] Compiling num-complex v0.2.1 [INFO] [stderr] Checking assert_approx_eq v1.1.0 [INFO] [stderr] Checking approx v0.2.1 [INFO] [stderr] Checking alga v0.6.0 [INFO] [stderr] Checking nalgebra v0.15.3 [INFO] [stderr] Checking casimir-fdfd v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/world/material.rs:159:51 [INFO] [stderr] | [INFO] [stderr] 159 | assert_approx_eq!(gold.permittivity(0.1), 17.364246, 1e-10); [INFO] [stderr] | ^^^^^^^^^ help: consider: `17.364_246` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/world/material.rs:160:51 [INFO] [stderr] | [INFO] [stderr] 160 | assert_approx_eq!(gold.permittivity(0.2), 8.131477, 1e-10); [INFO] [stderr] | ^^^^^^^^ help: consider: `8.131_477` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/world/material.rs:161:51 [INFO] [stderr] | [INFO] [stderr] 161 | assert_approx_eq!(gold.permittivity(0.3), 5.509191, 1e-10); [INFO] [stderr] | ^^^^^^^^ help: consider: `5.509_191` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/world/material.rs:162:51 [INFO] [stderr] | [INFO] [stderr] 162 | assert_approx_eq!(gold.permittivity(0.4), 4.2805657, 1e-10); [INFO] [stderr] | ^^^^^^^^^ help: consider: `4.280_565_7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/world/material.rs:163:51 [INFO] [stderr] | [INFO] [stderr] 163 | assert_approx_eq!(gold.permittivity(0.5), 3.5698092, 1e-10); [INFO] [stderr] | ^^^^^^^^^ help: consider: `3.569_809_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/world/material.rs:174:51 [INFO] [stderr] | [INFO] [stderr] 174 | assert_approx_eq!(gold.permittivity(0.1), 4.930006, 0.001); [INFO] [stderr] | ^^^^^^^^ help: consider: `4.930_006` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/world/material.rs:175:51 [INFO] [stderr] | [INFO] [stderr] 175 | assert_approx_eq!(gold.permittivity(0.2), 2.7026372, 0.001); [INFO] [stderr] | ^^^^^^^^^ help: consider: `2.702_637_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/world/material.rs:176:51 [INFO] [stderr] | [INFO] [stderr] 176 | assert_approx_eq!(gold.permittivity(0.3), 2.0700483, 0.001); [INFO] [stderr] | ^^^^^^^^^ help: consider: `2.070_048_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/world/material.rs:177:51 [INFO] [stderr] | [INFO] [stderr] 177 | assert_approx_eq!(gold.permittivity(0.4), 1.7736864, 0.001); [INFO] [stderr] | ^^^^^^^^^ help: consider: `1.773_686_4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/world/material.rs:178:51 [INFO] [stderr] | [INFO] [stderr] 178 | assert_approx_eq!(gold.permittivity(0.5), 1.6022651, 0.001); [INFO] [stderr] | ^^^^^^^^^ help: consider: `1.602_265_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: item `fields::scalarfield::ScalarField` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/fields/scalarfield.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | / impl ScalarField { [INFO] [stderr] 12 | | /// Constructs a new `ScalarField` filled with the value 1. [INFO] [stderr] 13 | | pub fn ones(size: Vector3) -> ScalarField { [INFO] [stderr] 14 | | ScalarField { [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `fields::scaledvectorfield::ScaledVectorField<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/fields/scaledvectorfield.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / impl<'a> ScaledVectorField<'a> { [INFO] [stderr] 14 | | /// Get the size of this field. [INFO] [stderr] 15 | | pub fn size(&self) -> Vector3 { [INFO] [stderr] 16 | | self.field.size() [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `AddAssign` impl [INFO] [stderr] --> src/fields/scaledvectorfield.rs:54:43 [INFO] [stderr] | [INFO] [stderr] 54 | *self_element += other.scalar * other_element [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_op_assign_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `SubAssign` impl [INFO] [stderr] --> src/fields/scaledvectorfield.rs:66:43 [INFO] [stderr] | [INFO] [stderr] 66 | *self_element -= other.scalar * other_element [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] warning: item `fields::vectorfield::VectorField` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/fields/vectorfield.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / impl VectorField { [INFO] [stderr] 14 | | /// Create a new `VectorField` filled with (0, 0, 0) with a certain `size`. [INFO] [stderr] 15 | | pub fn new(size: Vector3) -> VectorField { [INFO] [stderr] 16 | | VectorField { [INFO] [stderr] ... | [INFO] [stderr] 139 | | } [INFO] [stderr] 140 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/greenfunctions/operator.rs:61:27 [INFO] [stderr] | [INFO] [stderr] 61 | curl_part + &scalar_part [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/greenfunctions/operator.rs:64:52 [INFO] [stderr] | [INFO] [stderr] 64 | let curl_part = (x.curl_positive() / self.permitivity).curl_negative(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/greenfunctions/operator.rs:66:27 [INFO] [stderr] | [INFO] [stderr] 66 | curl_part + &scalar_part [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/world/mod.rs:302:38 [INFO] [stderr] | [INFO] [stderr] 302 | }).with_progress_bar(progress_bar.clone().map(|a| a.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `progress_bar.clone().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `casimir-fdfd`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: item `fields::scalarfield::ScalarField` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/fields/scalarfield.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | / impl ScalarField { [INFO] [stderr] 12 | | /// Constructs a new `ScalarField` filled with the value 1. [INFO] [stderr] 13 | | pub fn ones(size: Vector3) -> ScalarField { [INFO] [stderr] 14 | | ScalarField { [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `fields::scaledvectorfield::ScaledVectorField<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/fields/scaledvectorfield.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / impl<'a> ScaledVectorField<'a> { [INFO] [stderr] 14 | | /// Get the size of this field. [INFO] [stderr] 15 | | pub fn size(&self) -> Vector3 { [INFO] [stderr] 16 | | self.field.size() [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `AddAssign` impl [INFO] [stderr] --> src/fields/scaledvectorfield.rs:54:43 [INFO] [stderr] | [INFO] [stderr] 54 | *self_element += other.scalar * other_element [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_op_assign_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `SubAssign` impl [INFO] [stderr] --> src/fields/scaledvectorfield.rs:66:43 [INFO] [stderr] | [INFO] [stderr] 66 | *self_element -= other.scalar * other_element [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] warning: item `fields::vectorfield::VectorField` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/fields/vectorfield.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / impl VectorField { [INFO] [stderr] 14 | | /// Create a new `VectorField` filled with (0, 0, 0) with a certain `size`. [INFO] [stderr] 15 | | pub fn new(size: Vector3) -> VectorField { [INFO] [stderr] 16 | | VectorField { [INFO] [stderr] ... | [INFO] [stderr] 139 | | } [INFO] [stderr] 140 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/greenfunctions/operator.rs:61:27 [INFO] [stderr] | [INFO] [stderr] 61 | curl_part + &scalar_part [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/greenfunctions/operator.rs:64:52 [INFO] [stderr] | [INFO] [stderr] 64 | let curl_part = (x.curl_positive() / self.permitivity).curl_negative(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/greenfunctions/operator.rs:66:27 [INFO] [stderr] | [INFO] [stderr] 66 | curl_part + &scalar_part [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/world/mod.rs:302:38 [INFO] [stderr] | [INFO] [stderr] 302 | }).with_progress_bar(progress_bar.clone().map(|a| a.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `progress_bar.clone().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `casimir-fdfd`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "be98bd849b132a9d8f0931adc4e499ce118aa0cf487bd392997a42822420c8ec"` [INFO] running `"docker" "rm" "-f" "be98bd849b132a9d8f0931adc4e499ce118aa0cf487bd392997a42822420c8ec"` [INFO] [stdout] be98bd849b132a9d8f0931adc4e499ce118aa0cf487bd392997a42822420c8ec