[INFO] crate cargo2 0.2.2 is already in cache
[INFO] extracting crate cargo2 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/cargo2/0.2.2
[INFO] extracting crate cargo2 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo2/0.2.2
[INFO] validating manifest of cargo2-0.2.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of cargo2-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing cargo2-0.2.2
[INFO] finished frobbing cargo2-0.2.2
[INFO] frobbed toml for cargo2-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/cargo2/0.2.2/Cargo.toml
[INFO] started frobbing cargo2-0.2.2
[INFO] finished frobbing cargo2-0.2.2
[INFO] frobbed toml for cargo2-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo2/0.2.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting cargo2-0.2.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cargo2/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 15e221892f442b2aeeaebd306403a729da50e604b04b89cbcaed9e33988b5a9b
[INFO] running `"docker" "start" "-a" "15e221892f442b2aeeaebd306403a729da50e604b04b89cbcaed9e33988b5a9b"`
[INFO] [stderr] warning: only one of `license` or `license-file` is necessary
[INFO] [stderr]     Checking cargo2 v0.2.2 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/license.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 |     return parts;
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `parts`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `serde`
[INFO] [stderr]  --> src/metadata.rs:1:5
[INFO] [stderr]   |
[INFO] [stderr] 1 | use serde;
[INFO] [stderr]   |     ^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/metadata.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 |     return metadata;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `metadata`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/license.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 |     return parts;
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `parts`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `serde`
[INFO] [stderr]  --> src/metadata.rs:1:5
[INFO] [stderr]   |
[INFO] [stderr] 1 | use serde;
[INFO] [stderr]   |     ^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/metadata.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 |     return metadata;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `metadata`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `entry`
[INFO] [stderr]   --> src/license.rs:28:13
[INFO] [stderr]    |
[INFO] [stderr] 28 |         let entry = license_map
[INFO] [stderr]    |             ^^^^^ help: consider using `_entry` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `m`
[INFO] [stderr]   --> src/main.rs:31:25
[INFO] [stderr]    |
[INFO] [stderr] 31 |         ("bundle", Some(m)) => {}
[INFO] [stderr]    |                         ^ help: consider using `_m` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `m`
[INFO] [stderr]   --> src/main.rs:32:24
[INFO] [stderr]    |
[INFO] [stderr] 32 |         ("check", Some(m)) => {}
[INFO] [stderr]    |                        ^ help: consider using `_m` instead
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/license.rs:14:9
[INFO] [stderr]    |
[INFO] [stderr] 14 |     let mut parts = split_license(license);
[INFO] [stderr]    |         ----^^^^^
[INFO] [stderr]    |         |
[INFO] [stderr]    |         help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `check_licenses`
[INFO] [stderr]   --> src/license.rs:38:1
[INFO] [stderr]    |
[INFO] [stderr] 38 | pub fn check_licenses() {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `bundle_licenses`
[INFO] [stderr]   --> src/license.rs:41:1
[INFO] [stderr]    |
[INFO] [stderr] 41 | pub fn bundle_licenses() {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `split_multiple`
[INFO] [stderr]  --> src/util.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub fn split_multiple() {}
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/license.rs:4:31
[INFO] [stderr]   |
[INFO] [stderr] 4 | pub fn split_license(license: &String) -> Vec<String> {
[INFO] [stderr]   |                               ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]  --> src/license.rs:7:31
[INFO] [stderr]   |
[INFO] [stderr] 7 |         .flat_map(|s| s.split("/").map(|s| s.to_string()))
[INFO] [stderr]   |                               ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/license.rs:13:35
[INFO] [stderr]    |
[INFO] [stderr] 13 | pub fn normalize_license(license: &String) -> String {
[INFO] [stderr]    |                                   ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/license.rs:31:14
[INFO] [stderr]    |
[INFO] [stderr] 31 |             .or_insert(vec![pkg.name.clone()]);
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![pkg.name.clone()])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `entry`
[INFO] [stderr]   --> src/license.rs:28:13
[INFO] [stderr]    |
[INFO] [stderr] 28 |         let entry = license_map
[INFO] [stderr]    |             ^^^^^ help: consider using `_entry` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `m`
[INFO] [stderr]   --> src/main.rs:31:25
[INFO] [stderr]    |
[INFO] [stderr] 31 |         ("bundle", Some(m)) => {}
[INFO] [stderr]    |                         ^ help: consider using `_m` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `m`
[INFO] [stderr]   --> src/main.rs:32:24
[INFO] [stderr]    |
[INFO] [stderr] 32 |         ("check", Some(m)) => {}
[INFO] [stderr]    |                        ^ help: consider using `_m` instead
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/license.rs:14:9
[INFO] [stderr]    |
[INFO] [stderr] 14 |     let mut parts = split_license(license);
[INFO] [stderr]    |         ----^^^^^
[INFO] [stderr]    |         |
[INFO] [stderr]    |         help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `check_licenses`
[INFO] [stderr]   --> src/license.rs:38:1
[INFO] [stderr]    |
[INFO] [stderr] 38 | pub fn check_licenses() {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `bundle_licenses`
[INFO] [stderr]   --> src/license.rs:41:1
[INFO] [stderr]    |
[INFO] [stderr] 41 | pub fn bundle_licenses() {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `split_multiple`
[INFO] [stderr]  --> src/util.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub fn split_multiple() {}
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/license.rs:4:31
[INFO] [stderr]   |
[INFO] [stderr] 4 | pub fn split_license(license: &String) -> Vec<String> {
[INFO] [stderr]   |                               ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]  --> src/license.rs:7:31
[INFO] [stderr]   |
[INFO] [stderr] 7 |         .flat_map(|s| s.split("/").map(|s| s.to_string()))
[INFO] [stderr]   |                               ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/license.rs:13:35
[INFO] [stderr]    |
[INFO] [stderr] 13 | pub fn normalize_license(license: &String) -> String {
[INFO] [stderr]    |                                   ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/license.rs:31:14
[INFO] [stderr]    |
[INFO] [stderr] 31 |             .or_insert(vec![pkg.name.clone()]);
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![pkg.name.clone()])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.70s
[INFO] running `"docker" "inspect" "15e221892f442b2aeeaebd306403a729da50e604b04b89cbcaed9e33988b5a9b"`
[INFO] running `"docker" "rm" "-f" "15e221892f442b2aeeaebd306403a729da50e604b04b89cbcaed9e33988b5a9b"`
[INFO] [stdout] 15e221892f442b2aeeaebd306403a729da50e604b04b89cbcaed9e33988b5a9b