[INFO] crate cargo-xbuild 0.5.0 is already in cache [INFO] extracting crate cargo-xbuild 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/cargo-xbuild/0.5.0 [INFO] extracting crate cargo-xbuild 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-xbuild/0.5.0 [INFO] validating manifest of cargo-xbuild-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cargo-xbuild-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cargo-xbuild-0.5.0 [INFO] finished frobbing cargo-xbuild-0.5.0 [INFO] frobbed toml for cargo-xbuild-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/cargo-xbuild/0.5.0/Cargo.toml [INFO] started frobbing cargo-xbuild-0.5.0 [INFO] finished frobbing cargo-xbuild-0.5.0 [INFO] frobbed toml for cargo-xbuild-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-xbuild/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cargo-xbuild-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cargo-xbuild/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7b24771b38f39eecd5fac98b47091979289a54f734069792817a904339eb79c9 [INFO] running `"docker" "start" "-a" "7b24771b38f39eecd5fac98b47091979289a54f734069792817a904339eb79c9"` [INFO] [stderr] Compiling cargo-xbuild v0.5.0 (/opt/crater/workdir) [INFO] [stderr] Checking rustc_version v0.1.7 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking cargo_metadata v0.5.8 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | all: all, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `all` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | target: target, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flock.rs:56:22 [INFO] [stderr] | [INFO] [stderr] 56 | Filesystem { path: path } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flock.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustc.rs:122:39 [INFO] [stderr] | [INFO] [stderr] 122 | Ok(Some(Target::Builtin { triple: triple })) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `triple` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustc.rs:144:21 [INFO] [stderr] | [INFO] [stderr] 144 | json: json, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `json` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustc.rs:156:29 [INFO] [stderr] | [INFO] [stderr] 156 | json: json, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `json` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | all: all, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `all` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | target: target, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flock.rs:56:22 [INFO] [stderr] | [INFO] [stderr] 56 | Filesystem { path: path } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flock.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustc.rs:122:39 [INFO] [stderr] | [INFO] [stderr] 122 | Ok(Some(Target::Builtin { triple: triple })) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `triple` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustc.rs:144:21 [INFO] [stderr] | [INFO] [stderr] 144 | json: json, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `json` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustc.rs:156:29 [INFO] [stderr] | [INFO] [stderr] 156 | json: json, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `json` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/rustc.rs:148:20 [INFO] [stderr] | [INFO] [stderr] 148 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 149 | | if let Some(p) = env::var_os("RUST_TARGET_PATH") { [INFO] [stderr] 150 | | let mut json = PathBuf::from(p); [INFO] [stderr] 151 | | json.push(&triple); [INFO] [stderr] ... | [INFO] [stderr] 161 | | } [INFO] [stderr] 162 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 148 | } else if let Some(p) = env::var_os("RUST_TARGET_PATH") { [INFO] [stderr] 149 | let mut json = PathBuf::from(p); [INFO] [stderr] 150 | json.push(&triple); [INFO] [stderr] 151 | json.set_extension("json"); [INFO] [stderr] 152 | [INFO] [stderr] 153 | if json.exists() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/sysroot.rs:144:18 [INFO] [stderr] | [INFO] [stderr] 144 | const TOML: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/sysroot.rs:174:18 [INFO] [stderr] | [INFO] [stderr] 174 | const TOML: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/sysroot.rs:216:18 [INFO] [stderr] | [INFO] [stderr] 216 | const TOML: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/sysroot.rs:310:5 [INFO] [stderr] | [INFO] [stderr] 310 | / if hfile.exists() { [INFO] [stderr] 311 | | if util::read(&hfile)? == hash { [INFO] [stderr] 312 | | return Ok(()); [INFO] [stderr] 313 | | } [INFO] [stderr] 314 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 310 | if hfile.exists() && util::read(&hfile)? == hash { [INFO] [stderr] 311 | return Ok(()); [INFO] [stderr] 312 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:177:12 [INFO] [stderr] | [INFO] [stderr] 177 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 178 | | if let Some(ref config) = config { [INFO] [stderr] 179 | | if let Some(triple) = config.target()? { [INFO] [stderr] 180 | | Target::new(triple, &cd, verbose)?.map(CompilationMode::Cross) [INFO] [stderr] ... | [INFO] [stderr] 186 | | } [INFO] [stderr] 187 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 177 | } else if let Some(ref config) = config { [INFO] [stderr] 178 | if let Some(triple) = config.target()? { [INFO] [stderr] 179 | Target::new(triple, &cd, verbose)?.map(CompilationMode::Cross) [INFO] [stderr] 180 | } else { [INFO] [stderr] 181 | Some(CompilationMode::Native(meta.host.clone())) [INFO] [stderr] 182 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/rustc.rs:148:20 [INFO] [stderr] | [INFO] [stderr] 148 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 149 | | if let Some(p) = env::var_os("RUST_TARGET_PATH") { [INFO] [stderr] 150 | | let mut json = PathBuf::from(p); [INFO] [stderr] 151 | | json.push(&triple); [INFO] [stderr] ... | [INFO] [stderr] 161 | | } [INFO] [stderr] 162 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 148 | } else if let Some(p) = env::var_os("RUST_TARGET_PATH") { [INFO] [stderr] 149 | let mut json = PathBuf::from(p); [INFO] [stderr] 150 | json.push(&triple); [INFO] [stderr] 151 | json.set_extension("json"); [INFO] [stderr] 152 | [INFO] [stderr] 153 | if json.exists() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/sysroot.rs:144:18 [INFO] [stderr] | [INFO] [stderr] 144 | const TOML: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/sysroot.rs:174:18 [INFO] [stderr] | [INFO] [stderr] 174 | const TOML: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/sysroot.rs:216:18 [INFO] [stderr] | [INFO] [stderr] 216 | const TOML: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/sysroot.rs:310:5 [INFO] [stderr] | [INFO] [stderr] 310 | / if hfile.exists() { [INFO] [stderr] 311 | | if util::read(&hfile)? == hash { [INFO] [stderr] 312 | | return Ok(()); [INFO] [stderr] 313 | | } [INFO] [stderr] 314 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 310 | if hfile.exists() && util::read(&hfile)? == hash { [INFO] [stderr] 311 | return Ok(()); [INFO] [stderr] 312 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:177:12 [INFO] [stderr] | [INFO] [stderr] 177 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 178 | | if let Some(ref config) = config { [INFO] [stderr] 179 | | if let Some(triple) = config.target()? { [INFO] [stderr] 180 | | Target::new(triple, &cd, verbose)?.map(CompilationMode::Cross) [INFO] [stderr] ... | [INFO] [stderr] 186 | | } [INFO] [stderr] 187 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 177 | } else if let Some(ref config) = config { [INFO] [stderr] 178 | if let Some(triple) = config.target()? { [INFO] [stderr] 179 | Target::new(triple, &cd, verbose)?.map(CompilationMode::Cross) [INFO] [stderr] 180 | } else { [INFO] [stderr] 181 | Some(CompilationMode::Native(meta.host.clone())) [INFO] [stderr] 182 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cargo.rs:139:17 [INFO] [stderr] | [INFO] [stderr] 139 | format!(".cargo/config: build.target must be a string") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `".cargo/config: build.target must be a string".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config.rs:30:61 [INFO] [stderr] | [INFO] [stderr] 30 | sysroot_path: PathBuf::from(config.sysroot_path.unwrap_or("target/sysroot".into())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "target/sysroot".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/sysroot.rs:282:1 [INFO] [stderr] | [INFO] [stderr] 282 | / pub fn update( [INFO] [stderr] 283 | | cmode: &CompilationMode, [INFO] [stderr] 284 | | home: &Home, [INFO] [stderr] 285 | | root: &Path, [INFO] [stderr] ... | [INFO] [stderr] 342 | | Ok(()) [INFO] [stderr] 343 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stdout(), ...).unwrap()`. Consider using `println!` instead [INFO] [stderr] --> src/lib.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | / writeln!( [INFO] [stderr] 130 | | io::stdout(), [INFO] [stderr] 131 | | concat!("cargo-xbuild ", env!("CARGO_PKG_VERSION"), "{}"), [INFO] [stderr] 132 | | include_str!(concat!(env!("OUT_DIR"), "/commit-info.txt")) [INFO] [stderr] 133 | | ).unwrap(); [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cargo.rs:139:17 [INFO] [stderr] | [INFO] [stderr] 139 | format!(".cargo/config: build.target must be a string") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `".cargo/config: build.target must be a string".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config.rs:30:61 [INFO] [stderr] | [INFO] [stderr] 30 | sysroot_path: PathBuf::from(config.sysroot_path.unwrap_or("target/sysroot".into())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "target/sysroot".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/sysroot.rs:282:1 [INFO] [stderr] | [INFO] [stderr] 282 | / pub fn update( [INFO] [stderr] 283 | | cmode: &CompilationMode, [INFO] [stderr] 284 | | home: &Home, [INFO] [stderr] 285 | | root: &Path, [INFO] [stderr] ... | [INFO] [stderr] 342 | | Ok(()) [INFO] [stderr] 343 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stdout(), ...).unwrap()`. Consider using `println!` instead [INFO] [stderr] --> src/lib.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | / writeln!( [INFO] [stderr] 130 | | io::stdout(), [INFO] [stderr] 131 | | concat!("cargo-xbuild ", env!("CARGO_PKG_VERSION"), "{}"), [INFO] [stderr] 132 | | include_str!(concat!(env!("OUT_DIR"), "/commit-info.txt")) [INFO] [stderr] 133 | | ).unwrap(); [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.83s [INFO] running `"docker" "inspect" "7b24771b38f39eecd5fac98b47091979289a54f734069792817a904339eb79c9"` [INFO] running `"docker" "rm" "-f" "7b24771b38f39eecd5fac98b47091979289a54f734069792817a904339eb79c9"` [INFO] [stdout] 7b24771b38f39eecd5fac98b47091979289a54f734069792817a904339eb79c9