[INFO] crate cargo-when 0.1.0 is already in cache [INFO] extracting crate cargo-when 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/cargo-when/0.1.0 [INFO] extracting crate cargo-when 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-when/0.1.0 [INFO] validating manifest of cargo-when-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cargo-when-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cargo-when-0.1.0 [INFO] finished frobbing cargo-when-0.1.0 [INFO] frobbed toml for cargo-when-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/cargo-when/0.1.0/Cargo.toml [INFO] started frobbing cargo-when-0.1.0 [INFO] finished frobbing cargo-when-0.1.0 [INFO] frobbed toml for cargo-when-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-when/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cargo-when-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cargo-when/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d40b08e2f87f991b41b16521997c6543271207cd51ae476d4aa5acf479f196be [INFO] running `"docker" "start" "-a" "d40b08e2f87f991b41b16521997c6543271207cd51ae476d4aa5acf479f196be"` [INFO] [stderr] Checking cargo-when v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | / match ident { [INFO] [stderr] 41 | | &Identifier::AlphaNumeric(ref s) => s.clone(), [INFO] [stderr] 42 | | &Identifier::Numeric(_) => "unknown".to_string(), [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 40 | match *ident { [INFO] [stderr] 41 | Identifier::AlphaNumeric(ref s) => s.clone(), [INFO] [stderr] 42 | Identifier::Numeric(_) => "unknown".to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/main.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | / fn matches_any_channels<'a, 'b>(&'a self, channels: Option>) -> bool { [INFO] [stderr] 75 | | channels.map_or(true, [INFO] [stderr] 76 | | |mut channels| channels.any(|ch| self.matches_channel(ch))) [INFO] [stderr] 77 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/main.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | / fn matches_any_versions<'a, 'b>(&'a self, [INFO] [stderr] 81 | | versions: Option>) [INFO] [stderr] 82 | | -> Result { [INFO] [stderr] 83 | | match versions { [INFO] [stderr] ... | [INFO] [stderr] 93 | | } [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:113:14 [INFO] [stderr] | [INFO] [stderr] 113 | .ok_or(format!("Invalid environment variable requirement, expecting: {}=VALUE", [INFO] [stderr] | ______________^ [INFO] [stderr] 114 | | name))); [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 113 | .ok_or_else(|| format!("Invalid environment variable requirement, expecting: {}=VALUE", [INFO] [stderr] 114 | name))); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/main.rs:130:1 [INFO] [stderr] | [INFO] [stderr] 130 | / fn any_env_vars_exist<'a>(vars: Option>) -> bool { [INFO] [stderr] 131 | | vars.map_or(true, |mut vars| vars.any(|v| env::var_os(v).is_some())) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/main.rs:135:1 [INFO] [stderr] | [INFO] [stderr] 135 | / fn matches_any_env_vars<'a>(vars: Option>) -> Result { [INFO] [stderr] 136 | | match vars { [INFO] [stderr] 137 | | Some(v) => { [INFO] [stderr] 138 | | for var in v { [INFO] [stderr] ... | [INFO] [stderr] 147 | | } [INFO] [stderr] 148 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | / match ident { [INFO] [stderr] 41 | | &Identifier::AlphaNumeric(ref s) => s.clone(), [INFO] [stderr] 42 | | &Identifier::Numeric(_) => "unknown".to_string(), [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 40 | match *ident { [INFO] [stderr] 41 | Identifier::AlphaNumeric(ref s) => s.clone(), [INFO] [stderr] 42 | Identifier::Numeric(_) => "unknown".to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/main.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | / fn matches_any_channels<'a, 'b>(&'a self, channels: Option>) -> bool { [INFO] [stderr] 75 | | channels.map_or(true, [INFO] [stderr] 76 | | |mut channels| channels.any(|ch| self.matches_channel(ch))) [INFO] [stderr] 77 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/main.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | / fn matches_any_versions<'a, 'b>(&'a self, [INFO] [stderr] 81 | | versions: Option>) [INFO] [stderr] 82 | | -> Result { [INFO] [stderr] 83 | | match versions { [INFO] [stderr] ... | [INFO] [stderr] 93 | | } [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:113:14 [INFO] [stderr] | [INFO] [stderr] 113 | .ok_or(format!("Invalid environment variable requirement, expecting: {}=VALUE", [INFO] [stderr] | ______________^ [INFO] [stderr] 114 | | name))); [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 113 | .ok_or_else(|| format!("Invalid environment variable requirement, expecting: {}=VALUE", [INFO] [stderr] 114 | name))); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/main.rs:130:1 [INFO] [stderr] | [INFO] [stderr] 130 | / fn any_env_vars_exist<'a>(vars: Option>) -> bool { [INFO] [stderr] 131 | | vars.map_or(true, |mut vars| vars.any(|v| env::var_os(v).is_some())) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/main.rs:135:1 [INFO] [stderr] | [INFO] [stderr] 135 | / fn matches_any_env_vars<'a>(vars: Option>) -> Result { [INFO] [stderr] 136 | | match vars { [INFO] [stderr] 137 | | Some(v) => { [INFO] [stderr] 138 | | for var in v { [INFO] [stderr] ... | [INFO] [stderr] 147 | | } [INFO] [stderr] 148 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.46s [INFO] running `"docker" "inspect" "d40b08e2f87f991b41b16521997c6543271207cd51ae476d4aa5acf479f196be"` [INFO] running `"docker" "rm" "-f" "d40b08e2f87f991b41b16521997c6543271207cd51ae476d4aa5acf479f196be"` [INFO] [stdout] d40b08e2f87f991b41b16521997c6543271207cd51ae476d4aa5acf479f196be