[INFO] crate cargo-wa 0.1.1 is already in cache [INFO] extracting crate cargo-wa 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/cargo-wa/0.1.1 [INFO] extracting crate cargo-wa 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-wa/0.1.1 [INFO] validating manifest of cargo-wa-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cargo-wa-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cargo-wa-0.1.1 [INFO] finished frobbing cargo-wa-0.1.1 [INFO] frobbed toml for cargo-wa-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/cargo-wa/0.1.1/Cargo.toml [INFO] started frobbing cargo-wa-0.1.1 [INFO] finished frobbing cargo-wa-0.1.1 [INFO] frobbed toml for cargo-wa-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-wa/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cargo-wa-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cargo-wa/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fd82671008dd60e1e059a7c13bbb4280ebd2efd01616f7767604650fad5b7758 [INFO] running `"docker" "start" "-a" "fd82671008dd60e1e059a7c13bbb4280ebd2efd01616f7767604650fad5b7758"` [INFO] [stderr] Checking cargo-wa v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cargo.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | / match path.extension() { [INFO] [stderr] 83 | | Some(ext) => if ext == "wasm" { [INFO] [stderr] 84 | | return Ok(entry.path()); [INFO] [stderr] 85 | | }, [INFO] [stderr] 86 | | None => {}, [INFO] [stderr] 87 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 82 | if let Some(ext) = path.extension() { if ext == "wasm" { [INFO] [stderr] 83 | return Ok(entry.path()); [INFO] [stderr] 84 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:76:23 [INFO] [stderr] | [INFO] [stderr] 76 | } else if let Some(_) = matches.subcommand_matches("setup") { [INFO] [stderr] | ________________- ^^^^^^^ [INFO] [stderr] 77 | | setup()?; [INFO] [stderr] 78 | | [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________- help: try this: `if matches.subcommand_matches("setup").is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cargo.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | / match path.extension() { [INFO] [stderr] 83 | | Some(ext) => if ext == "wasm" { [INFO] [stderr] 84 | | return Ok(entry.path()); [INFO] [stderr] 85 | | }, [INFO] [stderr] 86 | | None => {}, [INFO] [stderr] 87 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 82 | if let Some(ext) = path.extension() { if ext == "wasm" { [INFO] [stderr] 83 | return Ok(entry.path()); [INFO] [stderr] 84 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:76:23 [INFO] [stderr] | [INFO] [stderr] 76 | } else if let Some(_) = matches.subcommand_matches("setup") { [INFO] [stderr] | ________________- ^^^^^^^ [INFO] [stderr] 77 | | setup()?; [INFO] [stderr] 78 | | [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________- help: try this: `if matches.subcommand_matches("setup").is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.87s [INFO] running `"docker" "inspect" "fd82671008dd60e1e059a7c13bbb4280ebd2efd01616f7767604650fad5b7758"` [INFO] running `"docker" "rm" "-f" "fd82671008dd60e1e059a7c13bbb4280ebd2efd01616f7767604650fad5b7758"` [INFO] [stdout] fd82671008dd60e1e059a7c13bbb4280ebd2efd01616f7767604650fad5b7758