[INFO] crate cargo-tidy 0.1.0 is already in cache
[INFO] extracting crate cargo-tidy 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/cargo-tidy/0.1.0
[INFO] extracting crate cargo-tidy 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-tidy/0.1.0
[INFO] validating manifest of cargo-tidy-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of cargo-tidy-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing cargo-tidy-0.1.0
[INFO] finished frobbing cargo-tidy-0.1.0
[INFO] frobbed toml for cargo-tidy-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/cargo-tidy/0.1.0/Cargo.toml
[INFO] started frobbing cargo-tidy-0.1.0
[INFO] finished frobbing cargo-tidy-0.1.0
[INFO] frobbed toml for cargo-tidy-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-tidy/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting cargo-tidy-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cargo-tidy/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] dcc8b2a12df07edb41431634fd8618ab6b4102aa63c7937f44573eae8c14531c
[INFO] running `"docker" "start" "-a" "dcc8b2a12df07edb41431634fd8618ab6b4102aa63c7937f44573eae8c14531c"`
[INFO] [stderr]     Checking cargo-tidy v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/check/mod.rs:71:13
[INFO] [stderr]    |
[INFO] [stderr] 71 |             msg: msg,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `msg`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/check/mod.rs:93:9
[INFO] [stderr]    |
[INFO] [stderr] 93 |         config: config,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: replace it with: `config`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/check/mod.rs:71:13
[INFO] [stderr]    |
[INFO] [stderr] 71 |             msg: msg,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `msg`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/check/mod.rs:93:9
[INFO] [stderr]    |
[INFO] [stderr] 93 |         config: config,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: replace it with: `config`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/config.rs:66:42
[INFO] [stderr]    |
[INFO] [stderr] 66 |     max_line_length: u64 => |raw: u64| { raw },
[INFO] [stderr]    |                                          ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/config.rs:35:42
[INFO] [stderr]    |
[INFO] [stderr] 35 |                           let $raw_ident = raw.$fld;
[INFO] [stderr]    |                                            ^^^^^^^^
[INFO] [stderr] ...
[INFO] [stderr] 45 | / make_config! {
[INFO] [stderr] 46 | |     // List of file globs to check.
[INFO] [stderr] 47 | |     //
[INFO] [stderr] 48 | |     // Default: `vec!["**/*.rs"]`, which checks all .rs-files in all directories but nothing else.
[INFO] [stderr] ...  |
[INFO] [stderr] 84 | |     },
[INFO] [stderr] 85 | | }
[INFO] [stderr]    | |_- in this macro invocation
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:24:24
[INFO] [stderr]    |
[INFO] [stderr] 24 | const DEFAULT_CONFIG: &'static str = ".cargo-tidy.toml";
[INFO] [stderr]    |                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/check/mod.rs:88:42
[INFO] [stderr]    |
[INFO] [stderr] 88 |         lines_with_endings.push(&content[last_idx..idx+1]);
[INFO] [stderr]    |                                          ^^^^^^^^^^^^^^^ help: use: `last_idx..=idx`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/config.rs:50:18
[INFO] [stderr]    |
[INFO] [stderr] 50 |         try!(raw.unwrap_or(vec!["**/*.rs".to_string()])
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec!["**/*.rs".to_string()])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/config.rs:66:42
[INFO] [stderr]    |
[INFO] [stderr] 66 |     max_line_length: u64 => |raw: u64| { raw },
[INFO] [stderr]    |                                          ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/config.rs:35:42
[INFO] [stderr]    |
[INFO] [stderr] 35 |                           let $raw_ident = raw.$fld;
[INFO] [stderr]    |                                            ^^^^^^^^
[INFO] [stderr] ...
[INFO] [stderr] 45 | / make_config! {
[INFO] [stderr] 46 | |     // List of file globs to check.
[INFO] [stderr] 47 | |     //
[INFO] [stderr] 48 | |     // Default: `vec!["**/*.rs"]`, which checks all .rs-files in all directories but nothing else.
[INFO] [stderr] ...  |
[INFO] [stderr] 84 | |     },
[INFO] [stderr] 85 | | }
[INFO] [stderr]    | |_- in this macro invocation
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:24:24
[INFO] [stderr]    |
[INFO] [stderr] 24 | const DEFAULT_CONFIG: &'static str = ".cargo-tidy.toml";
[INFO] [stderr]    |                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/check/mod.rs:88:42
[INFO] [stderr]    |
[INFO] [stderr] 88 |         lines_with_endings.push(&content[last_idx..idx+1]);
[INFO] [stderr]    |                                          ^^^^^^^^^^^^^^^ help: use: `last_idx..=idx`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/config.rs:50:18
[INFO] [stderr]    |
[INFO] [stderr] 50 |         try!(raw.unwrap_or(vec!["**/*.rs".to_string()])
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec!["**/*.rs".to_string()])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 4.07s
[INFO] running `"docker" "inspect" "dcc8b2a12df07edb41431634fd8618ab6b4102aa63c7937f44573eae8c14531c"`
[INFO] running `"docker" "rm" "-f" "dcc8b2a12df07edb41431634fd8618ab6b4102aa63c7937f44573eae8c14531c"`
[INFO] [stdout] dcc8b2a12df07edb41431634fd8618ab6b4102aa63c7937f44573eae8c14531c