[INFO] crate cargo-tally 0.2.6 is already in cache [INFO] extracting crate cargo-tally 0.2.6 into work/ex/clippy-test-run/sources/stable/reg/cargo-tally/0.2.6 [INFO] extracting crate cargo-tally 0.2.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-tally/0.2.6 [INFO] validating manifest of cargo-tally-0.2.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cargo-tally-0.2.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cargo-tally-0.2.6 [INFO] finished frobbing cargo-tally-0.2.6 [INFO] frobbed toml for cargo-tally-0.2.6 written to work/ex/clippy-test-run/sources/stable/reg/cargo-tally/0.2.6/Cargo.toml [INFO] started frobbing cargo-tally-0.2.6 [INFO] finished frobbing cargo-tally-0.2.6 [INFO] frobbed toml for cargo-tally-0.2.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-tally/0.2.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cargo-tally-0.2.6 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cargo-tally/0.2.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ec0837531fa41887efaefe8899159ac4d5ceaa4820001cfddc1d51c378c41af4 [INFO] running `"docker" "start" "-a" "ec0837531fa41887efaefe8899159ac4d5ceaa4820001cfddc1d51c378c41af4"` [INFO] [stderr] Checking serde_ignored v0.0.4 [INFO] [stderr] Checking string-interner v0.7.0 [INFO] [stderr] Checking crossbeam-epoch v0.7.1 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking crates-io v0.18.0 [INFO] [stderr] Checking tempfile v3.0.5 [INFO] [stderr] Checking parking_lot v0.7.1 [INFO] [stderr] Compiling palette v0.4.1 [INFO] [stderr] Checking crossbeam-deque v0.6.3 [INFO] [stderr] Checking tokio-reactor v0.1.8 [INFO] [stderr] Checking console v0.7.5 [INFO] [stderr] Checking crossbeam v0.6.0 [INFO] [stderr] Checking cargo v0.30.0 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking tokio-threadpool v0.1.11 [INFO] [stderr] Checking indicatif v0.9.0 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking hyper v0.12.23 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.9 [INFO] [stderr] Checking cargo-tally v0.2.6 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `let_and_return` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | let_and_return, map_entry, needless_pass_by_value, redundant_closure_call, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::let_and_return` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `map_entry` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:4:25 [INFO] [stderr] | [INFO] [stderr] 4 | let_and_return, map_entry, needless_pass_by_value, redundant_closure_call, [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::map_entry` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:4:36 [INFO] [stderr] | [INFO] [stderr] 4 | let_and_return, map_entry, needless_pass_by_value, redundant_closure_call, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: lint name `redundant_closure_call` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:4:60 [INFO] [stderr] | [INFO] [stderr] 4 | let_and_return, map_entry, needless_pass_by_value, redundant_closure_call, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_closure_call` [INFO] [stderr] [INFO] [stderr] warning: lint name `unreadable_literal` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | unreadable_literal [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unreadable_literal` [INFO] [stderr] [INFO] [stderr] warning: lint name `let_and_return` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | let_and_return, map_entry, needless_pass_by_value, redundant_closure_call, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::let_and_return` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `map_entry` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:4:25 [INFO] [stderr] | [INFO] [stderr] 4 | let_and_return, map_entry, needless_pass_by_value, redundant_closure_call, [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::map_entry` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:4:36 [INFO] [stderr] | [INFO] [stderr] 4 | let_and_return, map_entry, needless_pass_by_value, redundant_closure_call, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: lint name `redundant_closure_call` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:4:60 [INFO] [stderr] | [INFO] [stderr] 4 | let_and_return, map_entry, needless_pass_by_value, redundant_closure_call, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_closure_call` [INFO] [stderr] [INFO] [stderr] warning: lint name `unreadable_literal` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | unreadable_literal [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unreadable_literal` [INFO] [stderr] [INFO] [stderr] warning: lint name `let_and_return` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | let_and_return, map_entry, needless_pass_by_value, redundant_closure_call, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::let_and_return` [INFO] [stderr] [INFO] [stderr] warning: lint name `let_and_return` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | let_and_return, map_entry, needless_pass_by_value, redundant_closure_call, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::let_and_return` [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/tally.rs:412:14 [INFO] [stderr] | [INFO] [stderr] 412 | for p in 1..num_pages()? + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `1..=num_pages()?` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/tally.rs:412:14 [INFO] [stderr] | [INFO] [stderr] 412 | for p in 1..num_pages()? + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `1..=num_pages()?` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 22s [INFO] running `"docker" "inspect" "ec0837531fa41887efaefe8899159ac4d5ceaa4820001cfddc1d51c378c41af4"` [INFO] running `"docker" "rm" "-f" "ec0837531fa41887efaefe8899159ac4d5ceaa4820001cfddc1d51c378c41af4"` [INFO] [stdout] ec0837531fa41887efaefe8899159ac4d5ceaa4820001cfddc1d51c378c41af4