[INFO] crate cargo-sphinx 1.2.0 is already in cache [INFO] extracting crate cargo-sphinx 1.2.0 into work/ex/clippy-test-run/sources/stable/reg/cargo-sphinx/1.2.0 [INFO] extracting crate cargo-sphinx 1.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-sphinx/1.2.0 [INFO] validating manifest of cargo-sphinx-1.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cargo-sphinx-1.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cargo-sphinx-1.2.0 [INFO] finished frobbing cargo-sphinx-1.2.0 [INFO] frobbed toml for cargo-sphinx-1.2.0 written to work/ex/clippy-test-run/sources/stable/reg/cargo-sphinx/1.2.0/Cargo.toml [INFO] started frobbing cargo-sphinx-1.2.0 [INFO] finished frobbing cargo-sphinx-1.2.0 [INFO] frobbed toml for cargo-sphinx-1.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-sphinx/1.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cargo-sphinx-1.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cargo-sphinx/1.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f8aaa2ebe0b91ddf8f9bf0bc202bd8dcbd06bd538413a930ea265f824771bdde [INFO] running `"docker" "start" "-a" "f8aaa2ebe0b91ddf8f9bf0bc202bd8dcbd06bd538413a930ea265f824771bdde"` [INFO] [stderr] Checking crates-io v0.18.0 [INFO] [stderr] Checking cargo v0.30.0 [INFO] [stderr] Checking cargo-sphinx v1.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cmd.rs:14:37 [INFO] [stderr] | [INFO] [stderr] 14 | shell.status_with_color("", format!("{}", command.join(" ")), Green)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `command.join(" ").to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/config.rs:67:61 [INFO] [stderr] | [INFO] [stderr] 67 | let contents = Config::load_from_file(path).map_err(|e| FatalError::IO(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `FatalError::IO` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cmd.rs:14:37 [INFO] [stderr] | [INFO] [stderr] 14 | shell.status_with_color("", format!("{}", command.join(" ")), Green)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `command.join(" ").to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/config.rs:67:61 [INFO] [stderr] | [INFO] [stderr] 67 | let contents = Config::load_from_file(path).map_err(|e| FatalError::IO(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `FatalError::IO` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 36.73s [INFO] running `"docker" "inspect" "f8aaa2ebe0b91ddf8f9bf0bc202bd8dcbd06bd538413a930ea265f824771bdde"` [INFO] running `"docker" "rm" "-f" "f8aaa2ebe0b91ddf8f9bf0bc202bd8dcbd06bd538413a930ea265f824771bdde"` [INFO] [stdout] f8aaa2ebe0b91ddf8f9bf0bc202bd8dcbd06bd538413a930ea265f824771bdde