[INFO] crate cargo-review-deps 1.0.0 is already in cache [INFO] extracting crate cargo-review-deps 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/cargo-review-deps/1.0.0 [INFO] extracting crate cargo-review-deps 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-review-deps/1.0.0 [INFO] validating manifest of cargo-review-deps-1.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cargo-review-deps-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cargo-review-deps-1.0.0 [INFO] finished frobbing cargo-review-deps-1.0.0 [INFO] frobbed toml for cargo-review-deps-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/cargo-review-deps/1.0.0/Cargo.toml [INFO] started frobbing cargo-review-deps-1.0.0 [INFO] finished frobbing cargo-review-deps-1.0.0 [INFO] frobbed toml for cargo-review-deps-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-review-deps/1.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cargo-review-deps-1.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cargo-review-deps/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 71e451e333de660c1914afcbdf0a71c55e38b3efeaea41bf402994fd5f933db6 [INFO] running `"docker" "start" "-a" "71e451e333de660c1914afcbdf0a71c55e38b3efeaea41bf402994fd5f933db6"` [INFO] [stderr] Checking copy_dir v0.1.2 [INFO] [stderr] Checking cargo_metadata v0.6.4 [INFO] [stderr] Checking cargo-review-deps v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | / if diff_status.is_err() { [INFO] [stderr] 80 | | if !has_diff_cmd() { [INFO] [stderr] 81 | | bail!("looks like you don't have a suitable diff command installed.\n\ [INFO] [stderr] 82 | | Try using --destination flag to run a custom diff tool or to compare sources manually.") [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 79 | if diff_status.is_err() && !has_diff_cmd() { [INFO] [stderr] 80 | bail!("looks like you don't have a suitable diff command installed.\n\ [INFO] [stderr] 81 | Try using --destination flag to run a custom diff tool or to compare sources manually.") [INFO] [stderr] 82 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | / if diff_status.is_err() { [INFO] [stderr] 80 | | if !has_diff_cmd() { [INFO] [stderr] 81 | | bail!("looks like you don't have a suitable diff command installed.\n\ [INFO] [stderr] 82 | | Try using --destination flag to run a custom diff tool or to compare sources manually.") [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 79 | if diff_status.is_err() && !has_diff_cmd() { [INFO] [stderr] 80 | bail!("looks like you don't have a suitable diff command installed.\n\ [INFO] [stderr] 81 | Try using --destination flag to run a custom diff tool or to compare sources manually.") [INFO] [stderr] 82 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.76s [INFO] running `"docker" "inspect" "71e451e333de660c1914afcbdf0a71c55e38b3efeaea41bf402994fd5f933db6"` [INFO] running `"docker" "rm" "-f" "71e451e333de660c1914afcbdf0a71c55e38b3efeaea41bf402994fd5f933db6"` [INFO] [stdout] 71e451e333de660c1914afcbdf0a71c55e38b3efeaea41bf402994fd5f933db6