[INFO] crate cargo-proto-raze 0.1.1 is already in cache
[INFO] extracting crate cargo-proto-raze 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/cargo-proto-raze/0.1.1
[INFO] extracting crate cargo-proto-raze 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-proto-raze/0.1.1
[INFO] validating manifest of cargo-proto-raze-0.1.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of cargo-proto-raze-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing cargo-proto-raze-0.1.1
[INFO] finished frobbing cargo-proto-raze-0.1.1
[INFO] frobbed toml for cargo-proto-raze-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/cargo-proto-raze/0.1.1/Cargo.toml
[INFO] started frobbing cargo-proto-raze-0.1.1
[INFO] finished frobbing cargo-proto-raze-0.1.1
[INFO] frobbed toml for cargo-proto-raze-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-proto-raze/0.1.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting cargo-proto-raze-0.1.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cargo-proto-raze/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 2a0cf07e97834fa77f1ce6ff6689b0e18c1b9298238b985443fe1f02866a2a56
[INFO] running `"docker" "start" "-a" "2a0cf07e97834fa77f1ce6ff6689b0e18c1b9298238b985443fe1f02866a2a56"`
[INFO] [stderr]     Checking fs2 v0.3.0
[INFO] [stderr]     Checking crates-io v0.6.0
[INFO] [stderr]     Checking cargo v0.17.0
[INFO] [stderr]     Checking cargo-proto-raze v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/vendor.rs:75:15
[INFO] [stderr]    |
[INFO] [stderr] 75 |               path: path
[INFO] [stderr]    |               ^^^^^^^^^^ help: replace it with: `path`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/workspace.rs:55:15
[INFO] [stderr]    |
[INFO] [stderr] 55 |               path: path
[INFO] [stderr]    |               ^^^^^^^^^^ help: replace it with: `path`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/vendor.rs:75:15
[INFO] [stderr]    |
[INFO] [stderr] 75 |               path: path
[INFO] [stderr]    |               ^^^^^^^^^^ help: replace it with: `path`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/workspace.rs:55:15
[INFO] [stderr]    |
[INFO] [stderr] 55 |               path: path
[INFO] [stderr]    |               ^^^^^^^^^^ help: replace it with: `path`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/common.rs:123:5
[INFO] [stderr]     |
[INFO] [stderr] 123 |     return feature_strs.into_iter().collect::<String>();
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `feature_strs.into_iter().collect::<String>()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:64:15
[INFO] [stderr]    |
[INFO] [stderr] 64 | const USAGE: &'static str = r#"
[INFO] [stderr]    |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/common.rs:123:5
[INFO] [stderr]     |
[INFO] [stderr] 123 |     return feature_strs.into_iter().collect::<String>();
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `feature_strs.into_iter().collect::<String>()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:64:15
[INFO] [stderr]    |
[INFO] [stderr] 64 | const USAGE: &'static str = r#"
[INFO] [stderr]    |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/common.rs:53:60
[INFO] [stderr]    |
[INFO] [stderr] 53 | pub fn generate_build_file(crate_name: &str, dependencies: &Vec<DependencyWithPath>, feature_strings: &HashSet<String>, platform_triple: &str) -> String {
[INFO] [stderr]    |                                                            ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[DependencyWithPath]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/vendor.rs:30:24
[INFO] [stderr]    |
[INFO] [stderr] 30 |         raze_packages: &Vec<RazePackage>,
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^ help: change this to: `&[RazePackage]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]   --> src/vendor.rs:27:1
[INFO] [stderr]    |
[INFO] [stderr] 27 | / pub fn materialize(
[INFO] [stderr] 28 | |         resolve: &Resolve,
[INFO] [stderr] 29 | |         registry: &mut Source,
[INFO] [stderr] 30 | |         raze_packages: &Vec<RazePackage>,
[INFO] [stderr] ...  |
[INFO] [stderr] 97 | |     Ok(())
[INFO] [stderr] 98 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/vendor.rs:61:28
[INFO] [stderr]    |
[INFO] [stderr] 61 |         let dependencies = resolve.deps(id).into_iter()
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `resolve.deps(id)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/workspace.rs:31:24
[INFO] [stderr]    |
[INFO] [stderr] 31 |         raze_packages: &Vec<RazePackage>,
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^ help: change this to: `&[RazePackage]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/workspace.rs:41:28
[INFO] [stderr]    |
[INFO] [stderr] 41 |         let dependencies = resolve.deps(id).into_iter()
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `resolve.deps(id)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/main.rs:125:21
[INFO] [stderr]     |
[INFO] [stderr] 125 |       let overrides = options.flag_overrides.as_ref()
[INFO] [stderr]     |  _____________________^
[INFO] [stderr] 126 | |       .map(|f| parse_overrides(f).to_result().unwrap())
[INFO] [stderr] 127 | |       .unwrap_or(Vec::new());
[INFO] [stderr]     | |____________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 125 |     let overrides = options.flag_overrides.as_ref()
[INFO] [stderr] 126 |       .map(|f| parse_overrides(f).to_result().unwrap()).unwrap_or_default();
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/main.rs:151:40
[INFO] [stderr]     |
[INFO] [stderr] 151 |         let max = max.entry(id.name()).or_insert(id.version());
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| id.version())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/main.rs:167:21
[INFO] [stderr]     |
[INFO] [stderr] 167 |             features: resolve.features(id)
[INFO] [stderr]     |  _____________________^
[INFO] [stderr] 168 | |             .cloned()
[INFO] [stderr] 169 | |             .unwrap_or(HashSet::new()),
[INFO] [stderr]     | |______________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 167 |           features: resolve.features(id)
[INFO] [stderr] 168 |             .cloned().unwrap_or_default(),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/common.rs:53:60
[INFO] [stderr]    |
[INFO] [stderr] 53 | pub fn generate_build_file(crate_name: &str, dependencies: &Vec<DependencyWithPath>, feature_strings: &HashSet<String>, platform_triple: &str) -> String {
[INFO] [stderr]    |                                                            ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[DependencyWithPath]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/vendor.rs:30:24
[INFO] [stderr]    |
[INFO] [stderr] 30 |         raze_packages: &Vec<RazePackage>,
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^ help: change this to: `&[RazePackage]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]   --> src/vendor.rs:27:1
[INFO] [stderr]    |
[INFO] [stderr] 27 | / pub fn materialize(
[INFO] [stderr] 28 | |         resolve: &Resolve,
[INFO] [stderr] 29 | |         registry: &mut Source,
[INFO] [stderr] 30 | |         raze_packages: &Vec<RazePackage>,
[INFO] [stderr] ...  |
[INFO] [stderr] 97 | |     Ok(())
[INFO] [stderr] 98 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/vendor.rs:61:28
[INFO] [stderr]    |
[INFO] [stderr] 61 |         let dependencies = resolve.deps(id).into_iter()
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `resolve.deps(id)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/workspace.rs:31:24
[INFO] [stderr]    |
[INFO] [stderr] 31 |         raze_packages: &Vec<RazePackage>,
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^ help: change this to: `&[RazePackage]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/workspace.rs:41:28
[INFO] [stderr]    |
[INFO] [stderr] 41 |         let dependencies = resolve.deps(id).into_iter()
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `resolve.deps(id)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/main.rs:125:21
[INFO] [stderr]     |
[INFO] [stderr] 125 |       let overrides = options.flag_overrides.as_ref()
[INFO] [stderr]     |  _____________________^
[INFO] [stderr] 126 | |       .map(|f| parse_overrides(f).to_result().unwrap())
[INFO] [stderr] 127 | |       .unwrap_or(Vec::new());
[INFO] [stderr]     | |____________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 125 |     let overrides = options.flag_overrides.as_ref()
[INFO] [stderr] 126 |       .map(|f| parse_overrides(f).to_result().unwrap()).unwrap_or_default();
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/main.rs:151:40
[INFO] [stderr]     |
[INFO] [stderr] 151 |         let max = max.entry(id.name()).or_insert(id.version());
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| id.version())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/main.rs:167:21
[INFO] [stderr]     |
[INFO] [stderr] 167 |             features: resolve.features(id)
[INFO] [stderr]     |  _____________________^
[INFO] [stderr] 168 | |             .cloned()
[INFO] [stderr] 169 | |             .unwrap_or(HashSet::new()),
[INFO] [stderr]     | |______________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 167 |           features: resolve.features(id)
[INFO] [stderr] 168 |             .cloned().unwrap_or_default(),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 20.73s
[INFO] running `"docker" "inspect" "2a0cf07e97834fa77f1ce6ff6689b0e18c1b9298238b985443fe1f02866a2a56"`
[INFO] running `"docker" "rm" "-f" "2a0cf07e97834fa77f1ce6ff6689b0e18c1b9298238b985443fe1f02866a2a56"`
[INFO] [stdout] 2a0cf07e97834fa77f1ce6ff6689b0e18c1b9298238b985443fe1f02866a2a56