[INFO] crate cargo-project 0.2.1 is already in cache [INFO] extracting crate cargo-project 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/cargo-project/0.2.1 [INFO] extracting crate cargo-project 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-project/0.2.1 [INFO] validating manifest of cargo-project-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cargo-project-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cargo-project-0.2.1 [INFO] finished frobbing cargo-project-0.2.1 [INFO] frobbed toml for cargo-project-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/cargo-project/0.2.1/Cargo.toml [INFO] started frobbing cargo-project-0.2.1 [INFO] finished frobbing cargo-project-0.2.1 [INFO] frobbed toml for cargo-project-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-project/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cargo-project-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cargo-project/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6886687b88317d204178bc60a48bcb1b0099a686b2e0b5a0db882bb3f37712d1 [INFO] running `"docker" "start" "-a" "6886687b88317d204178bc60a48bcb1b0099a686b2e0b5a0db882bb3f37712d1"` [INFO] [stderr] Checking rustc-cfg v0.4.0 [INFO] [stderr] Checking cargo-project v0.2.1 (/opt/crater/workdir) [INFO] [stderr] error: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:74:41 [INFO] [stderr] | [INFO] [stderr] 74 | target_dir = target_dir.or(build.target_dir.map(PathBuf::from)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| build.target_dir.map(PathBuf::from))` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::or_fun_call)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:110:36 [INFO] [stderr] | [INFO] [stderr] 110 | target_dir: target_dir.unwrap_or(root.join("target")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| root.join("target"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:133:38 [INFO] [stderr] | [INFO] [stderr] 133 | if let Some(target) = target.or(self.target()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.target())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:137:34 [INFO] [stderr] | [INFO] [stderr] 137 | let cfg = Cfg::of(target.or(self.target()).unwrap_or(host))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.target())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:228:23 [INFO] [stderr] | [INFO] [stderr] 228 | pub fn is_release(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::trivially_copy_pass_by_ref)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `cargo-project`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:74:41 [INFO] [stderr] | [INFO] [stderr] 74 | target_dir = target_dir.or(build.target_dir.map(PathBuf::from)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| build.target_dir.map(PathBuf::from))` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::or_fun_call)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:110:36 [INFO] [stderr] | [INFO] [stderr] 110 | target_dir: target_dir.unwrap_or(root.join("target")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| root.join("target"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:133:38 [INFO] [stderr] | [INFO] [stderr] 133 | if let Some(target) = target.or(self.target()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.target())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:137:34 [INFO] [stderr] | [INFO] [stderr] 137 | let cfg = Cfg::of(target.or(self.target()).unwrap_or(host))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.target())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:228:23 [INFO] [stderr] | [INFO] [stderr] 228 | pub fn is_release(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::trivially_copy_pass_by_ref)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `cargo-project`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "6886687b88317d204178bc60a48bcb1b0099a686b2e0b5a0db882bb3f37712d1"` [INFO] running `"docker" "rm" "-f" "6886687b88317d204178bc60a48bcb1b0099a686b2e0b5a0db882bb3f37712d1"` [INFO] [stdout] 6886687b88317d204178bc60a48bcb1b0099a686b2e0b5a0db882bb3f37712d1