[INFO] crate cargo-pack-docker 0.3.3 is already in cache [INFO] extracting crate cargo-pack-docker 0.3.3 into work/ex/clippy-test-run/sources/stable/reg/cargo-pack-docker/0.3.3 [INFO] extracting crate cargo-pack-docker 0.3.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-pack-docker/0.3.3 [INFO] validating manifest of cargo-pack-docker-0.3.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cargo-pack-docker-0.3.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cargo-pack-docker-0.3.3 [INFO] finished frobbing cargo-pack-docker-0.3.3 [INFO] frobbed toml for cargo-pack-docker-0.3.3 written to work/ex/clippy-test-run/sources/stable/reg/cargo-pack-docker/0.3.3/Cargo.toml [INFO] started frobbing cargo-pack-docker-0.3.3 [INFO] finished frobbing cargo-pack-docker-0.3.3 [INFO] frobbed toml for cargo-pack-docker-0.3.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-pack-docker/0.3.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cargo-pack-docker-0.3.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cargo-pack-docker/0.3.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b548d784aeed347ec4fbdba4759c11964d43c9cb712f224c4c5a20c4eec5c10b [INFO] running `"docker" "start" "-a" "b548d784aeed347ec4fbdba4759c11964d43c9cb712f224c4c5a20c4eec5c10b"` [INFO] [stderr] Checking home v0.3.4 [INFO] [stderr] Checking serde_ignored v0.0.4 [INFO] [stderr] Checking jobserver v0.1.12 [INFO] [stderr] Checking curl v0.4.19 [INFO] [stderr] Checking rustfix v0.4.4 [INFO] [stderr] Checking which v2.0.1 [INFO] [stderr] Checking git2-curl v0.8.2 [INFO] [stderr] Checking crates-io v0.18.0 [INFO] [stderr] Checking cargo v0.30.0 [INFO] [stderr] Checking cargo-pack v0.4.0 [INFO] [stderr] Checking cargo-pack-docker v0.3.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/docker.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | bin: bin, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `bin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/docker.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | bin: bin, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `bin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/docker.rs:77:21 [INFO] [stderr] | [INFO] [stderr] 77 | 1 => Ok(bins.get(0).unwrap()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&bins[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/docker.rs:209:12 [INFO] [stderr] | [INFO] [stderr] 209 | if self.tags.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.tags.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/docker.rs:263:9 [INFO] [stderr] | [INFO] [stderr] 263 | let _ = buf.flush()?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/docker.rs:77:21 [INFO] [stderr] | [INFO] [stderr] 77 | 1 => Ok(bins.get(0).unwrap()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&bins[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/docker.rs:209:12 [INFO] [stderr] | [INFO] [stderr] 209 | if self.tags.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.tags.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/docker.rs:263:9 [INFO] [stderr] | [INFO] [stderr] 263 | let _ = buf.flush()?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:87:19 [INFO] [stderr] | [INFO] [stderr] 87 | .map(|vs| vs.into_iter().map(|p| p.to_string()).collect::>()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `vs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:87:19 [INFO] [stderr] | [INFO] [stderr] 87 | .map(|vs| vs.into_iter().map(|p| p.to_string()).collect::>()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `vs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 56.58s [INFO] running `"docker" "inspect" "b548d784aeed347ec4fbdba4759c11964d43c9cb712f224c4c5a20c4eec5c10b"` [INFO] running `"docker" "rm" "-f" "b548d784aeed347ec4fbdba4759c11964d43c9cb712f224c4c5a20c4eec5c10b"` [INFO] [stdout] b548d784aeed347ec4fbdba4759c11964d43c9cb712f224c4c5a20c4eec5c10b