[INFO] crate cargo-outdated 0.7.1 is already in cache [INFO] extracting crate cargo-outdated 0.7.1 into work/ex/clippy-test-run/sources/stable/reg/cargo-outdated/0.7.1 [INFO] extracting crate cargo-outdated 0.7.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-outdated/0.7.1 [INFO] validating manifest of cargo-outdated-0.7.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cargo-outdated-0.7.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cargo-outdated-0.7.1 [INFO] finished frobbing cargo-outdated-0.7.1 [INFO] frobbed toml for cargo-outdated-0.7.1 written to work/ex/clippy-test-run/sources/stable/reg/cargo-outdated/0.7.1/Cargo.toml [INFO] started frobbing cargo-outdated-0.7.1 [INFO] finished frobbing cargo-outdated-0.7.1 [INFO] frobbed toml for cargo-outdated-0.7.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-outdated/0.7.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cargo-outdated-0.7.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cargo-outdated/0.7.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 87caf543e1a59a1b7dc4f38b59f4178782c2d205d60d9f1738ec3b66e0540cb8 [INFO] running `"docker" "start" "-a" "87caf543e1a59a1b7dc4f38b59f4178782c2d205d60d9f1738ec3b66e0540cb8"` [INFO] [stderr] Checking crates-io v0.16.0 [INFO] [stderr] Checking cargo v0.28.0 [INFO] [stderr] Checking cargo-outdated v0.7.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cargo_ops/elaborate_workspace.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | workspace: workspace, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workspace` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cargo_ops/elaborate_workspace.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | pkgs: pkgs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pkgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cargo_ops/elaborate_workspace.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | pkg_deps: pkg_deps, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `pkg_deps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/cargo_ops/elaborate_workspace.rs:283:13 [INFO] [stderr] | [INFO] [stderr] 283 | write!(&mut tw, "Name\tProject\tCompat\tLatest\tKind\tPlatform\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/cargo_ops/elaborate_workspace.rs:284:13 [INFO] [stderr] | [INFO] [stderr] 284 | write!(&mut tw, "----\t-------\t------\t------\t----\t--------\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cargo_ops/temp_project.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | temp_dir: temp_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `temp_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cargo_ops/temp_project.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cargo_ops/temp_project.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | relative_manifest: relative_manifest, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `relative_manifest` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cargo_ops/temp_project.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | #[allow(needless_pass_by_value)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cargo_ops/elaborate_workspace.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | workspace: workspace, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workspace` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cargo_ops/elaborate_workspace.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | pkgs: pkgs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pkgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cargo_ops/elaborate_workspace.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | pkg_deps: pkg_deps, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `pkg_deps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/cargo_ops/elaborate_workspace.rs:283:13 [INFO] [stderr] | [INFO] [stderr] 283 | write!(&mut tw, "Name\tProject\tCompat\tLatest\tKind\tPlatform\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/cargo_ops/elaborate_workspace.rs:284:13 [INFO] [stderr] | [INFO] [stderr] 284 | write!(&mut tw, "----\t-------\t------\t------\t----\t--------\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cargo_ops/temp_project.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | temp_dir: temp_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `temp_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cargo_ops/temp_project.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cargo_ops/temp_project.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | relative_manifest: relative_manifest, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `relative_manifest` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cargo_ops/temp_project.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | #[allow(needless_pass_by_value)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | #[allow(needless_pass_by_value)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/cargo_ops/temp_project.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | manifest.lib.as_mut().map(|lib| { [INFO] [stderr] | _____________^ [INFO] [stderr] | |_____________| [INFO] [stderr] | || [INFO] [stderr] 202 | || lib.insert("path".to_owned(), Value::String("test_lib.rs".to_owned())); [INFO] [stderr] 203 | || }); [INFO] [stderr] | ||______________^- help: try this: `if let Some(lib) = manifest.lib.as_mut() { lib.insert("path".to_owned(), Value::String("test_lib.rs".to_owned())); }` [INFO] [stderr] | |_______________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/cargo_ops/temp_project.rs:247:13 [INFO] [stderr] | [INFO] [stderr] 247 | manifest.lib.as_mut().map(|lib| { [INFO] [stderr] | _____________^ [INFO] [stderr] | |_____________| [INFO] [stderr] | || [INFO] [stderr] 248 | || lib.insert("path".to_owned(), Value::String("test_lib.rs".to_owned())); [INFO] [stderr] 249 | || }); [INFO] [stderr] | ||______________^- help: try this: `if let Some(lib) = manifest.lib.as_mut() { lib.insert("path".to_owned(), Value::String("test_lib.rs".to_owned())); }` [INFO] [stderr] | |_______________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/cargo_ops/temp_project.rs:311:14 [INFO] [stderr] | [INFO] [stderr] 311 | .expect(&format!( [INFO] [stderr] | ______________^ [INFO] [stderr] 312 | | "Cannot find matched versions of package {} from source {}", [INFO] [stderr] 313 | | name, source_id [INFO] [stderr] 314 | | )); [INFO] [stderr] | |______________^ help: try this: `unwrap_or_else(|| panic!("Cannot find matched versions of package {} from source {}", name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | #[allow(needless_pass_by_value)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/cargo_ops/temp_project.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | manifest.lib.as_mut().map(|lib| { [INFO] [stderr] | _____________^ [INFO] [stderr] | |_____________| [INFO] [stderr] | || [INFO] [stderr] 202 | || lib.insert("path".to_owned(), Value::String("test_lib.rs".to_owned())); [INFO] [stderr] 203 | || }); [INFO] [stderr] | ||______________^- help: try this: `if let Some(lib) = manifest.lib.as_mut() { lib.insert("path".to_owned(), Value::String("test_lib.rs".to_owned())); }` [INFO] [stderr] | |_______________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/cargo_ops/temp_project.rs:247:13 [INFO] [stderr] | [INFO] [stderr] 247 | manifest.lib.as_mut().map(|lib| { [INFO] [stderr] | _____________^ [INFO] [stderr] | |_____________| [INFO] [stderr] | || [INFO] [stderr] 248 | || lib.insert("path".to_owned(), Value::String("test_lib.rs".to_owned())); [INFO] [stderr] 249 | || }); [INFO] [stderr] | ||______________^- help: try this: `if let Some(lib) = manifest.lib.as_mut() { lib.insert("path".to_owned(), Value::String("test_lib.rs".to_owned())); }` [INFO] [stderr] | |_______________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/cargo_ops/temp_project.rs:311:14 [INFO] [stderr] | [INFO] [stderr] 311 | .expect(&format!( [INFO] [stderr] | ______________^ [INFO] [stderr] 312 | | "Cannot find matched versions of package {} from source {}", [INFO] [stderr] 313 | | name, source_id [INFO] [stderr] 314 | | )); [INFO] [stderr] | |______________^ help: try this: `unwrap_or_else(|| panic!("Cannot find matched versions of package {} from source {}", name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 36.73s [INFO] running `"docker" "inspect" "87caf543e1a59a1b7dc4f38b59f4178782c2d205d60d9f1738ec3b66e0540cb8"` [INFO] running `"docker" "rm" "-f" "87caf543e1a59a1b7dc4f38b59f4178782c2d205d60d9f1738ec3b66e0540cb8"` [INFO] [stdout] 87caf543e1a59a1b7dc4f38b59f4178782c2d205d60d9f1738ec3b66e0540cb8