[INFO] crate cargo-nono 0.1.2 is already in cache [INFO] extracting crate cargo-nono 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/cargo-nono/0.1.2 [INFO] extracting crate cargo-nono 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-nono/0.1.2 [INFO] validating manifest of cargo-nono-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cargo-nono-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cargo-nono-0.1.2 [INFO] finished frobbing cargo-nono-0.1.2 [INFO] frobbed toml for cargo-nono-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/cargo-nono/0.1.2/Cargo.toml [INFO] started frobbing cargo-nono-0.1.2 [INFO] finished frobbing cargo-nono-0.1.2 [INFO] frobbed toml for cargo-nono-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-nono/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cargo-nono-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cargo-nono/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dc1d0bc33aa7de52e0ac5dc20e746161ded17c7ba8d5673376d5ac8e80922300 [INFO] running `"docker" "start" "-a" "dc1d0bc33aa7de52e0ac5dc20e746161ded17c7ba8d5673376d5ac8e80922300"` [INFO] [stderr] Compiling syn v0.15.18 [INFO] [stderr] Checking console v0.6.2 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Checking cargo_metadata v0.6.4 [INFO] [stderr] Checking cargo-nono v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:100:17 [INFO] [stderr] | [INFO] [stderr] 100 | active_features: active_features, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `active_features` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:100:17 [INFO] [stderr] | [INFO] [stderr] 100 | active_features: active_features, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `active_features` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/check.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/check.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ext.rs:193:17 [INFO] [stderr] | [INFO] [stderr] 193 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/check.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/check.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ext.rs:193:17 [INFO] [stderr] | [INFO] [stderr] 193 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/check.rs:138:46 [INFO] [stderr] | [INFO] [stderr] 138 | self.active_features.iter().find(|n| &n.name == feature) [INFO] [stderr] | -------^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `n.name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ext.rs:241:35 [INFO] [stderr] | [INFO] [stderr] 241 | if !feature.name.contains("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ext.rs:245:67 [INFO] [stderr] | [INFO] [stderr] 245 | let dependency_feature_parts: Vec<_> = feature.name.split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/ext.rs:255:9 [INFO] [stderr] | [INFO] [stderr] 255 | / if dep_package_id.is_none() { [INFO] [stderr] 256 | | return None; [INFO] [stderr] 257 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `dep_package_id?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/ext.rs:324:9 [INFO] [stderr] | [INFO] [stderr] 324 | / self.targets [INFO] [stderr] 325 | | .iter() [INFO] [stderr] 326 | | .filter(|target| target.kind.contains(&"proc-macro".to_string())) [INFO] [stderr] 327 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|target| target.kind.contains(&"proc-macro".to_string())).next()` with `find(|target| target.kind.contains(&"proc-macro".to_string()))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/ext.rs:353:49 [INFO] [stderr] | [INFO] [stderr] 353 | let dependency_packages: Vec = self.packages [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 354 | | .iter() [INFO] [stderr] 355 | | .filter(|n| resolve_node.dependencies.contains(&n.id)) [INFO] [stderr] 356 | | .map(|n| n.clone()) [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 353 | let dependency_packages: Vec = self.packages [INFO] [stderr] 354 | .iter() [INFO] [stderr] 355 | .filter(|n| resolve_node.dependencies.contains(&n.id)).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/util.rs:37:45 [INFO] [stderr] | [INFO] [stderr] 37 | let feats = features_args_str.split(","); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/util.rs:54:35 [INFO] [stderr] | [INFO] [stderr] 54 | target_workspace_member = metadata.workspace_members.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&metadata.workspace_members[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/util.rs:99:45 [INFO] [stderr] | [INFO] [stderr] 99 | let dependency_packages: Vec = metadata [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 100 | | .packages [INFO] [stderr] 101 | | .iter() [INFO] [stderr] 102 | | .filter(|n| resolve_node.dependencies.contains(&n.id)) [INFO] [stderr] 103 | | .map(|n| n.clone()) [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 99 | let dependency_packages: Vec = metadata [INFO] [stderr] 100 | .packages [INFO] [stderr] 101 | .iter() [INFO] [stderr] 102 | .filter(|n| resolve_node.dependencies.contains(&n.id)).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | / matches [INFO] [stderr] 54 | | .values_of("features") [INFO] [stderr] 55 | | .map(|n| n.into_iter().map(|m| m.to_owned()).collect()) [INFO] [stderr] 56 | | .unwrap_or(Vec::new()) [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 53 | matches [INFO] [stderr] 54 | .values_of("features") [INFO] [stderr] 55 | .map(|n| n.into_iter().map(|m| m.to_owned()).collect()).unwrap_or_default() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:55:26 [INFO] [stderr] | [INFO] [stderr] 55 | .map(|n| n.into_iter().map(|m| m.to_owned()).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | / let mut support = CrateSupport::NotDetected; [INFO] [stderr] 86 | | if package.is_proc_macro() { [INFO] [stderr] 87 | | support = CrateSupport::ProcMacro; [INFO] [stderr] 88 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let support = if package.is_proc_macro() { CrateSupport::ProcMacro } else { CrateSupport::NotDetected };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:103:31 [INFO] [stderr] | [INFO] [stderr] 103 | let overall_res = match check.no_std_itself() { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 104 | | true => SUCCESS, [INFO] [stderr] 105 | | false => FAILURE, [INFO] [stderr] 106 | | }; [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if check.no_std_itself() { SUCCESS } else { FAILURE }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/check.rs:138:46 [INFO] [stderr] | [INFO] [stderr] 138 | self.active_features.iter().find(|n| &n.name == feature) [INFO] [stderr] | -------^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `n.name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ext.rs:241:35 [INFO] [stderr] | [INFO] [stderr] 241 | if !feature.name.contains("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ext.rs:245:67 [INFO] [stderr] | [INFO] [stderr] 245 | let dependency_feature_parts: Vec<_> = feature.name.split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/ext.rs:255:9 [INFO] [stderr] | [INFO] [stderr] 255 | / if dep_package_id.is_none() { [INFO] [stderr] 256 | | return None; [INFO] [stderr] 257 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `dep_package_id?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/ext.rs:324:9 [INFO] [stderr] | [INFO] [stderr] 324 | / self.targets [INFO] [stderr] 325 | | .iter() [INFO] [stderr] 326 | | .filter(|target| target.kind.contains(&"proc-macro".to_string())) [INFO] [stderr] 327 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|target| target.kind.contains(&"proc-macro".to_string())).next()` with `find(|target| target.kind.contains(&"proc-macro".to_string()))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/ext.rs:353:49 [INFO] [stderr] | [INFO] [stderr] 353 | let dependency_packages: Vec = self.packages [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 354 | | .iter() [INFO] [stderr] 355 | | .filter(|n| resolve_node.dependencies.contains(&n.id)) [INFO] [stderr] 356 | | .map(|n| n.clone()) [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 353 | let dependency_packages: Vec = self.packages [INFO] [stderr] 354 | .iter() [INFO] [stderr] 355 | .filter(|n| resolve_node.dependencies.contains(&n.id)).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/util.rs:37:45 [INFO] [stderr] | [INFO] [stderr] 37 | let feats = features_args_str.split(","); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/util.rs:54:35 [INFO] [stderr] | [INFO] [stderr] 54 | target_workspace_member = metadata.workspace_members.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&metadata.workspace_members[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/util.rs:99:45 [INFO] [stderr] | [INFO] [stderr] 99 | let dependency_packages: Vec = metadata [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 100 | | .packages [INFO] [stderr] 101 | | .iter() [INFO] [stderr] 102 | | .filter(|n| resolve_node.dependencies.contains(&n.id)) [INFO] [stderr] 103 | | .map(|n| n.clone()) [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 99 | let dependency_packages: Vec = metadata [INFO] [stderr] 100 | .packages [INFO] [stderr] 101 | .iter() [INFO] [stderr] 102 | .filter(|n| resolve_node.dependencies.contains(&n.id)).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | / matches [INFO] [stderr] 54 | | .values_of("features") [INFO] [stderr] 55 | | .map(|n| n.into_iter().map(|m| m.to_owned()).collect()) [INFO] [stderr] 56 | | .unwrap_or(Vec::new()) [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 53 | matches [INFO] [stderr] 54 | .values_of("features") [INFO] [stderr] 55 | .map(|n| n.into_iter().map(|m| m.to_owned()).collect()).unwrap_or_default() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:55:26 [INFO] [stderr] | [INFO] [stderr] 55 | .map(|n| n.into_iter().map(|m| m.to_owned()).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | / let mut support = CrateSupport::NotDetected; [INFO] [stderr] 86 | | if package.is_proc_macro() { [INFO] [stderr] 87 | | support = CrateSupport::ProcMacro; [INFO] [stderr] 88 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let support = if package.is_proc_macro() { CrateSupport::ProcMacro } else { CrateSupport::NotDetected };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:103:31 [INFO] [stderr] | [INFO] [stderr] 103 | let overall_res = match check.no_std_itself() { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 104 | | true => SUCCESS, [INFO] [stderr] 105 | | false => FAILURE, [INFO] [stderr] 106 | | }; [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if check.no_std_itself() { SUCCESS } else { FAILURE }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 38.32s [INFO] running `"docker" "inspect" "dc1d0bc33aa7de52e0ac5dc20e746161ded17c7ba8d5673376d5ac8e80922300"` [INFO] running `"docker" "rm" "-f" "dc1d0bc33aa7de52e0ac5dc20e746161ded17c7ba8d5673376d5ac8e80922300"` [INFO] [stdout] dc1d0bc33aa7de52e0ac5dc20e746161ded17c7ba8d5673376d5ac8e80922300