[INFO] crate cargo-navigate 0.1.1 is already in cache [INFO] extracting crate cargo-navigate 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/cargo-navigate/0.1.1 [INFO] extracting crate cargo-navigate 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-navigate/0.1.1 [INFO] validating manifest of cargo-navigate-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cargo-navigate-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cargo-navigate-0.1.1 [INFO] finished frobbing cargo-navigate-0.1.1 [INFO] frobbed toml for cargo-navigate-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/cargo-navigate/0.1.1/Cargo.toml [INFO] started frobbing cargo-navigate-0.1.1 [INFO] finished frobbing cargo-navigate-0.1.1 [INFO] frobbed toml for cargo-navigate-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-navigate/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cargo-navigate-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cargo-navigate/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 68d337f805f7807cc6d8b647fce5f7bb91286fafa05aaf7aaf5d22d68a3a2bc1 [INFO] running `"docker" "start" "-a" "68d337f805f7807cc6d8b647fce5f7bb91286fafa05aaf7aaf5d22d68a3a2bc1"` [INFO] [stderr] Checking cargo-navigate v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/home.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | write!(stderr(), "{}\n", e.to_string()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:46:18 [INFO] [stderr] | [INFO] [stderr] 46 | write!(stderr(), "{}\n", e.to_string()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/home.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | write!(stderr(), "{}\n", e.to_string()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/repo.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | write!(stderr(), "{}\n", e.to_string()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/repo.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | write!(stderr(), "{}\n", e.to_string()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:46:18 [INFO] [stderr] | [INFO] [stderr] 46 | write!(stderr(), "{}\n", e.to_string()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Repository` [INFO] [stderr] --> src/urls.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | Repository, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_command` [INFO] [stderr] --> src/urls.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn from_command>(s: S) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/urls.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn field(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Homepage` [INFO] [stderr] --> src/urls.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | Homepage, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_command` [INFO] [stderr] --> src/urls.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn from_command>(s: S) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/urls.rs:113:31 [INFO] [stderr] | [INFO] [stderr] 113 | let mut cargo_toml_file = PathBuf::from(cdir); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `cdir` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/urls.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn field(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/urls.rs:113:31 [INFO] [stderr] | [INFO] [stderr] 113 | let mut cargo_toml_file = PathBuf::from(cdir); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `cdir` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/repo.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / run(args.subcommand_matches("repo").unwrap()) [INFO] [stderr] 36 | | .err() [INFO] [stderr] 37 | | .map(|e| { [INFO] [stderr] 38 | | write!(stderr(), "{}\n", e.to_string()).unwrap(); [INFO] [stderr] 39 | | std::process::exit(101); [INFO] [stderr] 40 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | if let Some(e) = run(args.subcommand_matches("repo").unwrap()) [INFO] [stderr] 36 | .err() { ... } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `write!(stderr(), ...).unwrap()`. Consider using `eprint!` instead [INFO] [stderr] --> src/repo.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | write!(stderr(), "{}\n", e.to_string()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/home.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / run(args.subcommand_matches("home").unwrap()) [INFO] [stderr] 36 | | .err() [INFO] [stderr] 37 | | .map(|e| { [INFO] [stderr] 38 | | write!(stderr(), "{}\n", e.to_string()).unwrap(); [INFO] [stderr] 39 | | std::process::exit(101); [INFO] [stderr] 40 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | if let Some(e) = run(args.subcommand_matches("home").unwrap()) [INFO] [stderr] 36 | .err() { ... } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `write!(stderr(), ...).unwrap()`. Consider using `eprint!` instead [INFO] [stderr] --> src/home.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | write!(stderr(), "{}\n", e.to_string()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Repository` [INFO] [stderr] --> src/urls.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | Repository, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_command` [INFO] [stderr] --> src/urls.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn from_command>(s: S) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/urls.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn field(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/urls.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn field(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/urls.rs:113:31 [INFO] [stderr] | [INFO] [stderr] 113 | let mut cargo_toml_file = PathBuf::from(cdir); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `cdir` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / run(args.subcommand_matches("navigate").unwrap()) [INFO] [stderr] 44 | | .err() [INFO] [stderr] 45 | | .map(|e| { [INFO] [stderr] 46 | | write!(stderr(), "{}\n", e.to_string()).unwrap(); [INFO] [stderr] 47 | | std::process::exit(101); [INFO] [stderr] 48 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 43 | if let Some(e) = run(args.subcommand_matches("navigate").unwrap()) [INFO] [stderr] 44 | .err() { ... } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `write!(stderr(), ...).unwrap()`. Consider using `eprint!` instead [INFO] [stderr] --> src/main.rs:46:18 [INFO] [stderr] | [INFO] [stderr] 46 | write!(stderr(), "{}\n", e.to_string()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/urls.rs:113:31 [INFO] [stderr] | [INFO] [stderr] 113 | let mut cargo_toml_file = PathBuf::from(cdir); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `cdir` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/home.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / run(args.subcommand_matches("home").unwrap()) [INFO] [stderr] 36 | | .err() [INFO] [stderr] 37 | | .map(|e| { [INFO] [stderr] 38 | | write!(stderr(), "{}\n", e.to_string()).unwrap(); [INFO] [stderr] 39 | | std::process::exit(101); [INFO] [stderr] 40 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | if let Some(e) = run(args.subcommand_matches("home").unwrap()) [INFO] [stderr] 36 | .err() { ... } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `write!(stderr(), ...).unwrap()`. Consider using `eprint!` instead [INFO] [stderr] --> src/home.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | write!(stderr(), "{}\n", e.to_string()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Homepage` [INFO] [stderr] --> src/urls.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | Homepage, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_command` [INFO] [stderr] --> src/urls.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn from_command>(s: S) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/urls.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn field(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/urls.rs:113:31 [INFO] [stderr] | [INFO] [stderr] 113 | let mut cargo_toml_file = PathBuf::from(cdir); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `cdir` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/repo.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / run(args.subcommand_matches("repo").unwrap()) [INFO] [stderr] 36 | | .err() [INFO] [stderr] 37 | | .map(|e| { [INFO] [stderr] 38 | | write!(stderr(), "{}\n", e.to_string()).unwrap(); [INFO] [stderr] 39 | | std::process::exit(101); [INFO] [stderr] 40 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | if let Some(e) = run(args.subcommand_matches("repo").unwrap()) [INFO] [stderr] 36 | .err() { ... } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `write!(stderr(), ...).unwrap()`. Consider using `eprint!` instead [INFO] [stderr] --> src/repo.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | write!(stderr(), "{}\n", e.to_string()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/urls.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn field(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/urls.rs:113:31 [INFO] [stderr] | [INFO] [stderr] 113 | let mut cargo_toml_file = PathBuf::from(cdir); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `cdir` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / run(args.subcommand_matches("navigate").unwrap()) [INFO] [stderr] 44 | | .err() [INFO] [stderr] 45 | | .map(|e| { [INFO] [stderr] 46 | | write!(stderr(), "{}\n", e.to_string()).unwrap(); [INFO] [stderr] 47 | | std::process::exit(101); [INFO] [stderr] 48 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 43 | if let Some(e) = run(args.subcommand_matches("navigate").unwrap()) [INFO] [stderr] 44 | .err() { ... } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `write!(stderr(), ...).unwrap()`. Consider using `eprint!` instead [INFO] [stderr] --> src/main.rs:46:18 [INFO] [stderr] | [INFO] [stderr] 46 | write!(stderr(), "{}\n", e.to_string()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.57s [INFO] running `"docker" "inspect" "68d337f805f7807cc6d8b647fce5f7bb91286fafa05aaf7aaf5d22d68a3a2bc1"` [INFO] running `"docker" "rm" "-f" "68d337f805f7807cc6d8b647fce5f7bb91286fafa05aaf7aaf5d22d68a3a2bc1"` [INFO] [stdout] 68d337f805f7807cc6d8b647fce5f7bb91286fafa05aaf7aaf5d22d68a3a2bc1