[INFO] crate cargo-mdparse 0.1.0 is already in cache [INFO] extracting crate cargo-mdparse 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/cargo-mdparse/0.1.0 [INFO] extracting crate cargo-mdparse 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-mdparse/0.1.0 [INFO] validating manifest of cargo-mdparse-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cargo-mdparse-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cargo-mdparse-0.1.0 [INFO] finished frobbing cargo-mdparse-0.1.0 [INFO] frobbed toml for cargo-mdparse-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/cargo-mdparse/0.1.0/Cargo.toml [INFO] started frobbing cargo-mdparse-0.1.0 [INFO] finished frobbing cargo-mdparse-0.1.0 [INFO] frobbed toml for cargo-mdparse-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-mdparse/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cargo-mdparse-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cargo-mdparse/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 39438a1ed95343f02542fcbb21fba1380b2a40b6f0928ab0715b0d2b216a2a50 [INFO] running `"docker" "start" "-a" "39438a1ed95343f02542fcbb21fba1380b2a40b6f0928ab0715b0d2b216a2a50"` [INFO] [stderr] Checking cargo-mdparse v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:97:32 [INFO] [stderr] | [INFO] [stderr] 97 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 98 | | if args.save_anonymous_block { [INFO] [stderr] 99 | | anonymous_count += 1; [INFO] [stderr] 100 | | Some(format!("mdparse{}.rs", anonymous_count)) [INFO] [stderr] ... | [INFO] [stderr] 103 | | } [INFO] [stderr] 104 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 97 | } else if args.save_anonymous_block { [INFO] [stderr] 98 | anonymous_count += 1; [INFO] [stderr] 99 | Some(format!("mdparse{}.rs", anonymous_count)) [INFO] [stderr] 100 | } else { [INFO] [stderr] 101 | None [INFO] [stderr] 102 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:97:32 [INFO] [stderr] | [INFO] [stderr] 97 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 98 | | if args.save_anonymous_block { [INFO] [stderr] 99 | | anonymous_count += 1; [INFO] [stderr] 100 | | Some(format!("mdparse{}.rs", anonymous_count)) [INFO] [stderr] ... | [INFO] [stderr] 103 | | } [INFO] [stderr] 104 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 97 | } else if args.save_anonymous_block { [INFO] [stderr] 98 | anonymous_count += 1; [INFO] [stderr] 99 | Some(format!("mdparse{}.rs", anonymous_count)) [INFO] [stderr] 100 | } else { [INFO] [stderr] 101 | None [INFO] [stderr] 102 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | / match ty { [INFO] [stderr] 84 | | Tag::CodeBlock(langtype) => { [INFO] [stderr] 85 | | if !langtype.starts_with("rust") { [INFO] [stderr] 86 | | continue; [INFO] [stderr] ... | [INFO] [stderr] 106 | | _ => {} [INFO] [stderr] 107 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 83 | if let Tag::CodeBlock(langtype) = ty { [INFO] [stderr] 84 | if !langtype.starts_with("rust") { [INFO] [stderr] 85 | continue; [INFO] [stderr] 86 | } [INFO] [stderr] 87 | let sp: Vec<_> = langtype.split(':').collect(); [INFO] [stderr] 88 | filename = if sp.len() == 2 { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | / match ty { [INFO] [stderr] 84 | | Tag::CodeBlock(langtype) => { [INFO] [stderr] 85 | | if !langtype.starts_with("rust") { [INFO] [stderr] 86 | | continue; [INFO] [stderr] ... | [INFO] [stderr] 106 | | _ => {} [INFO] [stderr] 107 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 83 | if let Tag::CodeBlock(langtype) = ty { [INFO] [stderr] 84 | if !langtype.starts_with("rust") { [INFO] [stderr] 85 | continue; [INFO] [stderr] 86 | } [INFO] [stderr] 87 | let sp: Vec<_> = langtype.split(':').collect(); [INFO] [stderr] 88 | filename = if sp.len() == 2 { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.85s [INFO] running `"docker" "inspect" "39438a1ed95343f02542fcbb21fba1380b2a40b6f0928ab0715b0d2b216a2a50"` [INFO] running `"docker" "rm" "-f" "39438a1ed95343f02542fcbb21fba1380b2a40b6f0928ab0715b0d2b216a2a50"` [INFO] [stdout] 39438a1ed95343f02542fcbb21fba1380b2a40b6f0928ab0715b0d2b216a2a50