[INFO] crate cargo-makepkg 0.1.0 is already in cache [INFO] extracting crate cargo-makepkg 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/cargo-makepkg/0.1.0 [INFO] extracting crate cargo-makepkg 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-makepkg/0.1.0 [INFO] validating manifest of cargo-makepkg-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cargo-makepkg-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cargo-makepkg-0.1.0 [INFO] finished frobbing cargo-makepkg-0.1.0 [INFO] frobbed toml for cargo-makepkg-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/cargo-makepkg/0.1.0/Cargo.toml [INFO] started frobbing cargo-makepkg-0.1.0 [INFO] finished frobbing cargo-makepkg-0.1.0 [INFO] frobbed toml for cargo-makepkg-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-makepkg/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cargo-makepkg-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cargo-makepkg/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1e4636ad918c7981e8a2803f2662534a00e012a31ec1e34835e9124b73437be3 [INFO] running `"docker" "start" "-a" "1e4636ad918c7981e8a2803f2662534a00e012a31ec1e34835e9124b73437be3"` [INFO] [stderr] Checking cargo-makepkg v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/arch.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | maintainers: maintainers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `maintainers` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/arch.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | pkgname: pkgname, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pkgname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/arch.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | pkgver: pkgver, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `pkgver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/arch.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | pkgrel: pkgrel, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `pkgrel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/arch.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | pkgdesc: pkgdesc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pkgdesc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/arch.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/arch.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | maintainers: maintainers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `maintainers` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/arch.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | pkgname: pkgname, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pkgname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/arch.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | pkgver: pkgver, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `pkgver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/arch.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | pkgrel: pkgrel, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `pkgrel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/arch.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | pkgdesc: pkgdesc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pkgdesc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/arch.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / return json["root"].as_str() [INFO] [stderr] 29 | | .expect("Failed to convert `cargo locate-project` root path to str") [INFO] [stderr] 30 | | .to_owned(); [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 28 | json["root"].as_str() [INFO] [stderr] 29 | .expect("Failed to convert `cargo locate-project` root path to str") [INFO] [stderr] 30 | .to_owned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / return json["root"].as_str() [INFO] [stderr] 29 | | .expect("Failed to convert `cargo locate-project` root path to str") [INFO] [stderr] 30 | | .to_owned(); [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 28 | json["root"].as_str() [INFO] [stderr] 29 | .expect("Failed to convert `cargo locate-project` root path to str") [INFO] [stderr] 30 | .to_owned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/config/arch.rs:54:40 [INFO] [stderr] | [INFO] [stderr] 54 | let override_pkgbuild_config = cargo_manifest.package.metadata [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 55 | | .unwrap_or(CargoMetadata::default()) [INFO] [stderr] 56 | | .archlinux_pkgbuild [INFO] [stderr] 57 | | .unwrap_or(CargoPKGBUILDManifest::default()); [INFO] [stderr] | |________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 54 | let override_pkgbuild_config = cargo_manifest.package.metadata [INFO] [stderr] 55 | .unwrap_or(CargoMetadata::default()) [INFO] [stderr] 56 | .archlinux_pkgbuild.unwrap_or_default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/config/arch.rs:54:40 [INFO] [stderr] | [INFO] [stderr] 54 | let override_pkgbuild_config = cargo_manifest.package.metadata [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 55 | | .unwrap_or(CargoMetadata::default()) [INFO] [stderr] | |________________________________________________^ help: try this: `cargo_manifest.package.metadata.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config/arch.rs:72:48 [INFO] [stderr] | [INFO] [stderr] 72 | let url = override_pkgbuild_config.url.unwrap_or( [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 73 | | cargo_manifest.package.homepage.unwrap_or( [INFO] [stderr] 74 | | cargo_manifest.package.repository.unwrap_or("".to_string()) [INFO] [stderr] 75 | | ) [INFO] [stderr] 76 | | ); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 72 | let url = override_pkgbuild_config.url.unwrap_or_else(|| cargo_manifest.package.homepage.unwrap_or( [INFO] [stderr] 73 | cargo_manifest.package.repository.unwrap_or("".to_string()) [INFO] [stderr] 74 | )); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config/arch.rs:73:45 [INFO] [stderr] | [INFO] [stderr] 73 | cargo_manifest.package.homepage.unwrap_or( [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 74 | | cargo_manifest.package.repository.unwrap_or("".to_string()) [INFO] [stderr] 75 | | ) [INFO] [stderr] | |_____________^ help: try this: `unwrap_or_else(|| cargo_manifest.package.repository.unwrap_or("".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config/arch.rs:74:51 [INFO] [stderr] | [INFO] [stderr] 74 | cargo_manifest.package.repository.unwrap_or("".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:35:10 [INFO] [stderr] | [INFO] [stderr] 35 | .expect(format!("Failed to open Cargo.toml at path {}", manifest_path).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to open Cargo.toml at path {}", manifest_path))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:48:10 [INFO] [stderr] | [INFO] [stderr] 48 | .expect(format!("Could not get parent of manifest path {}", cargo_manifest_path).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Could not get parent of manifest path {}", cargo_manifest_path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/config/arch.rs:54:40 [INFO] [stderr] | [INFO] [stderr] 54 | let override_pkgbuild_config = cargo_manifest.package.metadata [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 55 | | .unwrap_or(CargoMetadata::default()) [INFO] [stderr] 56 | | .archlinux_pkgbuild [INFO] [stderr] 57 | | .unwrap_or(CargoPKGBUILDManifest::default()); [INFO] [stderr] | |________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 54 | let override_pkgbuild_config = cargo_manifest.package.metadata [INFO] [stderr] 55 | .unwrap_or(CargoMetadata::default()) [INFO] [stderr] 56 | .archlinux_pkgbuild.unwrap_or_default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/config/arch.rs:54:40 [INFO] [stderr] | [INFO] [stderr] 54 | let override_pkgbuild_config = cargo_manifest.package.metadata [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 55 | | .unwrap_or(CargoMetadata::default()) [INFO] [stderr] | |________________________________________________^ help: try this: `cargo_manifest.package.metadata.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config/arch.rs:72:48 [INFO] [stderr] | [INFO] [stderr] 72 | let url = override_pkgbuild_config.url.unwrap_or( [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 73 | | cargo_manifest.package.homepage.unwrap_or( [INFO] [stderr] 74 | | cargo_manifest.package.repository.unwrap_or("".to_string()) [INFO] [stderr] 75 | | ) [INFO] [stderr] 76 | | ); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 72 | let url = override_pkgbuild_config.url.unwrap_or_else(|| cargo_manifest.package.homepage.unwrap_or( [INFO] [stderr] 73 | cargo_manifest.package.repository.unwrap_or("".to_string()) [INFO] [stderr] 74 | )); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config/arch.rs:73:45 [INFO] [stderr] | [INFO] [stderr] 73 | cargo_manifest.package.homepage.unwrap_or( [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 74 | | cargo_manifest.package.repository.unwrap_or("".to_string()) [INFO] [stderr] 75 | | ) [INFO] [stderr] | |_____________^ help: try this: `unwrap_or_else(|| cargo_manifest.package.repository.unwrap_or("".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config/arch.rs:74:51 [INFO] [stderr] | [INFO] [stderr] 74 | cargo_manifest.package.repository.unwrap_or("".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:35:10 [INFO] [stderr] | [INFO] [stderr] 35 | .expect(format!("Failed to open Cargo.toml at path {}", manifest_path).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to open Cargo.toml at path {}", manifest_path))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:48:10 [INFO] [stderr] | [INFO] [stderr] 48 | .expect(format!("Could not get parent of manifest path {}", cargo_manifest_path).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Could not get parent of manifest path {}", cargo_manifest_path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.66s [INFO] running `"docker" "inspect" "1e4636ad918c7981e8a2803f2662534a00e012a31ec1e34835e9124b73437be3"` [INFO] running `"docker" "rm" "-f" "1e4636ad918c7981e8a2803f2662534a00e012a31ec1e34835e9124b73437be3"` [INFO] [stdout] 1e4636ad918c7981e8a2803f2662534a00e012a31ec1e34835e9124b73437be3