[INFO] crate cargo-generate 0.2.1 is already in cache [INFO] extracting crate cargo-generate 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/cargo-generate/0.2.1 [INFO] extracting crate cargo-generate 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-generate/0.2.1 [INFO] validating manifest of cargo-generate-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cargo-generate-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cargo-generate-0.2.1 [INFO] finished frobbing cargo-generate-0.2.1 [INFO] frobbed toml for cargo-generate-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/cargo-generate/0.2.1/Cargo.toml [INFO] started frobbing cargo-generate-0.2.1 [INFO] finished frobbing cargo-generate-0.2.1 [INFO] frobbed toml for cargo-generate-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-generate/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cargo-generate-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cargo-generate/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d6b4f75fe58d9a9312b6b517a5bd3dc82af65c624fe985bb85640fa77c1309aa [INFO] running `"docker" "start" "-a" "d6b4f75fe58d9a9312b6b517a5bd3dc82af65c624fe985bb85640fa77c1309aa"` [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Compiling serde v1.0.85 [INFO] [stderr] Checking predicates v0.5.2 [INFO] [stderr] Checking toml v0.4.10 [INFO] [stderr] Checking semver v0.9.0 [INFO] [stderr] Checking serde_ignored v0.0.4 [INFO] [stderr] Checking liquid v0.15.0 [INFO] [stderr] Checking escargot v0.2.0 [INFO] [stderr] Checking crates-io v0.18.0 [INFO] [stderr] Checking rustfix v0.4.4 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking assert_cmd v0.4.0 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking rayon v1.0.3 [INFO] [stderr] Checking quicli v0.3.1 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling rand_pcg v0.1.1 [INFO] [stderr] Compiling parking_lot_core v0.4.0 [INFO] [stderr] Checking rand v0.6.5 [INFO] [stderr] Checking tempfile v3.0.5 [INFO] [stderr] Checking parking_lot v0.7.1 [INFO] [stderr] Checking cargo v0.30.0 [INFO] [stderr] Checking console v0.7.5 [INFO] [stderr] Checking console v0.6.2 [INFO] [stderr] Checking dialoguer v0.1.0 [INFO] [stderr] Checking indicatif v0.9.0 [INFO] [stderr] Checking cargo-generate v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/git.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | remote: remote, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `remote` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/git.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | remote: remote, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `remote` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/integration/helpers/project.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/integration/helpers/project_builder.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | return me; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `me` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/integration/helpers/project.rs:17:14 [INFO] [stderr] | [INFO] [stderr] 17 | .expect(&format!("couldn't read file {:?}", self.root.join(path))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("couldn't read file {:?}", self.root.join(path)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/integration/helpers/project.rs:15:14 [INFO] [stderr] | [INFO] [stderr] 15 | .expect(&format!("couldn't open file {:?}", self.root.join(path))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("couldn't open file {:?}", self.root.join(path)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/integration/helpers/project_builder.rs:68:14 [INFO] [stderr] | [INFO] [stderr] 68 | .expect(&format!("couldn't create {:?} directory", self.root)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("couldn't create {:?} directory", self.root))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/integration/helpers/project_builder.rs:76:15 [INFO] [stderr] | [INFO] [stderr] 76 | ).expect(&format!("couldn't create {:?} directory", dst.parent())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("couldn't create {:?} directory", dst.parent()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/integration/helpers/project_builder.rs:75:22 [INFO] [stderr] | [INFO] [stderr] 75 | .expect(&format!("couldn't find parent dir of {:?}", dst)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("couldn't find parent dir of {:?}", dst))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/integration/helpers/project_builder.rs:81:18 [INFO] [stderr] | [INFO] [stderr] 81 | .expect(&format!("couldn't write to file {:?}: {:?}", dst, contents)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("couldn't write to file {:?}: {:?}", dst))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/integration/helpers/project_builder.rs:79:18 [INFO] [stderr] | [INFO] [stderr] 79 | .expect(&format!("couldn't create file {:?}", dst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("couldn't create file {:?}", dst))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/integration/basics.rs:301:50 [INFO] [stderr] | [INFO] [stderr] 301 | fs::write(&dangerous_file, "YOU BETTER NOT").expect(&format!( [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 302 | | "Could not write {}", [INFO] [stderr] 303 | | dangerous_file.to_str().expect("Could not read path.") [INFO] [stderr] 304 | | )); [INFO] [stderr] | |______^ help: try this: `unwrap_or_else(|_| panic!("Could not write {}", dangerous_file.to_str().expect("Could not read path.")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/git.rs:29:49 [INFO] [stderr] | [INFO] [stderr] 29 | branch: GitReference::Branch(branch.unwrap_or("master".to_string())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "master".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/git.rs:48:8 [INFO] [stderr] | [INFO] [stderr] 48 | Ok(remove_dir_all(project_dir.join(".git")).context("Error cleaning up cloned template")?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 48 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/git.rs:29:49 [INFO] [stderr] | [INFO] [stderr] 29 | branch: GitReference::Branch(branch.unwrap_or("master".to_string())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "master".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/git.rs:48:8 [INFO] [stderr] | [INFO] [stderr] 48 | Ok(remove_dir_all(project_dir.join(".git")).context("Error cleaning up cloned template")?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 48 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 16s [INFO] running `"docker" "inspect" "d6b4f75fe58d9a9312b6b517a5bd3dc82af65c624fe985bb85640fa77c1309aa"` [INFO] running `"docker" "rm" "-f" "d6b4f75fe58d9a9312b6b517a5bd3dc82af65c624fe985bb85640fa77c1309aa"` [INFO] [stdout] d6b4f75fe58d9a9312b6b517a5bd3dc82af65c624fe985bb85640fa77c1309aa