[INFO] crate cargo-find 0.1.6 is already in cache [INFO] extracting crate cargo-find 0.1.6 into work/ex/clippy-test-run/sources/stable/reg/cargo-find/0.1.6 [INFO] extracting crate cargo-find 0.1.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-find/0.1.6 [INFO] validating manifest of cargo-find-0.1.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cargo-find-0.1.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cargo-find-0.1.6 [INFO] finished frobbing cargo-find-0.1.6 [INFO] frobbed toml for cargo-find-0.1.6 written to work/ex/clippy-test-run/sources/stable/reg/cargo-find/0.1.6/Cargo.toml [INFO] started frobbing cargo-find-0.1.6 [INFO] finished frobbing cargo-find-0.1.6 [INFO] frobbed toml for cargo-find-0.1.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-find/0.1.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cargo-find-0.1.6 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cargo-find/0.1.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 47fe65751e7d1b54baff433c8f046eed25ac6d653ad6979d4de4662e931ff419 [INFO] running `"docker" "start" "-a" "47fe65751e7d1b54baff433c8f046eed25ac6d653ad6979d4de4662e931ff419"` [INFO] [stderr] Checking cargo-find v0.1.6 (/opt/crater/workdir) [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/cli.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | / let title: String; [INFO] [stderr] 58 | | if i == self.current_item { [INFO] [stderr] 59 | | title = format!( [INFO] [stderr] 60 | | "{}{}{}", [INFO] [stderr] ... | [INFO] [stderr] 66 | | title = item.title.clone(); [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let title = if i == self.current_item { $ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) ) } else { item.title.clone() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:38:8 [INFO] [stderr] | [INFO] [stderr] 38 | if items.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/cli.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | / let title: String; [INFO] [stderr] 58 | | if i == self.current_item { [INFO] [stderr] 59 | | title = format!( [INFO] [stderr] 60 | | "{}{}{}", [INFO] [stderr] ... | [INFO] [stderr] 66 | | title = item.title.clone(); [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let title = if i == self.current_item { $ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) ) } else { item.title.clone() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:38:8 [INFO] [stderr] | [INFO] [stderr] 38 | if items.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.30s [INFO] running `"docker" "inspect" "47fe65751e7d1b54baff433c8f046eed25ac6d653ad6979d4de4662e931ff419"` [INFO] running `"docker" "rm" "-f" "47fe65751e7d1b54baff433c8f046eed25ac6d653ad6979d4de4662e931ff419"` [INFO] [stdout] 47fe65751e7d1b54baff433c8f046eed25ac6d653ad6979d4de4662e931ff419