[INFO] crate cargo-fel4 0.7.2 is already in cache [INFO] extracting crate cargo-fel4 0.7.2 into work/ex/clippy-test-run/sources/stable/reg/cargo-fel4/0.7.2 [INFO] extracting crate cargo-fel4 0.7.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-fel4/0.7.2 [INFO] validating manifest of cargo-fel4-0.7.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cargo-fel4-0.7.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cargo-fel4-0.7.2 [INFO] finished frobbing cargo-fel4-0.7.2 [INFO] frobbed toml for cargo-fel4-0.7.2 written to work/ex/clippy-test-run/sources/stable/reg/cargo-fel4/0.7.2/Cargo.toml [INFO] started frobbing cargo-fel4-0.7.2 [INFO] finished frobbing cargo-fel4-0.7.2 [INFO] frobbed toml for cargo-fel4-0.7.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-fel4/0.7.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cargo-fel4-0.7.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cargo-fel4/0.7.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dfc825e39a622627be678f9dd2730af50de14d8e0c6d71f4f8e3b2e9e726ecae [INFO] running `"docker" "start" "-a" "dfc825e39a622627be678f9dd2730af50de14d8e0c6d71f4f8e3b2e9e726ecae"` [INFO] [stderr] Checking multimap v0.4.0 [INFO] [stderr] Checking cmake v0.1.35 [INFO] [stderr] Checking quote v0.5.2 [INFO] [stderr] Checking cargo_metadata v0.5.8 [INFO] [stderr] Checking rand_pcg v0.1.1 [INFO] [stderr] Checking rand v0.6.5 [INFO] [stderr] Checking syn v0.13.11 [INFO] [stderr] Checking fel4-config v0.3.2 [INFO] [stderr] Checking tempfile v3.0.5 [INFO] [stderr] Checking cmake_config v0.1.1 [INFO] [stderr] Checking rusty-fork v0.2.1 [INFO] [stderr] Checking cargo-fel4 v0.7.2 (/opt/crater/workdir) [INFO] [stderr] Checking proptest v0.8.7 [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/config.rs:233:33 [INFO] [stderr] | [INFO] [stderr] 233 | pub fn artifact_subdir_path(&self) -> PathBuf { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/config.rs:242:41 [INFO] [stderr] | [INFO] [stderr] 242 | pub fn as_fel4_config_build_profile(&self) -> ConfigBuildProfile { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/config.rs:290:20 [INFO] [stderr] | [INFO] [stderr] 290 | build_profile: &Fel4BuildProfile, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Fel4BuildProfile` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/config.rs:233:33 [INFO] [stderr] | [INFO] [stderr] 233 | pub fn artifact_subdir_path(&self) -> PathBuf { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> tests/basic_integration.rs:44:31 [INFO] [stderr] | [INFO] [stderr] 44 | let target_dir: PathBuf = d.path().join("bar").into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `d.path().join("bar")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> tests/basic_integration.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / let _ = cargo_fel4::handle_new_cmd(&cargo_fel4::NewCmd { [INFO] [stderr] 55 | | loudness: cargo_fel4::LoudnessOpts { [INFO] [stderr] 56 | | verbose: true, [INFO] [stderr] 57 | | quiet: false, [INFO] [stderr] ... | [INFO] [stderr] 60 | | path: target_dir.clone(), [INFO] [stderr] 61 | | }).expect("could not run fel4 new command"); [INFO] [stderr] | |________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> tests/basic_integration.rs:68:35 [INFO] [stderr] | [INFO] [stderr] 68 | let target_dir: PathBuf = d.path().join("bar").into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `d.path().join("bar")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _t =` [INFO] [stderr] --> tests/basic_integration.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | / let _t = cargo_fel4::handle_test_cmd(&cargo_fel4::TestCmd { [INFO] [stderr] 89 | | loudness: cargo_fel4::LoudnessOpts { [INFO] [stderr] 90 | | verbose: true, [INFO] [stderr] 91 | | quiet: false, [INFO] [stderr] ... | [INFO] [stderr] 95 | | cargo_manifest_path: target_cargo_manifest.clone(), [INFO] [stderr] 96 | | }).expect("Could not run handle_test_command"); [INFO] [stderr] | |_______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/config.rs:242:41 [INFO] [stderr] | [INFO] [stderr] 242 | pub fn as_fel4_config_build_profile(&self) -> ConfigBuildProfile { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/config.rs:290:20 [INFO] [stderr] | [INFO] [stderr] 290 | build_profile: &Fel4BuildProfile, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Fel4BuildProfile` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> tests/basic_integration.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | / file.write(&contents.as_bytes()) [INFO] [stderr] 136 | | .expect("Could not write new content"); [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> tests/basic_integration.rs:143:35 [INFO] [stderr] | [INFO] [stderr] 143 | let target_dir: PathBuf = d.path().join("armv7").into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `d.path().join("armv7")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _t =` [INFO] [stderr] --> tests/basic_integration.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | / let _t = cargo_fel4::handle_test_cmd(&cargo_fel4::TestCmd { [INFO] [stderr] 170 | | loudness: cargo_fel4::LoudnessOpts { [INFO] [stderr] 171 | | verbose: true, [INFO] [stderr] 172 | | quiet: false, [INFO] [stderr] ... | [INFO] [stderr] 176 | | cargo_manifest_path: target_cargo_manifest.clone(), [INFO] [stderr] 177 | | }).expect("Could not run handle_test_command"); [INFO] [stderr] | |_______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `cargo-fel4`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "dfc825e39a622627be678f9dd2730af50de14d8e0c6d71f4f8e3b2e9e726ecae"` [INFO] running `"docker" "rm" "-f" "dfc825e39a622627be678f9dd2730af50de14d8e0c6d71f4f8e3b2e9e726ecae"` [INFO] [stdout] dfc825e39a622627be678f9dd2730af50de14d8e0c6d71f4f8e3b2e9e726ecae