[INFO] crate cargo-faircode 1.0.3 is already in cache [INFO] extracting crate cargo-faircode 1.0.3 into work/ex/clippy-test-run/sources/stable/reg/cargo-faircode/1.0.3 [INFO] extracting crate cargo-faircode 1.0.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-faircode/1.0.3 [INFO] validating manifest of cargo-faircode-1.0.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cargo-faircode-1.0.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cargo-faircode-1.0.3 [INFO] finished frobbing cargo-faircode-1.0.3 [INFO] frobbed toml for cargo-faircode-1.0.3 written to work/ex/clippy-test-run/sources/stable/reg/cargo-faircode/1.0.3/Cargo.toml [INFO] started frobbing cargo-faircode-1.0.3 [INFO] finished frobbing cargo-faircode-1.0.3 [INFO] frobbed toml for cargo-faircode-1.0.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-faircode/1.0.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cargo-faircode-1.0.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cargo-faircode/1.0.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 34b9407f1b8fe6fb3c35236944699be3e17e882b3e9a5148aaf93e0c031ff9c6 [INFO] running `"docker" "start" "-a" "34b9407f1b8fe6fb3c35236944699be3e17e882b3e9a5148aaf93e0c031ff9c6"` [INFO] [stderr] Checking cargo-faircode v1.0.3 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / if let &Manifest { [INFO] [stderr] 66 | | package: Some(ManifestPackage { [INFO] [stderr] 67 | | metadata: Some(ManifestMetadata { [INFO] [stderr] 68 | | faircode: Some(ManifestFaircode { [INFO] [stderr] ... | [INFO] [stderr] 77 | | None [INFO] [stderr] 78 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 65 | if let Manifest { [INFO] [stderr] 66 | package: Some(ManifestPackage { [INFO] [stderr] 67 | metadata: Some(ManifestMetadata { [INFO] [stderr] 68 | faircode: Some(ManifestFaircode { [INFO] [stderr] 69 | faircode_id: Some(ref faircode_id) [INFO] [stderr] 70 | }) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / if let &Manifest { [INFO] [stderr] 66 | | package: Some(ManifestPackage { [INFO] [stderr] 67 | | metadata: Some(ManifestMetadata { [INFO] [stderr] 68 | | faircode: Some(ManifestFaircode { [INFO] [stderr] ... | [INFO] [stderr] 77 | | None [INFO] [stderr] 78 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 65 | if let Manifest { [INFO] [stderr] 66 | package: Some(ManifestPackage { [INFO] [stderr] 67 | metadata: Some(ManifestMetadata { [INFO] [stderr] 68 | faircode: Some(ManifestFaircode { [INFO] [stderr] 69 | faircode_id: Some(ref faircode_id) [INFO] [stderr] 70 | }) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:113:22 [INFO] [stderr] | [INFO] [stderr] 113 | let only_legal = match only_legal { [INFO] [stderr] | ______________________^ [INFO] [stderr] 114 | | true => "&only_legal=true", [INFO] [stderr] 115 | | false => "" [INFO] [stderr] 116 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if only_legal { "&only_legal=true" } else { "" }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:129:20 [INFO] [stderr] | [INFO] [stderr] 129 | header.append(&format!("Content-Type: application/json")).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Content-Type: application/json".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:113:22 [INFO] [stderr] | [INFO] [stderr] 113 | let only_legal = match only_legal { [INFO] [stderr] | ______________________^ [INFO] [stderr] 114 | | true => "&only_legal=true", [INFO] [stderr] 115 | | false => "" [INFO] [stderr] 116 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if only_legal { "&only_legal=true" } else { "" }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:129:20 [INFO] [stderr] | [INFO] [stderr] 129 | header.append(&format!("Content-Type: application/json")).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Content-Type: application/json".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.37s [INFO] running `"docker" "inspect" "34b9407f1b8fe6fb3c35236944699be3e17e882b3e9a5148aaf93e0c031ff9c6"` [INFO] running `"docker" "rm" "-f" "34b9407f1b8fe6fb3c35236944699be3e17e882b3e9a5148aaf93e0c031ff9c6"` [INFO] [stdout] 34b9407f1b8fe6fb3c35236944699be3e17e882b3e9a5148aaf93e0c031ff9c6