[INFO] crate cargo-expect 0.1.1 is already in cache [INFO] extracting crate cargo-expect 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/cargo-expect/0.1.1 [INFO] extracting crate cargo-expect 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-expect/0.1.1 [INFO] validating manifest of cargo-expect-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cargo-expect-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cargo-expect-0.1.1 [INFO] finished frobbing cargo-expect-0.1.1 [INFO] frobbed toml for cargo-expect-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/cargo-expect/0.1.1/Cargo.toml [INFO] started frobbing cargo-expect-0.1.1 [INFO] finished frobbing cargo-expect-0.1.1 [INFO] frobbed toml for cargo-expect-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-expect/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cargo-expect-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cargo-expect/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d767f03e389e48d589cd07b7f0f75a2c8de7c617658e17be448c3e058547c5c3 [INFO] running `"docker" "start" "-a" "d767f03e389e48d589cd07b7f0f75a2c8de7c617658e17be448c3e058547c5c3"` [INFO] [stderr] Checking expectation-shared v0.1.0 [INFO] [stderr] Checking crossbeam v0.4.1 [INFO] [stderr] Checking cargo-expect v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/command.rs:24:24 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn tcp_listen() -> IoResult<(String, Receiver<(String, Vec)>)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/command.rs:36:25 [INFO] [stderr] | [INFO] [stderr] 36 | let _ = sender.send(out); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/command.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | let _ = sender.send(()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/command.rs:131:5 [INFO] [stderr] | [INFO] [stderr] 131 | / loop { [INFO] [stderr] 132 | | if let Some((name, results)) = messages.try_recv() { [INFO] [stderr] 133 | | let rs: Vec<_> = results [INFO] [stderr] 134 | | .into_iter() [INFO] [stderr] ... | [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | } [INFO] [stderr] | |_____^ help: try: `while let Some((name, results)) = messages.try_recv() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/command.rs:180:5 [INFO] [stderr] | [INFO] [stderr] 180 | / loop { [INFO] [stderr] 181 | | if let Some((name, results)) = messages.try_recv() { [INFO] [stderr] 182 | | ::output::print_results(&name, &results, verbose); [INFO] [stderr] 183 | | total_results.push((name, results)); [INFO] [stderr] ... | [INFO] [stderr] 186 | | } [INFO] [stderr] 187 | | } [INFO] [stderr] | |_____^ help: try: `while let Some((name, results)) = messages.try_recv() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/command.rs:24:24 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn tcp_listen() -> IoResult<(String, Receiver<(String, Vec)>)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/command.rs:36:25 [INFO] [stderr] | [INFO] [stderr] 36 | let _ = sender.send(out); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/command.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | let _ = sender.send(()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/command.rs:131:5 [INFO] [stderr] | [INFO] [stderr] 131 | / loop { [INFO] [stderr] 132 | | if let Some((name, results)) = messages.try_recv() { [INFO] [stderr] 133 | | let rs: Vec<_> = results [INFO] [stderr] 134 | | .into_iter() [INFO] [stderr] ... | [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | } [INFO] [stderr] | |_____^ help: try: `while let Some((name, results)) = messages.try_recv() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/command.rs:180:5 [INFO] [stderr] | [INFO] [stderr] 180 | / loop { [INFO] [stderr] 181 | | if let Some((name, results)) = messages.try_recv() { [INFO] [stderr] 182 | | ::output::print_results(&name, &results, verbose); [INFO] [stderr] 183 | | total_results.push((name, results)); [INFO] [stderr] ... | [INFO] [stderr] 186 | | } [INFO] [stderr] 187 | | } [INFO] [stderr] | |_____^ help: try: `while let Some((name, results)) = messages.try_recv() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.94s [INFO] running `"docker" "inspect" "d767f03e389e48d589cd07b7f0f75a2c8de7c617658e17be448c3e058547c5c3"` [INFO] running `"docker" "rm" "-f" "d767f03e389e48d589cd07b7f0f75a2c8de7c617658e17be448c3e058547c5c3"` [INFO] [stdout] d767f03e389e48d589cd07b7f0f75a2c8de7c617658e17be448c3e058547c5c3