[INFO] crate cargo-ensure-installed 0.2.1 is already in cache [INFO] extracting crate cargo-ensure-installed 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/cargo-ensure-installed/0.2.1 [INFO] extracting crate cargo-ensure-installed 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-ensure-installed/0.2.1 [INFO] validating manifest of cargo-ensure-installed-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cargo-ensure-installed-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cargo-ensure-installed-0.2.1 [INFO] finished frobbing cargo-ensure-installed-0.2.1 [INFO] frobbed toml for cargo-ensure-installed-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/cargo-ensure-installed/0.2.1/Cargo.toml [INFO] started frobbing cargo-ensure-installed-0.2.1 [INFO] finished frobbing cargo-ensure-installed-0.2.1 [INFO] frobbed toml for cargo-ensure-installed-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-ensure-installed/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cargo-ensure-installed-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cargo-ensure-installed/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] de9141c192dc346787cd5fcc24949a2febb500ad71f52915e65028447b4c403a [INFO] running `"docker" "start" "-a" "de9141c192dc346787cd5fcc24949a2febb500ad71f52915e65028447b4c403a"` [INFO] [stderr] Checking cargo-ensure-installed v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:68:25 [INFO] [stderr] | [INFO] [stderr] 68 | _ => return Err(format!("Cannot specify one of git-url and git-rev")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Cannot specify one of git-url and git-rev".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:86:17 [INFO] [stderr] | [INFO] [stderr] 86 | / match &git { [INFO] [stderr] 87 | | &Some(ref git) => { [INFO] [stderr] 88 | | args.push("--git"); [INFO] [stderr] 89 | | args.push(&git.0); [INFO] [stderr] ... | [INFO] [stderr] 93 | | &None => {} [INFO] [stderr] 94 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 86 | match git { [INFO] [stderr] 87 | Some(ref git) => { [INFO] [stderr] 88 | args.push("--git"); [INFO] [stderr] 89 | args.push(&git.0); [INFO] [stderr] 90 | args.push("--rev"); [INFO] [stderr] 91 | args.push(&git.1); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:112:8 [INFO] [stderr] | [INFO] [stderr] 112 | if crates_toml_contents.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `crates_toml_contents.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:143:44 [INFO] [stderr] | [INFO] [stderr] 143 | let parts: Vec<_> = line.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:144:31 [INFO] [stderr] | [INFO] [stderr] 144 | let raw_version = parts.get(1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&parts[1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:68:25 [INFO] [stderr] | [INFO] [stderr] 68 | _ => return Err(format!("Cannot specify one of git-url and git-rev")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Cannot specify one of git-url and git-rev".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:86:17 [INFO] [stderr] | [INFO] [stderr] 86 | / match &git { [INFO] [stderr] 87 | | &Some(ref git) => { [INFO] [stderr] 88 | | args.push("--git"); [INFO] [stderr] 89 | | args.push(&git.0); [INFO] [stderr] ... | [INFO] [stderr] 93 | | &None => {} [INFO] [stderr] 94 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 86 | match git { [INFO] [stderr] 87 | Some(ref git) => { [INFO] [stderr] 88 | args.push("--git"); [INFO] [stderr] 89 | args.push(&git.0); [INFO] [stderr] 90 | args.push("--rev"); [INFO] [stderr] 91 | args.push(&git.1); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:112:8 [INFO] [stderr] | [INFO] [stderr] 112 | if crates_toml_contents.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `crates_toml_contents.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:143:44 [INFO] [stderr] | [INFO] [stderr] 143 | let parts: Vec<_> = line.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:144:31 [INFO] [stderr] | [INFO] [stderr] 144 | let raw_version = parts.get(1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&parts[1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.29s [INFO] running `"docker" "inspect" "de9141c192dc346787cd5fcc24949a2febb500ad71f52915e65028447b4c403a"` [INFO] running `"docker" "rm" "-f" "de9141c192dc346787cd5fcc24949a2febb500ad71f52915e65028447b4c403a"` [INFO] [stdout] de9141c192dc346787cd5fcc24949a2febb500ad71f52915e65028447b4c403a