[INFO] crate cargo-edit-locally 0.1.3 is already in cache [INFO] extracting crate cargo-edit-locally 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/cargo-edit-locally/0.1.3 [INFO] extracting crate cargo-edit-locally 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-edit-locally/0.1.3 [INFO] validating manifest of cargo-edit-locally-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cargo-edit-locally-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cargo-edit-locally-0.1.3 [INFO] finished frobbing cargo-edit-locally-0.1.3 [INFO] frobbed toml for cargo-edit-locally-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/cargo-edit-locally/0.1.3/Cargo.toml [INFO] started frobbing cargo-edit-locally-0.1.3 [INFO] finished frobbing cargo-edit-locally-0.1.3 [INFO] frobbed toml for cargo-edit-locally-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-edit-locally/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cargo-edit-locally-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cargo-edit-locally/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 97d534756c402b9a84641f9bcc392b84e56ae95baa2662fa3b7b7bdba505cd33 [INFO] running `"docker" "start" "-a" "97d534756c402b9a84641f9bcc392b84e56ae95baa2662fa3b7b7bdba505cd33"` [INFO] [stderr] Checking serde_ignored v0.0.2 [INFO] [stderr] Checking semver v0.6.0 [INFO] [stderr] Checking docopt v0.7.0 [INFO] [stderr] Checking crates-io v0.7.0 [INFO] [stderr] Checking git2-curl v0.7.0 [INFO] [stderr] Checking cargo v0.18.0 [INFO] [stderr] Checking cargo-edit-locally v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/log.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | return cmd [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `cmd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/log.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | return dir [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:131:8 [INFO] [stderr] | [INFO] [stderr] 131 | if candidates.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `candidates.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:137:27 [INFO] [stderr] | [INFO] [stderr] 137 | msg.push_str(&format!("perhaps a different branch/tag is needed?")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"perhaps a different branch/tag is needed?".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:139:27 [INFO] [stderr] | [INFO] [stderr] 139 | msg.push_str(&format!("perhaps this path contains the wrong version?")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"perhaps this path contains the wrong version?".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:183:42 [INFO] [stderr] | [INFO] [stderr] 183 | match manifest[i + 1..].find("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:131:8 [INFO] [stderr] | [INFO] [stderr] 131 | if candidates.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `candidates.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:137:27 [INFO] [stderr] | [INFO] [stderr] 137 | msg.push_str(&format!("perhaps a different branch/tag is needed?")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"perhaps a different branch/tag is needed?".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:139:27 [INFO] [stderr] | [INFO] [stderr] 139 | msg.push_str(&format!("perhaps this path contains the wrong version?")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"perhaps this path contains the wrong version?".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:183:42 [INFO] [stderr] | [INFO] [stderr] 183 | match manifest[i + 1..].find("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 30.73s [INFO] running `"docker" "inspect" "97d534756c402b9a84641f9bcc392b84e56ae95baa2662fa3b7b7bdba505cd33"` [INFO] running `"docker" "rm" "-f" "97d534756c402b9a84641f9bcc392b84e56ae95baa2662fa3b7b7bdba505cd33"` [INFO] [stdout] 97d534756c402b9a84641f9bcc392b84e56ae95baa2662fa3b7b7bdba505cd33