[INFO] crate cargo-deliver 0.2.0 is already in cache [INFO] extracting crate cargo-deliver 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/cargo-deliver/0.2.0 [INFO] extracting crate cargo-deliver 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-deliver/0.2.0 [INFO] validating manifest of cargo-deliver-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cargo-deliver-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cargo-deliver-0.2.0 [INFO] finished frobbing cargo-deliver-0.2.0 [INFO] frobbed toml for cargo-deliver-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/cargo-deliver/0.2.0/Cargo.toml [INFO] started frobbing cargo-deliver-0.2.0 [INFO] finished frobbing cargo-deliver-0.2.0 [INFO] frobbed toml for cargo-deliver-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-deliver/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cargo-deliver-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cargo-deliver/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 13cc1ed61e1f410fd933f845ad02a4dac04de29f4b65f715f77610b3bb6a7964 [INFO] running `"docker" "start" "-a" "13cc1ed61e1f410fd933f845ad02a4dac04de29f4b65f715f77610b3bb6a7964"` [INFO] [stderr] Compiling winapi v0.3.6 [INFO] [stderr] Checking tera v0.10.10 [INFO] [stderr] Checking shared_child v0.3.3 [INFO] [stderr] Checking duct v0.9.2 [INFO] [stderr] Checking cargo-deliver v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/main.rs:74:31 [INFO] [stderr] | [INFO] [stderr] 74 | .and_then(|_| Ok(process::exit(0))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:35:16 [INFO] [stderr] | [INFO] [stderr] 35 | let path = env::var_os("PATH").unwrap_or(OsString::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `env::var_os("PATH").unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/main.rs:52:8 [INFO] [stderr] | [INFO] [stderr] 52 | Ok(output.write_all(content.as_bytes())?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 52 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:75:18 [INFO] [stderr] | [INFO] [stderr] 75 | .expect(&format!("Cannot create `{}`", GORLEASER_CONFIG)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Cannot create `{}`", GORLEASER_CONFIG))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/main.rs:67:41 [INFO] [stderr] | [INFO] [stderr] 67 | .and_then(|rendered| Ok(write_config(rendered)?)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 67 | .and_then(|rendered| Ok(())) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/main.rs:69:24 [INFO] [stderr] | [INFO] [stderr] 69 | Ok(println!( [INFO] [stderr] | ________________________^ [INFO] [stderr] 70 | | "Done. Please review the config file at {} and re-run the command.", [INFO] [stderr] 71 | | GORLEASER_CONFIG [INFO] [stderr] 72 | | )) [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/main.rs:74:31 [INFO] [stderr] | [INFO] [stderr] 74 | .and_then(|_| Ok(process::exit(0))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:35:16 [INFO] [stderr] | [INFO] [stderr] 35 | let path = env::var_os("PATH").unwrap_or(OsString::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `env::var_os("PATH").unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/main.rs:52:8 [INFO] [stderr] | [INFO] [stderr] 52 | Ok(output.write_all(content.as_bytes())?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 52 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:75:18 [INFO] [stderr] | [INFO] [stderr] 75 | .expect(&format!("Cannot create `{}`", GORLEASER_CONFIG)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Cannot create `{}`", GORLEASER_CONFIG))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/main.rs:67:41 [INFO] [stderr] | [INFO] [stderr] 67 | .and_then(|rendered| Ok(write_config(rendered)?)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 67 | .and_then(|rendered| Ok(())) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/main.rs:69:24 [INFO] [stderr] | [INFO] [stderr] 69 | Ok(println!( [INFO] [stderr] | ________________________^ [INFO] [stderr] 70 | | "Done. Please review the config file at {} and re-run the command.", [INFO] [stderr] 71 | | GORLEASER_CONFIG [INFO] [stderr] 72 | | )) [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.69s [INFO] running `"docker" "inspect" "13cc1ed61e1f410fd933f845ad02a4dac04de29f4b65f715f77610b3bb6a7964"` [INFO] running `"docker" "rm" "-f" "13cc1ed61e1f410fd933f845ad02a4dac04de29f4b65f715f77610b3bb6a7964"` [INFO] [stdout] 13cc1ed61e1f410fd933f845ad02a4dac04de29f4b65f715f77610b3bb6a7964