[INFO] crate cargo-create-protocols-plugin 0.0.2 is already in cache
[INFO] extracting crate cargo-create-protocols-plugin 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/cargo-create-protocols-plugin/0.0.2
[INFO] extracting crate cargo-create-protocols-plugin 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-create-protocols-plugin/0.0.2
[INFO] validating manifest of cargo-create-protocols-plugin-0.0.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of cargo-create-protocols-plugin-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing cargo-create-protocols-plugin-0.0.2
[INFO] finished frobbing cargo-create-protocols-plugin-0.0.2
[INFO] frobbed toml for cargo-create-protocols-plugin-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/cargo-create-protocols-plugin/0.0.2/Cargo.toml
[INFO] started frobbing cargo-create-protocols-plugin-0.0.2
[INFO] finished frobbing cargo-create-protocols-plugin-0.0.2
[INFO] frobbed toml for cargo-create-protocols-plugin-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-create-protocols-plugin/0.0.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting cargo-create-protocols-plugin-0.0.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cargo-create-protocols-plugin/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 017884c665751c75fccdf609707efc8f95dde86c6340834d141f5b50103d0c05
[INFO] running `"docker" "start" "-a" "017884c665751c75fccdf609707efc8f95dde86c6340834d141f5b50103d0c05"`
[INFO] [stderr]     Checking cargo-create-protocols-plugin v0.0.2 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/createcrate.rs:155:9
[INFO] [stderr]     |
[INFO] [stderr] 155 |         data
[INFO] [stderr]     |         ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/createcrate.rs:154:20
[INFO] [stderr]     |
[INFO] [stderr] 154 |         let data = data.replace("__PROTOCOLBUFFERSTRUCT__", &self.struct_name());
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/createcrate.rs:155:9
[INFO] [stderr]     |
[INFO] [stderr] 155 |         data
[INFO] [stderr]     |         ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/createcrate.rs:154:20
[INFO] [stderr]     |
[INFO] [stderr] 154 |         let data = data.replace("__PROTOCOLBUFFERSTRUCT__", &self.struct_name());
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/createcrate.rs:81:53
[INFO] [stderr]    |
[INFO] [stderr] 81 |         let filename = self.schema_path.file_name().ok_or(format_err!("Cannot parse filename!"))?;
[INFO] [stderr]    |                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("Cannot parse filename!"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/createcrate.rs:82:42
[INFO] [stderr]    |
[INFO] [stderr] 82 |         let filename = filename.to_str().ok_or(format_err!("Cannot convert osStr to str."))?;
[INFO] [stderr]    |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("Cannot convert osStr to str."))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/createcrate.rs:83:53
[INFO] [stderr]    |
[INFO] [stderr] 83 |         let basename = self.schema_path.file_stem().ok_or(format_err!("Cannot find file!"))?;
[INFO] [stderr]    |                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("Cannot find file!"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/createcrate.rs:84:42
[INFO] [stderr]    |
[INFO] [stderr] 84 |         let basename = basename.to_str().ok_or(format_err!("Cannot convert osStr to str."))?;
[INFO] [stderr]    |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("Cannot convert osStr to str."))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/createcrate.rs:114:12
[INFO] [stderr]     |
[INFO] [stderr] 114 |         if output.stdout.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!output.stdout.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/createcrate.rs:116:12
[INFO] [stderr]     |
[INFO] [stderr] 116 |         if output.stderr.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!output.stderr.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:56:78
[INFO] [stderr]    |
[INFO] [stderr] 56 |     let matches = root_matches.subcommand_matches("create-protocols-plugin").ok_or(format_err!("No subcommand found!"))?;
[INFO] [stderr]    |                                                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("No subcommand found!"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:57:52
[INFO] [stderr]    |
[INFO] [stderr] 57 |     let crate_name = matches.value_of("cratename").ok_or(format_err!("No crate name found!"))?;
[INFO] [stderr]    |                                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("No crate name found!"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:58:58
[INFO] [stderr]    |
[INFO] [stderr] 58 |     let protocol_filename = matches.value_of("protocol").ok_or(format_err!("No protocol file found!"))?;
[INFO] [stderr]    |                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("No protocol file found!"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/createcrate.rs:81:53
[INFO] [stderr]    |
[INFO] [stderr] 81 |         let filename = self.schema_path.file_name().ok_or(format_err!("Cannot parse filename!"))?;
[INFO] [stderr]    |                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("Cannot parse filename!"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/createcrate.rs:82:42
[INFO] [stderr]    |
[INFO] [stderr] 82 |         let filename = filename.to_str().ok_or(format_err!("Cannot convert osStr to str."))?;
[INFO] [stderr]    |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("Cannot convert osStr to str."))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/createcrate.rs:83:53
[INFO] [stderr]    |
[INFO] [stderr] 83 |         let basename = self.schema_path.file_stem().ok_or(format_err!("Cannot find file!"))?;
[INFO] [stderr]    |                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("Cannot find file!"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/createcrate.rs:84:42
[INFO] [stderr]    |
[INFO] [stderr] 84 |         let basename = basename.to_str().ok_or(format_err!("Cannot convert osStr to str."))?;
[INFO] [stderr]    |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("Cannot convert osStr to str."))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/createcrate.rs:114:12
[INFO] [stderr]     |
[INFO] [stderr] 114 |         if output.stdout.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!output.stdout.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/createcrate.rs:116:12
[INFO] [stderr]     |
[INFO] [stderr] 116 |         if output.stderr.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!output.stderr.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:56:78
[INFO] [stderr]    |
[INFO] [stderr] 56 |     let matches = root_matches.subcommand_matches("create-protocols-plugin").ok_or(format_err!("No subcommand found!"))?;
[INFO] [stderr]    |                                                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("No subcommand found!"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:57:52
[INFO] [stderr]    |
[INFO] [stderr] 57 |     let crate_name = matches.value_of("cratename").ok_or(format_err!("No crate name found!"))?;
[INFO] [stderr]    |                                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("No crate name found!"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:58:58
[INFO] [stderr]    |
[INFO] [stderr] 58 |     let protocol_filename = matches.value_of("protocol").ok_or(format_err!("No protocol file found!"))?;
[INFO] [stderr]    |                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("No protocol file found!"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.64s
[INFO] running `"docker" "inspect" "017884c665751c75fccdf609707efc8f95dde86c6340834d141f5b50103d0c05"`
[INFO] running `"docker" "rm" "-f" "017884c665751c75fccdf609707efc8f95dde86c6340834d141f5b50103d0c05"`
[INFO] [stdout] 017884c665751c75fccdf609707efc8f95dde86c6340834d141f5b50103d0c05