[INFO] crate cargo-count 0.2.4 is already in cache [INFO] extracting crate cargo-count 0.2.4 into work/ex/clippy-test-run/sources/stable/reg/cargo-count/0.2.4 [INFO] extracting crate cargo-count 0.2.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-count/0.2.4 [INFO] validating manifest of cargo-count-0.2.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cargo-count-0.2.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cargo-count-0.2.4 [INFO] finished frobbing cargo-count-0.2.4 [INFO] frobbed toml for cargo-count-0.2.4 written to work/ex/clippy-test-run/sources/stable/reg/cargo-count/0.2.4/Cargo.toml [INFO] started frobbing cargo-count-0.2.4 [INFO] finished frobbing cargo-count-0.2.4 [INFO] frobbed toml for cargo-count-0.2.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-count/0.2.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cargo-count-0.2.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cargo-count/0.2.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 83c0c7c02371545ab1751fc2acf40a37c18c3cbe25baa9f89948745277df51e8 [INFO] running `"docker" "start" "-a" "83c0c7c02371545ab1751fc2acf40a37c18c3cbe25baa9f89948745277df51e8"` [INFO] [stderr] Checking tabwriter v0.1.25 [INFO] [stderr] Checking gitignore v1.0.6 [INFO] [stderr] Checking clap v2.11.3 [INFO] [stderr] Checking cargo-count v0.2.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/count/counts.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | cfg: cfg, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cfg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/count/mod.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | lang: lang, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `lang` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/count/mod.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | sep: sep, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sep` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/count/counts.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | cfg: cfg, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cfg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/count/mod.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | lang: lang, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `lang` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/count/mod.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | sep: sep, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sep` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/macros.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | / macro_rules! werr( [INFO] [stderr] 18 | | ($($arg:tt)*) => ({ [INFO] [stderr] 19 | | use std::io::{Write, stderr}; [INFO] [stderr] 20 | | write!(&mut stderr(), $($arg)*).ok(); [INFO] [stderr] 21 | | }) [INFO] [stderr] 22 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/macros.rs:61:1 [INFO] [stderr] | [INFO] [stderr] 61 | / macro_rules! debug { [INFO] [stderr] 62 | | ($fmt:expr) => (); [INFO] [stderr] 63 | | ($fmt:expr, $($arg:tt)*) => (); [INFO] [stderr] 64 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/config.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | / arg_enum! { [INFO] [stderr] 11 | | #[derive(Debug)] [INFO] [stderr] 12 | | pub enum Utf8Rule { [INFO] [stderr] 13 | | Ignore, [INFO] [stderr] ... | [INFO] [stderr] 16 | | } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/config.rs:36:24 [INFO] [stderr] | [INFO] [stderr] 36 | if let None = Language::from_ext(e) { [INFO] [stderr] | _________________- ^^^^ [INFO] [stderr] 37 | | return Err(CliError::UnknownExt(format!("unsupported source code extension \ [INFO] [stderr] 38 | | '{}'", [INFO] [stderr] 39 | | e.to_owned()))); [INFO] [stderr] 40 | | } [INFO] [stderr] | |_________________- help: try this: `if Language::from_ext(e).is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/count/counts.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | / pub fn count(&mut self) -> CliResult<()> { [INFO] [stderr] 105 | | for count in self.counts.iter_mut() { [INFO] [stderr] 106 | | debugln!("iter; count={:?};", count); [INFO] [stderr] 107 | | let re = if let Some(kw) = count.lang.unsafe_keyword() { [INFO] [stderr] ... | [INFO] [stderr] 267 | | Ok(()) [INFO] [stderr] 268 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/count/counts.rs:110:28 [INFO] [stderr] | [INFO] [stderr] 110 | Regex::new("").unwrap() [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: the regex is unlikely to be useful as it is [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/count/counts.rs:330:20 [INFO] [stderr] | [INFO] [stderr] 330 | String::from_utf8(w.unwrap()).ok().expect("failed to get valid UTF-8 String")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/macros.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | / macro_rules! werr( [INFO] [stderr] 18 | | ($($arg:tt)*) => ({ [INFO] [stderr] 19 | | use std::io::{Write, stderr}; [INFO] [stderr] 20 | | write!(&mut stderr(), $($arg)*).ok(); [INFO] [stderr] 21 | | }) [INFO] [stderr] 22 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/macros.rs:61:1 [INFO] [stderr] | [INFO] [stderr] 61 | / macro_rules! debug { [INFO] [stderr] 62 | | ($fmt:expr) => (); [INFO] [stderr] 63 | | ($fmt:expr, $($arg:tt)*) => (); [INFO] [stderr] 64 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/config.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | / arg_enum! { [INFO] [stderr] 11 | | #[derive(Debug)] [INFO] [stderr] 12 | | pub enum Utf8Rule { [INFO] [stderr] 13 | | Ignore, [INFO] [stderr] ... | [INFO] [stderr] 16 | | } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/config.rs:36:24 [INFO] [stderr] | [INFO] [stderr] 36 | if let None = Language::from_ext(e) { [INFO] [stderr] | _________________- ^^^^ [INFO] [stderr] 37 | | return Err(CliError::UnknownExt(format!("unsupported source code extension \ [INFO] [stderr] 38 | | '{}'", [INFO] [stderr] 39 | | e.to_owned()))); [INFO] [stderr] 40 | | } [INFO] [stderr] | |_________________- help: try this: `if Language::from_ext(e).is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/count/counts.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | / pub fn count(&mut self) -> CliResult<()> { [INFO] [stderr] 105 | | for count in self.counts.iter_mut() { [INFO] [stderr] 106 | | debugln!("iter; count={:?};", count); [INFO] [stderr] 107 | | let re = if let Some(kw) = count.lang.unsafe_keyword() { [INFO] [stderr] ... | [INFO] [stderr] 267 | | Ok(()) [INFO] [stderr] 268 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/count/counts.rs:110:28 [INFO] [stderr] | [INFO] [stderr] 110 | Regex::new("").unwrap() [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: the regex is unlikely to be useful as it is [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/count/counts.rs:330:20 [INFO] [stderr] | [INFO] [stderr] 330 | String::from_utf8(w.unwrap()).ok().expect("failed to get valid UTF-8 String")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.32s [INFO] running `"docker" "inspect" "83c0c7c02371545ab1751fc2acf40a37c18c3cbe25baa9f89948745277df51e8"` [INFO] running `"docker" "rm" "-f" "83c0c7c02371545ab1751fc2acf40a37c18c3cbe25baa9f89948745277df51e8"` [INFO] [stdout] 83c0c7c02371545ab1751fc2acf40a37c18c3cbe25baa9f89948745277df51e8