[INFO] crate cargo-contribute 0.2.2 is already in cache [INFO] extracting crate cargo-contribute 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/cargo-contribute/0.2.2 [INFO] extracting crate cargo-contribute 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-contribute/0.2.2 [INFO] validating manifest of cargo-contribute-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cargo-contribute-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cargo-contribute-0.2.2 [INFO] finished frobbing cargo-contribute-0.2.2 [INFO] frobbed toml for cargo-contribute-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/cargo-contribute/0.2.2/Cargo.toml [INFO] started frobbing cargo-contribute-0.2.2 [INFO] finished frobbing cargo-contribute-0.2.2 [INFO] frobbed toml for cargo-contribute-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-contribute/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cargo-contribute-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cargo-contribute/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 02106ea1b1f932d258cb27a2e866f70d5d5adcf6b72d39320146cea865e51ed9 [INFO] running `"docker" "start" "-a" "02106ea1b1f932d258cb27a2e866f70d5d5adcf6b72d39320146cea865e51ed9"` [INFO] [stderr] Checking hubcaps v0.4.10 [INFO] [stderr] Checking cargo-contribute v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/args.rs:136:27 [INFO] [stderr] | [INFO] [stderr] 136 | const OPT_MANIFEST_PATH: &'static str = "manifest-path"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/args.rs:137:19 [INFO] [stderr] | [INFO] [stderr] 137 | const OPT_COUNT: &'static str = "count"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/args.rs:138:26 [INFO] [stderr] | [INFO] [stderr] 138 | const OPT_GITHUB_TOKEN: &'static str = "github-token"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/args.rs:139:20 [INFO] [stderr] | [INFO] [stderr] 139 | const OPT_FORMAT: &'static str = "format"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/args.rs:140:21 [INFO] [stderr] | [INFO] [stderr] 140 | const OPT_VERBOSE: &'static str = "verbose"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/args.rs:141:19 [INFO] [stderr] | [INFO] [stderr] 141 | const OPT_QUIET: &'static str = "quiet"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/issues/crates_io.rs:17:18 [INFO] [stderr] | [INFO] [stderr] 17 | const API_ROOT: &'static str = "https://crates.io/api/v1/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/issues/producer.rs:255:25 [INFO] [stderr] | [INFO] [stderr] 255 | const GITHUB_API_ROOT: &'static str = "https://api.github.com"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/issues/producer.rs:259:22 [INFO] [stderr] | [INFO] [stderr] 259 | const ISSUE_LABELS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/issues/producer.rs:259:32 [INFO] [stderr] | [INFO] [stderr] 259 | const ISSUE_LABELS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/logging.rs:27:35 [INFO] [stderr] | [INFO] [stderr] 27 | const POSITIVE_VERBOSITY_LEVELS: &'static [FilterLevel] = &[ [INFO] [stderr] | -^^^^^^^-------------- help: consider removing `'static`: `&[FilterLevel]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/logging.rs:32:35 [INFO] [stderr] | [INFO] [stderr] 32 | const NEGATIVE_VERBOSITY_LEVELS: &'static [FilterLevel] = &[ [INFO] [stderr] | -^^^^^^^-------------- help: consider removing `'static`: `&[FilterLevel]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/logging.rs:42:29 [INFO] [stderr] | [INFO] [stderr] 42 | const SQUELCHED_LIBRARIES: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/logging.rs:42:39 [INFO] [stderr] | [INFO] [stderr] 42 | const SQUELCHED_LIBRARIES: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/logging.rs:161:32 [INFO] [stderr] | [INFO] [stderr] 161 | const NANOS_IN_MILLISEC: u32 = 1000000; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/model/github.rs:9:21 [INFO] [stderr] | [INFO] [stderr] 9 | const GITHUB_HOST: &'static str = "github.com"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/issues/producer.rs:145:60 [INFO] [stderr] | [INFO] [stderr] 145 | static ref CARGO_REGISTRY_CACHE_DIR: Option = env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/args.rs:136:27 [INFO] [stderr] | [INFO] [stderr] 136 | const OPT_MANIFEST_PATH: &'static str = "manifest-path"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/args.rs:137:19 [INFO] [stderr] | [INFO] [stderr] 137 | const OPT_COUNT: &'static str = "count"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/args.rs:138:26 [INFO] [stderr] | [INFO] [stderr] 138 | const OPT_GITHUB_TOKEN: &'static str = "github-token"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/args.rs:139:20 [INFO] [stderr] | [INFO] [stderr] 139 | const OPT_FORMAT: &'static str = "format"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/args.rs:140:21 [INFO] [stderr] | [INFO] [stderr] 140 | const OPT_VERBOSE: &'static str = "verbose"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/args.rs:141:19 [INFO] [stderr] | [INFO] [stderr] 141 | const OPT_QUIET: &'static str = "quiet"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/issues/crates_io.rs:17:18 [INFO] [stderr] | [INFO] [stderr] 17 | const API_ROOT: &'static str = "https://crates.io/api/v1/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/issues/producer.rs:255:25 [INFO] [stderr] | [INFO] [stderr] 255 | const GITHUB_API_ROOT: &'static str = "https://api.github.com"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/issues/producer.rs:259:22 [INFO] [stderr] | [INFO] [stderr] 259 | const ISSUE_LABELS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/issues/producer.rs:259:32 [INFO] [stderr] | [INFO] [stderr] 259 | const ISSUE_LABELS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/logging.rs:27:35 [INFO] [stderr] | [INFO] [stderr] 27 | const POSITIVE_VERBOSITY_LEVELS: &'static [FilterLevel] = &[ [INFO] [stderr] | -^^^^^^^-------------- help: consider removing `'static`: `&[FilterLevel]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/logging.rs:32:35 [INFO] [stderr] | [INFO] [stderr] 32 | const NEGATIVE_VERBOSITY_LEVELS: &'static [FilterLevel] = &[ [INFO] [stderr] | -^^^^^^^-------------- help: consider removing `'static`: `&[FilterLevel]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/logging.rs:42:29 [INFO] [stderr] | [INFO] [stderr] 42 | const SQUELCHED_LIBRARIES: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/logging.rs:42:39 [INFO] [stderr] | [INFO] [stderr] 42 | const SQUELCHED_LIBRARIES: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/logging.rs:161:32 [INFO] [stderr] | [INFO] [stderr] 161 | const NANOS_IN_MILLISEC: u32 = 1000000; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/model/github.rs:9:21 [INFO] [stderr] | [INFO] [stderr] 9 | const GITHUB_HOST: &'static str = "github.com"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/issues/producer.rs:145:60 [INFO] [stderr] | [INFO] [stderr] 145 | static ref CARGO_REGISTRY_CACHE_DIR: Option = env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/issues/crates_io.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn new(handle: &Handle) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new_tls` [INFO] [stderr] --> src/issues/crates_io.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn new_tls(handle: &Handle) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/args.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | / match self { [INFO] [stderr] 110 | | &ArgsError::Parse(ref e) => Some(e), [INFO] [stderr] 111 | | &ArgsError::Count(ref e) => Some(e), [INFO] [stderr] 112 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 109 | match *self { [INFO] [stderr] 110 | ArgsError::Parse(ref e) => Some(e), [INFO] [stderr] 111 | ArgsError::Count(ref e) => Some(e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/args.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | / match self { [INFO] [stderr] 118 | | &ArgsError::Parse(ref e) => write!(fmt, "parse error: {}", e), [INFO] [stderr] 119 | | &ArgsError::Count(ref e) => write!(fmt, "invalid --count value: {}", e), [INFO] [stderr] 120 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 117 | match *self { [INFO] [stderr] 118 | ArgsError::Parse(ref e) => write!(fmt, "parse error: {}", e), [INFO] [stderr] 119 | ArgsError::Count(ref e) => write!(fmt, "invalid --count value: {}", e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/issues/cargo_toml.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | / match &result { [INFO] [stderr] 44 | | &Ok(ref deps) => [INFO] [stderr] 45 | | debug!("{} dependencies found in {}",deps.len(), path.display()), [INFO] [stderr] 46 | | &Err(ref e) => [INFO] [stderr] 47 | | error!("Error while parsing dependencies in {}: {}", path.display(), e), [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 43 | match result { [INFO] [stderr] 44 | Ok(ref deps) => [INFO] [stderr] 45 | debug!("{} dependencies found in {}",deps.len(), path.display()), [INFO] [stderr] 46 | Err(ref e) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/issues/producer.rs:152:5 [INFO] [stderr] | [INFO] [stderr] 152 | / match dep.location() { [INFO] [stderr] 153 | | &CrateLocation::Registry{ref version} => { [INFO] [stderr] 154 | | // Check the local Cargo cache first for the dependent crate's manifest. [INFO] [stderr] 155 | | // Otherwise, fall back to querying crates.io. [INFO] [stderr] ... | [INFO] [stderr] 195 | | )), [INFO] [stderr] 196 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 152 | match *dep.location() { [INFO] [stderr] 153 | CrateLocation::Registry{ref version} => { [INFO] [stderr] 154 | // Check the local Cargo cache first for the dependent crate's manifest. [INFO] [stderr] 155 | // Otherwise, fall back to querying crates.io. [INFO] [stderr] 156 | if let Some(package) = find_cached_manifest(dep.name(), version) { [INFO] [stderr] 157 | return Box::new(future::ok( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/issues/producer.rs:221:25 [INFO] [stderr] | [INFO] [stderr] 221 | .rsplit("-").next().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/logging.rs:153:23 [INFO] [stderr] | [INFO] [stderr] 153 | let mut logtime = format!("{}", utc_now.to_rfc3339()); // E.g.: 2012-02-22T14:53:18Z [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `utc_now.to_rfc3339().to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new_tls` [INFO] [stderr] --> src/issues/crates_io.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn new_tls(handle: &Handle) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/args.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | / match self { [INFO] [stderr] 110 | | &ArgsError::Parse(ref e) => Some(e), [INFO] [stderr] 111 | | &ArgsError::Count(ref e) => Some(e), [INFO] [stderr] 112 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 109 | match *self { [INFO] [stderr] 110 | ArgsError::Parse(ref e) => Some(e), [INFO] [stderr] 111 | ArgsError::Count(ref e) => Some(e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/args.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | / match self { [INFO] [stderr] 118 | | &ArgsError::Parse(ref e) => write!(fmt, "parse error: {}", e), [INFO] [stderr] 119 | | &ArgsError::Count(ref e) => write!(fmt, "invalid --count value: {}", e), [INFO] [stderr] 120 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/model/manifest.rs:66:39 [INFO] [stderr] | [INFO] [stderr] 66 | VersionReq::parse(version.as_ref()).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try this: `version` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 117 | match *self { [INFO] [stderr] 118 | ArgsError::Parse(ref e) => write!(fmt, "parse error: {}", e), [INFO] [stderr] 119 | ArgsError::Count(ref e) => write!(fmt, "invalid --count value: {}", e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/model/manifest.rs:113:46 [INFO] [stderr] | [INFO] [stderr] 113 | _ => Err(toml::de::Error::custom(format!( [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 114 | | "dependency must specify `version`, `path`, or `git`"))), [INFO] [stderr] | |______________________________________________________________________^ help: consider using .to_string(): `"dependency must specify `version`, `path`, or `git`".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/model/manifest.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | match self { &CrateLocation::Registry{..} => true, _ => false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 169 | match *self { CrateLocation::Registry{..} => true, _ => false } [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/model/manifest.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | match self { &CrateLocation::Filesystem{..} => true, _ => false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 174 | match *self { CrateLocation::Filesystem{..} => true, _ => false } [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/model/manifest.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | match self { &CrateLocation::Git{..} => true, _ => false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 179 | match *self { CrateLocation::Git{..} => true, _ => false } [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:133:30 [INFO] [stderr] | [INFO] [stderr] 133 | .map(|p| p as &Path).unwrap_or(Path::new("./Cargo.toml")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Path::new("./Cargo.toml"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:138:25 [INFO] [stderr] | [INFO] [stderr] 138 | None => format!("; make sure you're in the crate root directory."), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"; make sure you're in the crate root directory.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/issues/cargo_toml.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | / match &result { [INFO] [stderr] 44 | | &Ok(ref deps) => [INFO] [stderr] 45 | | debug!("{} dependencies found in {}",deps.len(), path.display()), [INFO] [stderr] 46 | | &Err(ref e) => [INFO] [stderr] 47 | | error!("Error while parsing dependencies in {}: {}", path.display(), e), [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 43 | match result { [INFO] [stderr] 44 | Ok(ref deps) => [INFO] [stderr] 45 | debug!("{} dependencies found in {}",deps.len(), path.display()), [INFO] [stderr] 46 | Err(ref e) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/issues/producer.rs:152:5 [INFO] [stderr] | [INFO] [stderr] 152 | / match dep.location() { [INFO] [stderr] 153 | | &CrateLocation::Registry{ref version} => { [INFO] [stderr] 154 | | // Check the local Cargo cache first for the dependent crate's manifest. [INFO] [stderr] 155 | | // Otherwise, fall back to querying crates.io. [INFO] [stderr] ... | [INFO] [stderr] 195 | | )), [INFO] [stderr] 196 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 152 | match *dep.location() { [INFO] [stderr] 153 | CrateLocation::Registry{ref version} => { [INFO] [stderr] 154 | // Check the local Cargo cache first for the dependent crate's manifest. [INFO] [stderr] 155 | // Otherwise, fall back to querying crates.io. [INFO] [stderr] 156 | if let Some(package) = find_cached_manifest(dep.name(), version) { [INFO] [stderr] 157 | return Box::new(future::ok( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/issues/producer.rs:221:25 [INFO] [stderr] | [INFO] [stderr] 221 | .rsplit("-").next().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/issues/producer.rs:305:21 [INFO] [stderr] | [INFO] [stderr] 305 | assert!(label == &canonicalize_label(label)); [INFO] [stderr] | ^^^^^^^^^-------------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `canonicalize_label(label)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/logging.rs:153:23 [INFO] [stderr] | [INFO] [stderr] 153 | let mut logtime = format!("{}", utc_now.to_rfc3339()); // E.g.: 2012-02-22T14:53:18Z [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `utc_now.to_rfc3339().to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/model/manifest.rs:66:39 [INFO] [stderr] | [INFO] [stderr] 66 | VersionReq::parse(version.as_ref()).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try this: `version` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/model/manifest.rs:113:46 [INFO] [stderr] | [INFO] [stderr] 113 | _ => Err(toml::de::Error::custom(format!( [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 114 | | "dependency must specify `version`, `path`, or `git`"))), [INFO] [stderr] | |______________________________________________________________________^ help: consider using .to_string(): `"dependency must specify `version`, `path`, or `git`".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/model/manifest.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | match self { &CrateLocation::Registry{..} => true, _ => false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 169 | match *self { CrateLocation::Registry{..} => true, _ => false } [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/model/manifest.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | match self { &CrateLocation::Filesystem{..} => true, _ => false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 174 | match *self { CrateLocation::Filesystem{..} => true, _ => false } [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/model/manifest.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | match self { &CrateLocation::Git{..} => true, _ => false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 179 | match *self { CrateLocation::Git{..} => true, _ => false } [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:133:30 [INFO] [stderr] | [INFO] [stderr] 133 | .map(|p| p as &Path).unwrap_or(Path::new("./Cargo.toml")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Path::new("./Cargo.toml"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:138:25 [INFO] [stderr] | [INFO] [stderr] 138 | None => format!("; make sure you're in the crate root directory."), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"; make sure you're in the crate root directory.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 29.73s [INFO] running `"docker" "inspect" "02106ea1b1f932d258cb27a2e866f70d5d5adcf6b72d39320146cea865e51ed9"` [INFO] running `"docker" "rm" "-f" "02106ea1b1f932d258cb27a2e866f70d5d5adcf6b72d39320146cea865e51ed9"` [INFO] [stdout] 02106ea1b1f932d258cb27a2e866f70d5d5adcf6b72d39320146cea865e51ed9