[INFO] crate cargo-cleanup 0.1.2 is already in cache [INFO] extracting crate cargo-cleanup 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/cargo-cleanup/0.1.2 [INFO] extracting crate cargo-cleanup 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-cleanup/0.1.2 [INFO] validating manifest of cargo-cleanup-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cargo-cleanup-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cargo-cleanup-0.1.2 [INFO] finished frobbing cargo-cleanup-0.1.2 [INFO] frobbed toml for cargo-cleanup-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/cargo-cleanup/0.1.2/Cargo.toml [INFO] started frobbing cargo-cleanup-0.1.2 [INFO] finished frobbing cargo-cleanup-0.1.2 [INFO] frobbed toml for cargo-cleanup-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-cleanup/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cargo-cleanup-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cargo-cleanup/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 37fe4a3804c0b85125a6b6118ef9ad619a43f93a36dcac47fc775a2e4a18a94d [INFO] running `"docker" "start" "-a" "37fe4a3804c0b85125a6b6118ef9ad619a43f93a36dcac47fc775a2e4a18a94d"` [INFO] [stderr] Checking cargo-cleanup v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:17:19 [INFO] [stderr] | [INFO] [stderr] 17 | const CRATE_SRC: &'static str = "registry+https://github.com/rust-lang/crates.io-index"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:17:19 [INFO] [stderr] | [INFO] [stderr] 17 | const CRATE_SRC: &'static str = "registry+https://github.com/rust-lang/crates.io-index"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:30:28 [INFO] [stderr] | [INFO] [stderr] 30 | let file = args.next().unwrap_or(String::from("Cargo.lock")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("Cargo.lock"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:55:60 [INFO] [stderr] | [INFO] [stderr] 55 | version_map.entry(one_package.name.to_owned()).or_insert(HashSet::new()).insert(one_package.version.to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | / for entry in cache.filter_entry(|e| e.file_type().is_dir()) { [INFO] [stderr] 87 | | src.push("src"); [INFO] [stderr] 88 | | src.push(entry?.path().file_name().map(OsStr::to_str).unwrap_or(None).ok_or("registry/cache")?); [INFO] [stderr] 89 | | break; [INFO] [stderr] 90 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `cargo-cleanup`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:30:28 [INFO] [stderr] | [INFO] [stderr] 30 | let file = args.next().unwrap_or(String::from("Cargo.lock")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("Cargo.lock"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:55:60 [INFO] [stderr] | [INFO] [stderr] 55 | version_map.entry(one_package.name.to_owned()).or_insert(HashSet::new()).insert(one_package.version.to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | / for entry in cache.filter_entry(|e| e.file_type().is_dir()) { [INFO] [stderr] 87 | | src.push("src"); [INFO] [stderr] 88 | | src.push(entry?.path().file_name().map(OsStr::to_str).unwrap_or(None).ok_or("registry/cache")?); [INFO] [stderr] 89 | | break; [INFO] [stderr] 90 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `cargo-cleanup`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "37fe4a3804c0b85125a6b6118ef9ad619a43f93a36dcac47fc775a2e4a18a94d"` [INFO] running `"docker" "rm" "-f" "37fe4a3804c0b85125a6b6118ef9ad619a43f93a36dcac47fc775a2e4a18a94d"` [INFO] [stdout] 37fe4a3804c0b85125a6b6118ef9ad619a43f93a36dcac47fc775a2e4a18a94d