[INFO] crate cargo-cargo-derive-ipc-schema-for-swift 0.1.0 is already in cache
[INFO] extracting crate cargo-cargo-derive-ipc-schema-for-swift 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/cargo-cargo-derive-ipc-schema-for-swift/0.1.0
[INFO] extracting crate cargo-cargo-derive-ipc-schema-for-swift 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-cargo-derive-ipc-schema-for-swift/0.1.0
[INFO] validating manifest of cargo-cargo-derive-ipc-schema-for-swift-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of cargo-cargo-derive-ipc-schema-for-swift-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing cargo-cargo-derive-ipc-schema-for-swift-0.1.0
[INFO] finished frobbing cargo-cargo-derive-ipc-schema-for-swift-0.1.0
[INFO] frobbed toml for cargo-cargo-derive-ipc-schema-for-swift-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/cargo-cargo-derive-ipc-schema-for-swift/0.1.0/Cargo.toml
[INFO] started frobbing cargo-cargo-derive-ipc-schema-for-swift-0.1.0
[INFO] finished frobbing cargo-cargo-derive-ipc-schema-for-swift-0.1.0
[INFO] frobbed toml for cargo-cargo-derive-ipc-schema-for-swift-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-cargo-derive-ipc-schema-for-swift/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting cargo-cargo-derive-ipc-schema-for-swift-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cargo-cargo-derive-ipc-schema-for-swift/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 30483e08d51a44d5a9252e10505f37b0c59c0f70b41955797a0dd25fdd87184e
[INFO] running `"docker" "start" "-a" "30483e08d51a44d5a9252e10505f37b0c59c0f70b41955797a0dd25fdd87184e"`
[INFO] [stderr]     Checking cargo-cargo-derive-ipc-schema-for-swift v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/schema/analysis.rs:27:17
[INFO] [stderr]    |
[INFO] [stderr] 27 |             let n = ast_item.ident.to_string();
[INFO] [stderr]    |                 ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/schema/analysis.rs:27:17
[INFO] [stderr]    |
[INFO] [stderr] 27 |             let n = ast_item.ident.to_string();
[INFO] [stderr]    |                 ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/schema/conv.rs:12:23
[INFO] [stderr]    |
[INFO] [stderr] 12 |             None => { return None; },
[INFO] [stderr]    |                       ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/schema/conv.rs:26:17
[INFO] [stderr]    |
[INFO] [stderr] 26 |                 return Some(kty);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(kty)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/schema/conv.rs:38:9
[INFO] [stderr]    |
[INFO] [stderr] 38 | /         return match self.get_path() {
[INFO] [stderr] 39 | |             None        => None,
[INFO] [stderr] 40 | |             Some(ref p) => match &p.segments.last() {
[INFO] [stderr] 41 | |                 None        => None,
[INFO] [stderr] 42 | |                 Some(ref s) => Some(s),
[INFO] [stderr] 43 | |             },
[INFO] [stderr] 44 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 38 |         match self.get_path() {
[INFO] [stderr] 39 |             None        => None,
[INFO] [stderr] 40 |             Some(ref p) => match &p.segments.last() {
[INFO] [stderr] 41 |                 None        => None,
[INFO] [stderr] 42 |                 Some(ref s) => Some(s),
[INFO] [stderr] 43 |             },
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/schema/conv.rs:47:9
[INFO] [stderr]    |
[INFO] [stderr] 47 | /         return match &self.node {
[INFO] [stderr] 48 | |             ast::TyKind::Path(_, ref p) => Some(p),
[INFO] [stderr] 49 | |             _ => None,
[INFO] [stderr] 50 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 47 |         match &self.node {
[INFO] [stderr] 48 |             ast::TyKind::Path(_, ref p) => Some(p),
[INFO] [stderr] 49 |             _ => None,
[INFO] [stderr] 50 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/schema/conv.rs:61:9
[INFO] [stderr]    |
[INFO] [stderr] 61 |         return Type::from_ast_ty(&ast_ty);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Type::from_ast_ty(&ast_ty)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/schema/conv.rs:68:9
[INFO] [stderr]    |
[INFO] [stderr] 68 | /         return match pps {
[INFO] [stderr] 69 | |             ast::Parenthesized(ref pd) => None, 
[INFO] [stderr] 70 | |             ast::AngleBracketed(ref pd) => Some(pd.types.get(i)? as &ast::Ty),
[INFO] [stderr] 71 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 68 |         match pps {
[INFO] [stderr] 69 |             ast::Parenthesized(ref pd) => None, 
[INFO] [stderr] 70 |             ast::AngleBracketed(ref pd) => Some(pd.types.get(i)? as &ast::Ty),
[INFO] [stderr] 71 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/schema/analysis.rs:56:5
[INFO] [stderr]    |
[INFO] [stderr] 56 |     return kmod;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `kmod`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/schema/analysis.rs:67:5
[INFO] [stderr]    |
[INFO] [stderr] 67 |     return Some(kitem);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(kitem)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/schema/analysis.rs:78:5
[INFO] [stderr]    |
[INFO] [stderr] 78 |     return kenum;
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `kenum`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/schema/analysis.rs:72:9
[INFO] [stderr]    |
[INFO] [stderr] 72 |         return simplify_enum_variant(&v.node);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `simplify_enum_variant(&v.node)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/schema/analysis.rs:87:5
[INFO] [stderr]    |
[INFO] [stderr] 87 |     return kvariant;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `kvariant`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/schema/analysis.rs:95:5
[INFO] [stderr]    |
[INFO] [stderr] 95 |     return kstruct;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `kstruct`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/schema/analysis.rs:118:5
[INFO] [stderr]     |
[INFO] [stderr] 118 |     return ksfs;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `ksfs`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/schema/analysis.rs:131:5
[INFO] [stderr]     |
[INFO] [stderr] 131 |     return Some(kfield);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(kfield)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/schema/analysis.rs:142:9
[INFO] [stderr]     |
[INFO] [stderr] 142 |         return IndentedPrinter { depth: 0, buffer: "".to_string() };
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `IndentedPrinter { depth: 0, buffer: "".to_string() }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/schema/codegen.rs:14:9
[INFO] [stderr]    |
[INFO] [stderr] 14 |         return ss.join("\n\n\n");
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ss.join("\n\n\n")`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/schema/codegen.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         return s;
[INFO] [stderr]    |         ^^^^^^^^^ help: remove `return` as shown: `s`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/schema/codegen.rs:44:9
[INFO] [stderr]    |
[INFO] [stderr] 44 |         return s;
[INFO] [stderr]    |         ^^^^^^^^^ help: remove `return` as shown: `s`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/schema/codegen.rs:55:9
[INFO] [stderr]    |
[INFO] [stderr] 55 |         return s;
[INFO] [stderr]    |         ^^^^^^^^^ help: remove `return` as shown: `s`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/schema/codegen.rs:97:9
[INFO] [stderr]    |
[INFO] [stderr] 97 |         return s;
[INFO] [stderr]    |         ^^^^^^^^^ help: remove `return` as shown: `s`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/schema/codegen.rs:132:9
[INFO] [stderr]     |
[INFO] [stderr] 132 |         return s;
[INFO] [stderr]     |         ^^^^^^^^^ help: remove `return` as shown: `s`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/schema/codegen.rs:165:9
[INFO] [stderr]     |
[INFO] [stderr] 165 |         return s;
[INFO] [stderr]     |         ^^^^^^^^^ help: remove `return` as shown: `s`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/schema/codegen.rs:186:9
[INFO] [stderr]     |
[INFO] [stderr] 186 |         return s;
[INFO] [stderr]     |         ^^^^^^^^^ help: remove `return` as shown: `s`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/schema/codegen.rs:206:9
[INFO] [stderr]     |
[INFO] [stderr] 206 |         return s;
[INFO] [stderr]     |         ^^^^^^^^^ help: remove `return` as shown: `s`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/schema/codegen.rs:231:9
[INFO] [stderr]     |
[INFO] [stderr] 231 |         return s;
[INFO] [stderr]     |         ^^^^^^^^^ help: remove `return` as shown: `s`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/schema/codegen.rs:240:9
[INFO] [stderr]     |
[INFO] [stderr] 240 | /         return match self {
[INFO] [stderr] 241 | |             Type::Bool => "Bool".to_string(),
[INFO] [stderr] 242 | |             Type::I64 => "Int64".to_string(),
[INFO] [stderr] 243 | |             Type::F64 => "Float64".to_string(),
[INFO] [stderr] ...   |
[INFO] [stderr] 247 | |             Type::Vec(ref ty) => ["Array<", &ty.gen_swift_code(), ">"].join(""),
[INFO] [stderr] 248 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 240 |         match self {
[INFO] [stderr] 241 |             Type::Bool => "Bool".to_string(),
[INFO] [stderr] 242 |             Type::I64 => "Int64".to_string(),
[INFO] [stderr] 243 |             Type::F64 => "Float64".to_string(),
[INFO] [stderr] 244 |             Type::String => "String".to_string(),
[INFO] [stderr] 245 |             Type::Item(ref name) => name.to_string(),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/schema/conv.rs:12:23
[INFO] [stderr]    |
[INFO] [stderr] 12 |             None => { return None; },
[INFO] [stderr]    |                       ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/schema/conv.rs:26:17
[INFO] [stderr]    |
[INFO] [stderr] 26 |                 return Some(kty);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(kty)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/schema/conv.rs:38:9
[INFO] [stderr]    |
[INFO] [stderr] 38 | /         return match self.get_path() {
[INFO] [stderr] 39 | |             None        => None,
[INFO] [stderr] 40 | |             Some(ref p) => match &p.segments.last() {
[INFO] [stderr] 41 | |                 None        => None,
[INFO] [stderr] 42 | |                 Some(ref s) => Some(s),
[INFO] [stderr] 43 | |             },
[INFO] [stderr] 44 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 38 |         match self.get_path() {
[INFO] [stderr] 39 |             None        => None,
[INFO] [stderr] 40 |             Some(ref p) => match &p.segments.last() {
[INFO] [stderr] 41 |                 None        => None,
[INFO] [stderr] 42 |                 Some(ref s) => Some(s),
[INFO] [stderr] 43 |             },
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/schema/conv.rs:47:9
[INFO] [stderr]    |
[INFO] [stderr] 47 | /         return match &self.node {
[INFO] [stderr] 48 | |             ast::TyKind::Path(_, ref p) => Some(p),
[INFO] [stderr] 49 | |             _ => None,
[INFO] [stderr] 50 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 47 |         match &self.node {
[INFO] [stderr] 48 |             ast::TyKind::Path(_, ref p) => Some(p),
[INFO] [stderr] 49 |             _ => None,
[INFO] [stderr] 50 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/schema/conv.rs:61:9
[INFO] [stderr]    |
[INFO] [stderr] 61 |         return Type::from_ast_ty(&ast_ty);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Type::from_ast_ty(&ast_ty)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/schema/conv.rs:68:9
[INFO] [stderr]    |
[INFO] [stderr] 68 | /         return match pps {
[INFO] [stderr] 69 | |             ast::Parenthesized(ref pd) => None, 
[INFO] [stderr] 70 | |             ast::AngleBracketed(ref pd) => Some(pd.types.get(i)? as &ast::Ty),
[INFO] [stderr] 71 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 68 |         match pps {
[INFO] [stderr] 69 |             ast::Parenthesized(ref pd) => None, 
[INFO] [stderr] 70 |             ast::AngleBracketed(ref pd) => Some(pd.types.get(i)? as &ast::Ty),
[INFO] [stderr] 71 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/schema/analysis.rs:56:5
[INFO] [stderr]    |
[INFO] [stderr] 56 |     return kmod;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `kmod`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/schema/analysis.rs:67:5
[INFO] [stderr]    |
[INFO] [stderr] 67 |     return Some(kitem);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(kitem)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/schema/analysis.rs:78:5
[INFO] [stderr]    |
[INFO] [stderr] 78 |     return kenum;
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `kenum`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/schema/analysis.rs:72:9
[INFO] [stderr]    |
[INFO] [stderr] 72 |         return simplify_enum_variant(&v.node);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `simplify_enum_variant(&v.node)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/schema/analysis.rs:87:5
[INFO] [stderr]    |
[INFO] [stderr] 87 |     return kvariant;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `kvariant`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/schema/analysis.rs:95:5
[INFO] [stderr]    |
[INFO] [stderr] 95 |     return kstruct;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `kstruct`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/schema/analysis.rs:118:5
[INFO] [stderr]     |
[INFO] [stderr] 118 |     return ksfs;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `ksfs`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/schema/analysis.rs:131:5
[INFO] [stderr]     |
[INFO] [stderr] 131 |     return Some(kfield);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(kfield)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/schema/analysis.rs:142:9
[INFO] [stderr]     |
[INFO] [stderr] 142 |         return IndentedPrinter { depth: 0, buffer: "".to_string() };
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `IndentedPrinter { depth: 0, buffer: "".to_string() }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/schema/codegen.rs:14:9
[INFO] [stderr]    |
[INFO] [stderr] 14 |         return ss.join("\n\n\n");
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ss.join("\n\n\n")`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/schema/codegen.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         return s;
[INFO] [stderr]    |         ^^^^^^^^^ help: remove `return` as shown: `s`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/schema/codegen.rs:44:9
[INFO] [stderr]    |
[INFO] [stderr] 44 |         return s;
[INFO] [stderr]    |         ^^^^^^^^^ help: remove `return` as shown: `s`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/schema/codegen.rs:55:9
[INFO] [stderr]    |
[INFO] [stderr] 55 |         return s;
[INFO] [stderr]    |         ^^^^^^^^^ help: remove `return` as shown: `s`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/schema/codegen.rs:97:9
[INFO] [stderr]    |
[INFO] [stderr] 97 |         return s;
[INFO] [stderr]    |         ^^^^^^^^^ help: remove `return` as shown: `s`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/schema/codegen.rs:132:9
[INFO] [stderr]     |
[INFO] [stderr] 132 |         return s;
[INFO] [stderr]     |         ^^^^^^^^^ help: remove `return` as shown: `s`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/schema/codegen.rs:165:9
[INFO] [stderr]     |
[INFO] [stderr] 165 |         return s;
[INFO] [stderr]     |         ^^^^^^^^^ help: remove `return` as shown: `s`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/schema/codegen.rs:186:9
[INFO] [stderr]     |
[INFO] [stderr] 186 |         return s;
[INFO] [stderr]     |         ^^^^^^^^^ help: remove `return` as shown: `s`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/schema/codegen.rs:206:9
[INFO] [stderr]     |
[INFO] [stderr] 206 |         return s;
[INFO] [stderr]     |         ^^^^^^^^^ help: remove `return` as shown: `s`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/schema/codegen.rs:231:9
[INFO] [stderr]     |
[INFO] [stderr] 231 |         return s;
[INFO] [stderr]     |         ^^^^^^^^^ help: remove `return` as shown: `s`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/schema/codegen.rs:240:9
[INFO] [stderr]     |
[INFO] [stderr] 240 | /         return match self {
[INFO] [stderr] 241 | |             Type::Bool => "Bool".to_string(),
[INFO] [stderr] 242 | |             Type::I64 => "Int64".to_string(),
[INFO] [stderr] 243 | |             Type::F64 => "Float64".to_string(),
[INFO] [stderr] ...   |
[INFO] [stderr] 247 | |             Type::Vec(ref ty) => ["Array<", &ty.gen_swift_code(), ">"].join(""),
[INFO] [stderr] 248 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 240 |         match self {
[INFO] [stderr] 241 |             Type::Bool => "Bool".to_string(),
[INFO] [stderr] 242 |             Type::I64 => "Int64".to_string(),
[INFO] [stderr] 243 |             Type::F64 => "Float64".to_string(),
[INFO] [stderr] 244 |             Type::String => "String".to_string(),
[INFO] [stderr] 245 |             Type::Item(ref name) => name.to_string(),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]   --> src/to_swift.rs:4:1
[INFO] [stderr]    |
[INFO] [stderr] 4  | / pub mod to_swift {
[INFO] [stderr] 5  | |
[INFO] [stderr] 6  | |     pub mod exampl1 {
[INFO] [stderr] 7  | |         pub mod example2 {
[INFO] [stderr] ...  |
[INFO] [stderr] 25 | |
[INFO] [stderr] 26 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: use as_ref() instead
[INFO] [stderr]   --> src/schema/conv.rs:40:28
[INFO] [stderr]    |
[INFO] [stderr] 40 |               Some(ref p) => match &p.segments.last() {
[INFO] [stderr]    |  ____________________________^
[INFO] [stderr] 41 | |                 None        => None,
[INFO] [stderr] 42 | |                 Some(ref s) => Some(s),
[INFO] [stderr] 43 | |             },
[INFO] [stderr]    | |_____________^ help: try this: `&p.segments.last().as_ref()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_as_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_as_ref
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/schema/analysis.rs:26:13
[INFO] [stderr]    |
[INFO] [stderr] 26 |         for ref ast_item in &ast_root_mod.items {
[INFO] [stderr]    |             ^^^^^^^^^^^^    ------------------- help: try: `let ast_item = &&ast_root_mod.items;`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/schema/analysis.rs:48:9
[INFO] [stderr]    |
[INFO] [stderr] 48 |     for ref item in &module.items {
[INFO] [stderr]    |         ^^^^^^^^    ------------- help: try: `let item = &&module.items;`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]   --> src/schema/analysis.rs:61:17
[INFO] [stderr]    |
[INFO] [stderr] 61 |       let kitem = match &item.node {
[INFO] [stderr]    |  _________________^
[INFO] [stderr] 62 | |         &ast::ItemKind::Mod(ref m)               => Module(simplify_module(&name, &m)),
[INFO] [stderr] 63 | |         &ast::ItemKind::Enum(ref ed, ref gs)     => Enum(simplify_enum(&name, &ed, &gs)),
[INFO] [stderr] 64 | |         &ast::ItemKind::Struct(ref vd, ref gs)   => Struct(simplify_struct(&name, &vd, &gs)),
[INFO] [stderr] 65 | |         _                                   => { return None; },
[INFO] [stderr] 66 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 61 |     let kitem = match item.node {
[INFO] [stderr] 62 |         ast::ItemKind::Mod(ref m)               => Module(simplify_module(&name, &m)),
[INFO] [stderr] 63 |         ast::ItemKind::Enum(ref ed, ref gs)     => Enum(simplify_enum(&name, &ed, &gs)),
[INFO] [stderr] 64 |         ast::ItemKind::Struct(ref vd, ref gs)   => Struct(simplify_struct(&name, &vd, &gs)),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/schema/analysis.rs:101:17
[INFO] [stderr]     |
[INFO] [stderr] 101 |             for ref ast_sf in ast_sfs {
[INFO] [stderr]     |                 ^^^^^^^^^^    ------- help: try: `let ast_sf = &ast_sfs;`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/schema/analysis.rs:108:17
[INFO] [stderr]     |
[INFO] [stderr] 108 |             for ref ast_sf in ast_sfs {
[INFO] [stderr]     |                 ^^^^^^^^^^    ------- help: try: `let ast_sf = &ast_sfs;`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: statement can be reduced
[INFO] [stderr]    --> src/schema/analysis.rs:147:13
[INFO] [stderr]     |
[INFO] [stderr] 147 |             &self.print_item(&item);
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.print_item(&item);`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_operation)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/schema/analysis.rs:154:9
[INFO] [stderr]     |
[INFO] [stderr] 154 | /         match &item.node {
[INFO] [stderr] 155 | |             &Mod(ref m) => self.print_module(&ident, &m),
[INFO] [stderr] 156 | |             &Enum(ref def, ref generics) => self.print_enum(&ident, &def, &generics),
[INFO] [stderr] 157 | |             &Struct(ref vd, ref gs) => self.print_struct(&ident, &vd, &gs),
[INFO] [stderr] 158 | |             _ => {},
[INFO] [stderr] 159 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 154 |         match item.node {
[INFO] [stderr] 155 |             Mod(ref m) => self.print_module(&ident, &m),
[INFO] [stderr] 156 |             Enum(ref def, ref generics) => self.print_enum(&ident, &def, &generics),
[INFO] [stderr] 157 |             Struct(ref vd, ref gs) => self.print_struct(&ident, &vd, &gs),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/schema/analysis.rs:162:39
[INFO] [stderr]     |
[INFO] [stderr] 162 |     fn print_module(&mut self, ident: &ast::Ident, module: &ast::Mod) {
[INFO] [stderr]     |                                       ^^^^^^^^^^^ help: consider passing by value instead: `ast::Ident`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/schema/analysis.rs:172:37
[INFO] [stderr]     |
[INFO] [stderr] 172 |     fn print_enum(&mut self, ident: &ast::Ident, def: &ast::EnumDef, generics: &ast::Generics) {
[INFO] [stderr]     |                                     ^^^^^^^^^^^ help: consider passing by value instead: `ast::Ident`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/schema/analysis.rs:177:39
[INFO] [stderr]     |
[INFO] [stderr] 177 |     fn print_struct(&mut self, ident: &ast::Ident, vd: &ast::VariantData, gs: &ast::Generics) {
[INFO] [stderr]     |                                       ^^^^^^^^^^^ help: consider passing by value instead: `ast::Ident`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/schema/analysis.rs:187:9
[INFO] [stderr]     |
[INFO] [stderr] 187 | /         match vd {
[INFO] [stderr] 188 | |             &Struct(ref fields, ref node_id) => self.print_fields(&fields),
[INFO] [stderr] 189 | |             &Tuple(ref fields, ref node_id) => self.print_fields(&fields),
[INFO] [stderr] 190 | |             &Unit(_) => {},
[INFO] [stderr] 191 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 187 |         match *vd {
[INFO] [stderr] 188 |             Struct(ref fields, ref node_id) => self.print_fields(&fields),
[INFO] [stderr] 189 |             Tuple(ref fields, ref node_id) => self.print_fields(&fields),
[INFO] [stderr] 190 |             Unit(_) => {},
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/schema/analysis.rs:193:40
[INFO] [stderr]     |
[INFO] [stderr] 193 |     fn print_fields(&mut self, fields: &Vec<ast::StructField>) {
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ast::StructField]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/schema/codegen.rs:79:16
[INFO] [stderr]    |
[INFO] [stderr] 79 |             if kvariant.fields.len() > 0 {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!kvariant.fields.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/schema/codegen.rs:92:16
[INFO] [stderr]    |
[INFO] [stderr] 92 |             if kvariant.fields.len() > 0 {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!kvariant.fields.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/schema/codegen.rs:107:16
[INFO] [stderr]     |
[INFO] [stderr] 107 |             if kvariant.fields.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!kvariant.fields.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/schema/codegen.rs:115:16
[INFO] [stderr]     |
[INFO] [stderr] 115 |             if kvariant.fields.len() == 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `kvariant.fields.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/schema/codegen.rs:146:16
[INFO] [stderr]     |
[INFO] [stderr] 146 |             if kvariant.fields.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!kvariant.fields.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `c` is used as a loop counter. Consider using `for (c, item) in &kvariant.fields.enumerate()` or similar iterators
[INFO] [stderr]    --> src/schema/codegen.rs:151:27
[INFO] [stderr]     |
[INFO] [stderr] 151 |             for kfield in &kvariant.fields {
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/schema/codegen.rs:194:13
[INFO] [stderr]     |
[INFO] [stderr] 194 |         for ref field in &self.fields {
[INFO] [stderr]     |             ^^^^^^^^^    ------------ help: try: `let field = &&self.fields;`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/schema/codegen.rs:218:13
[INFO] [stderr]     |
[INFO] [stderr] 218 |         for ref field in &self.fields {
[INFO] [stderr]     |             ^^^^^^^^^    ------------ help: try: `let field = &&self.fields;`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]   --> src/main.rs:18:9
[INFO] [stderr]    |
[INFO] [stderr] 18 |         Err(_) => {
[INFO] [stderr]    |         ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_wild_err_arm)] on by default
[INFO] [stderr]    = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: use as_ref() instead
[INFO] [stderr]   --> src/schema/conv.rs:40:28
[INFO] [stderr]    |
[INFO] [stderr] 40 |               Some(ref p) => match &p.segments.last() {
[INFO] [stderr]    |  ____________________________^
[INFO] [stderr] 41 | |                 None        => None,
[INFO] [stderr] 42 | |                 Some(ref s) => Some(s),
[INFO] [stderr] 43 | |             },
[INFO] [stderr]    | |_____________^ help: try this: `&p.segments.last().as_ref()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_as_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_as_ref
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/schema/analysis.rs:26:13
[INFO] [stderr]    |
[INFO] [stderr] 26 |         for ref ast_item in &ast_root_mod.items {
[INFO] [stderr]    |             ^^^^^^^^^^^^    ------------------- help: try: `let ast_item = &&ast_root_mod.items;`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/schema/analysis.rs:48:9
[INFO] [stderr]    |
[INFO] [stderr] 48 |     for ref item in &module.items {
[INFO] [stderr]    |         ^^^^^^^^    ------------- help: try: `let item = &&module.items;`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]   --> src/schema/analysis.rs:61:17
[INFO] [stderr]    |
[INFO] [stderr] 61 |       let kitem = match &item.node {
[INFO] [stderr]    |  _________________^
[INFO] [stderr] 62 | |         &ast::ItemKind::Mod(ref m)               => Module(simplify_module(&name, &m)),
[INFO] [stderr] 63 | |         &ast::ItemKind::Enum(ref ed, ref gs)     => Enum(simplify_enum(&name, &ed, &gs)),
[INFO] [stderr] 64 | |         &ast::ItemKind::Struct(ref vd, ref gs)   => Struct(simplify_struct(&name, &vd, &gs)),
[INFO] [stderr] 65 | |         _                                   => { return None; },
[INFO] [stderr] 66 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 61 |     let kitem = match item.node {
[INFO] [stderr] 62 |         ast::ItemKind::Mod(ref m)               => Module(simplify_module(&name, &m)),
[INFO] [stderr] 63 |         ast::ItemKind::Enum(ref ed, ref gs)     => Enum(simplify_enum(&name, &ed, &gs)),
[INFO] [stderr] 64 |         ast::ItemKind::Struct(ref vd, ref gs)   => Struct(simplify_struct(&name, &vd, &gs)),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/schema/analysis.rs:101:17
[INFO] [stderr]     |
[INFO] [stderr] 101 |             for ref ast_sf in ast_sfs {
[INFO] [stderr]     |                 ^^^^^^^^^^    ------- help: try: `let ast_sf = &ast_sfs;`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/schema/analysis.rs:108:17
[INFO] [stderr]     |
[INFO] [stderr] 108 |             for ref ast_sf in ast_sfs {
[INFO] [stderr]     |                 ^^^^^^^^^^    ------- help: try: `let ast_sf = &ast_sfs;`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: statement can be reduced
[INFO] [stderr]    --> src/schema/analysis.rs:147:13
[INFO] [stderr]     |
[INFO] [stderr] 147 |             &self.print_item(&item);
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.print_item(&item);`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_operation)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/schema/analysis.rs:154:9
[INFO] [stderr]     |
[INFO] [stderr] 154 | /         match &item.node {
[INFO] [stderr] 155 | |             &Mod(ref m) => self.print_module(&ident, &m),
[INFO] [stderr] 156 | |             &Enum(ref def, ref generics) => self.print_enum(&ident, &def, &generics),
[INFO] [stderr] 157 | |             &Struct(ref vd, ref gs) => self.print_struct(&ident, &vd, &gs),
[INFO] [stderr] 158 | |             _ => {},
[INFO] [stderr] 159 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 154 |         match item.node {
[INFO] [stderr] 155 |             Mod(ref m) => self.print_module(&ident, &m),
[INFO] [stderr] 156 |             Enum(ref def, ref generics) => self.print_enum(&ident, &def, &generics),
[INFO] [stderr] 157 |             Struct(ref vd, ref gs) => self.print_struct(&ident, &vd, &gs),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/schema/analysis.rs:162:39
[INFO] [stderr]     |
[INFO] [stderr] 162 |     fn print_module(&mut self, ident: &ast::Ident, module: &ast::Mod) {
[INFO] [stderr]     |                                       ^^^^^^^^^^^ help: consider passing by value instead: `ast::Ident`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/schema/analysis.rs:172:37
[INFO] [stderr]     |
[INFO] [stderr] 172 |     fn print_enum(&mut self, ident: &ast::Ident, def: &ast::EnumDef, generics: &ast::Generics) {
[INFO] [stderr]     |                                     ^^^^^^^^^^^ help: consider passing by value instead: `ast::Ident`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/schema/analysis.rs:177:39
[INFO] [stderr]     |
[INFO] [stderr] 177 |     fn print_struct(&mut self, ident: &ast::Ident, vd: &ast::VariantData, gs: &ast::Generics) {
[INFO] [stderr]     |                                       ^^^^^^^^^^^ help: consider passing by value instead: `ast::Ident`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/schema/analysis.rs:187:9
[INFO] [stderr]     |
[INFO] [stderr] 187 | /         match vd {
[INFO] [stderr] 188 | |             &Struct(ref fields, ref node_id) => self.print_fields(&fields),
[INFO] [stderr] 189 | |             &Tuple(ref fields, ref node_id) => self.print_fields(&fields),
[INFO] [stderr] 190 | |             &Unit(_) => {},
[INFO] [stderr] 191 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 187 |         match *vd {
[INFO] [stderr] 188 |             Struct(ref fields, ref node_id) => self.print_fields(&fields),
[INFO] [stderr] 189 |             Tuple(ref fields, ref node_id) => self.print_fields(&fields),
[INFO] [stderr] 190 |             Unit(_) => {},
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/schema/analysis.rs:193:40
[INFO] [stderr]     |
[INFO] [stderr] 193 |     fn print_fields(&mut self, fields: &Vec<ast::StructField>) {
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ast::StructField]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/schema/codegen.rs:79:16
[INFO] [stderr]    |
[INFO] [stderr] 79 |             if kvariant.fields.len() > 0 {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!kvariant.fields.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/schema/codegen.rs:92:16
[INFO] [stderr]    |
[INFO] [stderr] 92 |             if kvariant.fields.len() > 0 {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!kvariant.fields.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/schema/codegen.rs:107:16
[INFO] [stderr]     |
[INFO] [stderr] 107 |             if kvariant.fields.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!kvariant.fields.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/schema/codegen.rs:115:16
[INFO] [stderr]     |
[INFO] [stderr] 115 |             if kvariant.fields.len() == 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `kvariant.fields.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/schema/codegen.rs:146:16
[INFO] [stderr]     |
[INFO] [stderr] 146 |             if kvariant.fields.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!kvariant.fields.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `c` is used as a loop counter. Consider using `for (c, item) in &kvariant.fields.enumerate()` or similar iterators
[INFO] [stderr]    --> src/schema/codegen.rs:151:27
[INFO] [stderr]     |
[INFO] [stderr] 151 |             for kfield in &kvariant.fields {
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/schema/codegen.rs:194:13
[INFO] [stderr]     |
[INFO] [stderr] 194 |         for ref field in &self.fields {
[INFO] [stderr]     |             ^^^^^^^^^    ------------ help: try: `let field = &&self.fields;`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/schema/codegen.rs:218:13
[INFO] [stderr]     |
[INFO] [stderr] 218 |         for ref field in &self.fields {
[INFO] [stderr]     |             ^^^^^^^^^    ------------ help: try: `let field = &&self.fields;`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]   --> src/main.rs:18:9
[INFO] [stderr]    |
[INFO] [stderr] 18 |         Err(_) => {
[INFO] [stderr]    |         ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_wild_err_arm)] on by default
[INFO] [stderr]    = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.93s
[INFO] running `"docker" "inspect" "30483e08d51a44d5a9252e10505f37b0c59c0f70b41955797a0dd25fdd87184e"`
[INFO] running `"docker" "rm" "-f" "30483e08d51a44d5a9252e10505f37b0c59c0f70b41955797a0dd25fdd87184e"`
[INFO] [stdout] 30483e08d51a44d5a9252e10505f37b0c59c0f70b41955797a0dd25fdd87184e