[INFO] crate cargo-call-stack 0.1.0 is already in cache [INFO] extracting crate cargo-call-stack 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/cargo-call-stack/0.1.0 [INFO] extracting crate cargo-call-stack 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-call-stack/0.1.0 [INFO] validating manifest of cargo-call-stack-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cargo-call-stack-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cargo-call-stack-0.1.0 [INFO] finished frobbing cargo-call-stack-0.1.0 [INFO] frobbed toml for cargo-call-stack-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/cargo-call-stack/0.1.0/Cargo.toml [INFO] started frobbing cargo-call-stack-0.1.0 [INFO] finished frobbing cargo-call-stack-0.1.0 [INFO] frobbed toml for cargo-call-stack-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-call-stack/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cargo-call-stack-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cargo-call-stack/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] debe292011e43a1a8e2e7a2a2f26a78f030ebbde52b0b8ba2011c040d8c1c73d [INFO] running `"docker" "start" "-a" "debe292011e43a1a8e2e7a2a2f26a78f030ebbde52b0b8ba2011c040d8c1c73d"` [INFO] [stderr] Checking rustc_version v0.2.3 [INFO] [stderr] Checking rustc-cfg v0.4.0 [INFO] [stderr] Checking cargo-project v0.1.0 [INFO] [stderr] Checking cargo-project v0.2.1 [INFO] [stderr] Checking stack-sizes v0.2.0 [INFO] [stderr] Checking cargo-call-stack v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | / if p.extension().map(|e| e == "ll").unwrap_or(false) { [INFO] [stderr] 193 | | if p.file_stem() [INFO] [stderr] 194 | | .expect("unreachable") [INFO] [stderr] 195 | | .to_str() [INFO] [stderr] ... | [INFO] [stderr] 209 | | } [INFO] [stderr] 210 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 192 | if p.extension().map(|e| e == "ll").unwrap_or(false) && p.file_stem() [INFO] [stderr] 193 | .expect("unreachable") [INFO] [stderr] 194 | .to_str() [INFO] [stderr] 195 | .expect("unreachable") [INFO] [stderr] 196 | .starts_with(&prefix) { [INFO] [stderr] 197 | let modified = e.metadata()?.modified()?; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:203:24 [INFO] [stderr] | [INFO] [stderr] 203 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 204 | | if modified > mrm { [INFO] [stderr] 205 | | ll = Some(p); [INFO] [stderr] 206 | | mrm = modified; [INFO] [stderr] 207 | | } [INFO] [stderr] 208 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 203 | } else if modified > mrm { [INFO] [stderr] 204 | ll = Some(p); [INFO] [stderr] 205 | mrm = modified; [INFO] [stderr] 206 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | / if p.extension().map(|e| e == "ll").unwrap_or(false) { [INFO] [stderr] 193 | | if p.file_stem() [INFO] [stderr] 194 | | .expect("unreachable") [INFO] [stderr] 195 | | .to_str() [INFO] [stderr] ... | [INFO] [stderr] 209 | | } [INFO] [stderr] 210 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 192 | if p.extension().map(|e| e == "ll").unwrap_or(false) && p.file_stem() [INFO] [stderr] 193 | .expect("unreachable") [INFO] [stderr] 194 | .to_str() [INFO] [stderr] 195 | .expect("unreachable") [INFO] [stderr] 196 | .starts_with(&prefix) { [INFO] [stderr] 197 | let modified = e.metadata()?.modified()?; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:203:24 [INFO] [stderr] | [INFO] [stderr] 203 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 204 | | if modified > mrm { [INFO] [stderr] 205 | | ll = Some(p); [INFO] [stderr] 206 | | mrm = modified; [INFO] [stderr] 207 | | } [INFO] [stderr] 208 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 203 | } else if modified > mrm { [INFO] [stderr] 204 | ll = Some(p); [INFO] [stderr] 205 | mrm = modified; [INFO] [stderr] 206 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/main.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | / fn run() -> Result { [INFO] [stderr] 37 | | let matches = App::new("cargo-call-stack") [INFO] [stderr] 38 | | .version("1.0") [INFO] [stderr] 39 | | .author("Jorge Aparicio , Per Lindgren ") [INFO] [stderr] ... | [INFO] [stderr] 346 | | Ok(0) [INFO] [stderr] 347 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/main.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | / fn run() -> Result { [INFO] [stderr] 37 | | let matches = App::new("cargo-call-stack") [INFO] [stderr] 38 | | .version("1.0") [INFO] [stderr] 39 | | .author("Jorge Aparicio , Per Lindgren ") [INFO] [stderr] ... | [INFO] [stderr] 346 | | Ok(0) [INFO] [stderr] 347 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.68s [INFO] running `"docker" "inspect" "debe292011e43a1a8e2e7a2a2f26a78f030ebbde52b0b8ba2011c040d8c1c73d"` [INFO] running `"docker" "rm" "-f" "debe292011e43a1a8e2e7a2a2f26a78f030ebbde52b0b8ba2011c040d8c1c73d"` [INFO] [stdout] debe292011e43a1a8e2e7a2a2f26a78f030ebbde52b0b8ba2011c040d8c1c73d