[INFO] crate cargo-brew 0.1.4 is already in cache [INFO] extracting crate cargo-brew 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/cargo-brew/0.1.4 [INFO] extracting crate cargo-brew 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-brew/0.1.4 [INFO] validating manifest of cargo-brew-0.1.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cargo-brew-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cargo-brew-0.1.4 [INFO] finished frobbing cargo-brew-0.1.4 [INFO] frobbed toml for cargo-brew-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/cargo-brew/0.1.4/Cargo.toml [INFO] started frobbing cargo-brew-0.1.4 [INFO] finished frobbing cargo-brew-0.1.4 [INFO] frobbed toml for cargo-brew-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-brew/0.1.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cargo-brew-0.1.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cargo-brew/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 75c95d9124946ffd4935176e255432961a91ef554f23d766c29d758e2ccdad62 [INFO] running `"docker" "start" "-a" "75c95d9124946ffd4935176e255432961a91ef554f23d766c29d758e2ccdad62"` [INFO] [stderr] Checking userror v0.1.0 [INFO] [stderr] Checking cargo-brew v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:142:5 [INFO] [stderr] | [INFO] [stderr] 142 | krate_vers [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:134:22 [INFO] [stderr] | [INFO] [stderr] 134 | let krate_vers = if let Some(caps) = re.captures(err) { [INFO] [stderr] | ______________________^ [INFO] [stderr] 135 | | let krate = expect!(caps.at(1), "could not determine crate name").to_owned(); [INFO] [stderr] 136 | | let vers = caps.at(2).unwrap_or("HEAD").to_owned(); [INFO] [stderr] 137 | | (krate, vers) [INFO] [stderr] 138 | | } else { [INFO] [stderr] 139 | | userror::fatal("could not determine crate name"); [INFO] [stderr] 140 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:142:5 [INFO] [stderr] | [INFO] [stderr] 142 | krate_vers [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:134:22 [INFO] [stderr] | [INFO] [stderr] 134 | let krate_vers = if let Some(caps) = re.captures(err) { [INFO] [stderr] | ______________________^ [INFO] [stderr] 135 | | let krate = expect!(caps.at(1), "could not determine crate name").to_owned(); [INFO] [stderr] 136 | | let vers = caps.at(2).unwrap_or("HEAD").to_owned(); [INFO] [stderr] 137 | | (krate, vers) [INFO] [stderr] 138 | | } else { [INFO] [stderr] 139 | | userror::fatal("could not determine crate name"); [INFO] [stderr] 140 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.40s [INFO] running `"docker" "inspect" "75c95d9124946ffd4935176e255432961a91ef554f23d766c29d758e2ccdad62"` [INFO] running `"docker" "rm" "-f" "75c95d9124946ffd4935176e255432961a91ef554f23d766c29d758e2ccdad62"` [INFO] [stdout] 75c95d9124946ffd4935176e255432961a91ef554f23d766c29d758e2ccdad62