[INFO] crate cargo-bloat 0.6.2 is already in cache [INFO] extracting crate cargo-bloat 0.6.2 into work/ex/clippy-test-run/sources/stable/reg/cargo-bloat/0.6.2 [INFO] extracting crate cargo-bloat 0.6.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-bloat/0.6.2 [INFO] validating manifest of cargo-bloat-0.6.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cargo-bloat-0.6.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cargo-bloat-0.6.2 [INFO] finished frobbing cargo-bloat-0.6.2 [INFO] frobbed toml for cargo-bloat-0.6.2 written to work/ex/clippy-test-run/sources/stable/reg/cargo-bloat/0.6.2/Cargo.toml [INFO] started frobbing cargo-bloat-0.6.2 [INFO] finished frobbing cargo-bloat-0.6.2 [INFO] frobbed toml for cargo-bloat-0.6.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-bloat/0.6.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cargo-bloat-0.6.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cargo-bloat/0.6.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e8689ec7cead676656f26d37283f16d6ea6cbb7f922efeeb0e68b1d515a1861c [INFO] running `"docker" "start" "-a" "e8689ec7cead676656f26d37283f16d6ea6cbb7f922efeeb0e68b1d515a1861c"` [INFO] [stderr] Checking uuid v0.7.2 [INFO] [stderr] Compiling scroll_derive v0.9.5 [INFO] [stderr] Checking scroll v0.9.2 [INFO] [stderr] Checking goblin v0.0.19 [INFO] [stderr] Checking object v0.11.0 [INFO] [stderr] Checking cargo-bloat v0.6.2 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | #[macro_use] extern crate structopt; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/table.rs:79:24 [INFO] [stderr] | [INFO] [stderr] 79 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 80 | | if let Some(w) = self.max_width { [INFO] [stderr] 81 | | let name_width = w - non_fn_width; [INFO] [stderr] 82 | | [INFO] [stderr] ... | [INFO] [stderr] 91 | | } [INFO] [stderr] 92 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 79 | } else if let Some(w) = self.max_width { [INFO] [stderr] 80 | let name_width = w - non_fn_width; [INFO] [stderr] 81 | [INFO] [stderr] 82 | let mut cell = cell.clone(); [INFO] [stderr] 83 | if cell.len() > name_width { [INFO] [stderr] 84 | cell.drain((name_width - 3)..); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Variant name ends with the enum's name [INFO] [stderr] --> src/main.rs:174:5 [INFO] [stderr] | [INFO] [stderr] 174 | CargoError(String), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:767:20 [INFO] [stderr] | [INFO] [stderr] 767 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 768 | | if crate_name1 == crate_name2 { [INFO] [stderr] 769 | | crate_name1.clone() [INFO] [stderr] 770 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 801 | | } [INFO] [stderr] 802 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 767 | } else if crate_name1 == crate_name2 { [INFO] [stderr] 768 | crate_name1.clone() [INFO] [stderr] 769 | } else { [INFO] [stderr] 770 | // This is an uncertain case. [INFO] [stderr] 771 | // [INFO] [stderr] 772 | // Example: [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:818:5 [INFO] [stderr] | [INFO] [stderr] 818 | / if !flags.split_std { [INFO] [stderr] 819 | | if d.std_crates.contains(&crate_name) { [INFO] [stderr] 820 | | crate_name = "std".to_string(); [INFO] [stderr] 821 | | } [INFO] [stderr] 822 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 818 | if !flags.split_std && d.std_crates.contains(&crate_name) { [INFO] [stderr] 819 | crate_name = "std".to_string(); [INFO] [stderr] 820 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | #[macro_use] extern crate structopt; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/table.rs:79:24 [INFO] [stderr] | [INFO] [stderr] 79 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 80 | | if let Some(w) = self.max_width { [INFO] [stderr] 81 | | let name_width = w - non_fn_width; [INFO] [stderr] 82 | | [INFO] [stderr] ... | [INFO] [stderr] 91 | | } [INFO] [stderr] 92 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 79 | } else if let Some(w) = self.max_width { [INFO] [stderr] 80 | let name_width = w - non_fn_width; [INFO] [stderr] 81 | [INFO] [stderr] 82 | let mut cell = cell.clone(); [INFO] [stderr] 83 | if cell.len() > name_width { [INFO] [stderr] 84 | cell.drain((name_width - 3)..); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Variant name ends with the enum's name [INFO] [stderr] --> src/main.rs:174:5 [INFO] [stderr] | [INFO] [stderr] 174 | CargoError(String), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:767:20 [INFO] [stderr] | [INFO] [stderr] 767 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 768 | | if crate_name1 == crate_name2 { [INFO] [stderr] 769 | | crate_name1.clone() [INFO] [stderr] 770 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 801 | | } [INFO] [stderr] 802 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 767 | } else if crate_name1 == crate_name2 { [INFO] [stderr] 768 | crate_name1.clone() [INFO] [stderr] 769 | } else { [INFO] [stderr] 770 | // This is an uncertain case. [INFO] [stderr] 771 | // [INFO] [stderr] 772 | // Example: [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:818:5 [INFO] [stderr] | [INFO] [stderr] 818 | / if !flags.split_std { [INFO] [stderr] 819 | | if d.std_crates.contains(&crate_name) { [INFO] [stderr] 820 | | crate_name = "std".to_string(); [INFO] [stderr] 821 | | } [INFO] [stderr] 822 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 818 | if !flags.split_std && d.std_crates.contains(&crate_name) { [INFO] [stderr] 819 | crate_name = "std".to_string(); [INFO] [stderr] 820 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:326:5 [INFO] [stderr] | [INFO] [stderr] 326 | / for line in stdout.lines() { [INFO] [stderr] 327 | | let meta: Metadata = serde_json::from_str(line).map_err(|_| Error::InvalidCargoOutput)?; [INFO] [stderr] 328 | | return Ok(meta.workspace_root); [INFO] [stderr] 329 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:715:31 [INFO] [stderr] | [INFO] [stderr] 715 | if crate_name.starts_with("<") { [INFO] [stderr] | ^^^ help: try using a char instead: `'<'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:716:38 [INFO] [stderr] | [INFO] [stderr] 716 | while crate_name.starts_with("<") { [INFO] [stderr] | ^^^ help: try using a char instead: `'<'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `cargo-bloat`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:326:5 [INFO] [stderr] | [INFO] [stderr] 326 | / for line in stdout.lines() { [INFO] [stderr] 327 | | let meta: Metadata = serde_json::from_str(line).map_err(|_| Error::InvalidCargoOutput)?; [INFO] [stderr] 328 | | return Ok(meta.workspace_root); [INFO] [stderr] 329 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:715:31 [INFO] [stderr] | [INFO] [stderr] 715 | if crate_name.starts_with("<") { [INFO] [stderr] | ^^^ help: try using a char instead: `'<'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:716:38 [INFO] [stderr] | [INFO] [stderr] 716 | while crate_name.starts_with("<") { [INFO] [stderr] | ^^^ help: try using a char instead: `'<'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `cargo-bloat`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e8689ec7cead676656f26d37283f16d6ea6cbb7f922efeeb0e68b1d515a1861c"` [INFO] running `"docker" "rm" "-f" "e8689ec7cead676656f26d37283f16d6ea6cbb7f922efeeb0e68b1d515a1861c"` [INFO] [stdout] e8689ec7cead676656f26d37283f16d6ea6cbb7f922efeeb0e68b1d515a1861c