[INFO] crate cargo-add 0.2.0 is already in cache
[INFO] extracting crate cargo-add 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/cargo-add/0.2.0
[INFO] extracting crate cargo-add 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-add/0.2.0
[INFO] validating manifest of cargo-add-0.2.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of cargo-add-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing cargo-add-0.2.0
[INFO] finished frobbing cargo-add-0.2.0
[INFO] frobbed toml for cargo-add-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/cargo-add/0.2.0/Cargo.toml
[INFO] started frobbing cargo-add-0.2.0
[INFO] finished frobbing cargo-add-0.2.0
[INFO] frobbed toml for cargo-add-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-add/0.2.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting cargo-add-0.2.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cargo-add/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e38e9b67d1617a7589ed045789b132e96ad8de4cc6e67c7e8ddf209273757d3a
[INFO] running `"docker" "start" "-a" "e38e9b67d1617a7589ed045789b132e96ad8de4cc6e67c7e8ddf209273757d3a"`
[INFO] [stderr]     Checking docopt v0.7.0
[INFO] [stderr]     Checking cargo-add v0.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:73:26
[INFO] [stderr]    |
[INFO] [stderr] 73 | fn parse_dependency(dep: &String, args: &Args) -> Result<Dependency, Box<Error>> {
[INFO] [stderr]    |                          ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:82:26
[INFO] [stderr]    |
[INFO] [stderr] 82 | fn parse_semver(version: &String) -> Result<toml::Value, Box<Error>> {
[INFO] [stderr]    |                          ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 82 | fn parse_semver(version: &str) -> Result<toml::Value, Box<Error>> {
[INFO] [stderr]    |                          ^^^^
[INFO] [stderr] help: change `version.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 84 |     Ok(toml::Value::String(version.to_string()))
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:88:20
[INFO] [stderr]    |
[INFO] [stderr] 88 | fn parse_git(repo: &String) -> Result<toml::Value, Box<Error>> {
[INFO] [stderr]    |                    ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:95:21
[INFO] [stderr]    |
[INFO] [stderr] 95 | fn parse_path(path: &String) -> Result<toml::Value, Box<Error>> {
[INFO] [stderr]    |                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]    --> src/main.rs:116:6
[INFO] [stderr]     |
[INFO] [stderr] 116 |     .or(dir.parent().ok_or(ManifestError).and_then(manifest_search))
[INFO] [stderr]     |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|_| dir.parent().ok_or(ManifestError).and_then(manifest_search))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:126:20
[INFO] [stderr]     |
[INFO] [stderr] 126 |     parser.parse().ok_or(parser.errors.pop()).map_err(Option::unwrap).map_err(From::from)
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| parser.errors.pop())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:145:5
[INFO] [stderr]     |
[INFO] [stderr] 145 | /     match manifest.entry(String::from("dependencies"))
[INFO] [stderr] 146 | |     .or_insert(toml::Value::Table(BTreeMap::new())) {
[INFO] [stderr] 147 | |         &mut toml::Value::Table(ref mut deps) => {
[INFO] [stderr] 148 | |             deps.insert(name, data);
[INFO] [stderr] ...   |
[INFO] [stderr] 151 | |         _ => Err(ManifestError)
[INFO] [stderr] 152 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 145 |     match *manifest.entry(String::from("dependencies"))
[INFO] [stderr] 146 |     .or_insert(toml::Value::Table(BTreeMap::new())) {
[INFO] [stderr] 147 |         toml::Value::Table(ref mut deps) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/main.rs:146:6
[INFO] [stderr]     |
[INFO] [stderr] 146 |     .or_insert(toml::Value::Table(BTreeMap::new())) {
[INFO] [stderr]     |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| toml::Value::Table(BTreeMap::new()))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:73:26
[INFO] [stderr]    |
[INFO] [stderr] 73 | fn parse_dependency(dep: &String, args: &Args) -> Result<Dependency, Box<Error>> {
[INFO] [stderr]    |                          ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:82:26
[INFO] [stderr]    |
[INFO] [stderr] 82 | fn parse_semver(version: &String) -> Result<toml::Value, Box<Error>> {
[INFO] [stderr]    |                          ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 82 | fn parse_semver(version: &str) -> Result<toml::Value, Box<Error>> {
[INFO] [stderr]    |                          ^^^^
[INFO] [stderr] help: change `version.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 84 |     Ok(toml::Value::String(version.to_string()))
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:88:20
[INFO] [stderr]    |
[INFO] [stderr] 88 | fn parse_git(repo: &String) -> Result<toml::Value, Box<Error>> {
[INFO] [stderr]    |                    ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:95:21
[INFO] [stderr]    |
[INFO] [stderr] 95 | fn parse_path(path: &String) -> Result<toml::Value, Box<Error>> {
[INFO] [stderr]    |                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]    --> src/main.rs:116:6
[INFO] [stderr]     |
[INFO] [stderr] 116 |     .or(dir.parent().ok_or(ManifestError).and_then(manifest_search))
[INFO] [stderr]     |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|_| dir.parent().ok_or(ManifestError).and_then(manifest_search))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:126:20
[INFO] [stderr]     |
[INFO] [stderr] 126 |     parser.parse().ok_or(parser.errors.pop()).map_err(Option::unwrap).map_err(From::from)
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| parser.errors.pop())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:145:5
[INFO] [stderr]     |
[INFO] [stderr] 145 | /     match manifest.entry(String::from("dependencies"))
[INFO] [stderr] 146 | |     .or_insert(toml::Value::Table(BTreeMap::new())) {
[INFO] [stderr] 147 | |         &mut toml::Value::Table(ref mut deps) => {
[INFO] [stderr] 148 | |             deps.insert(name, data);
[INFO] [stderr] ...   |
[INFO] [stderr] 151 | |         _ => Err(ManifestError)
[INFO] [stderr] 152 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 145 |     match *manifest.entry(String::from("dependencies"))
[INFO] [stderr] 146 |     .or_insert(toml::Value::Table(BTreeMap::new())) {
[INFO] [stderr] 147 |         toml::Value::Table(ref mut deps) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/main.rs:146:6
[INFO] [stderr]     |
[INFO] [stderr] 146 |     .or_insert(toml::Value::Table(BTreeMap::new())) {
[INFO] [stderr]     |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| toml::Value::Table(BTreeMap::new()))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 4.90s
[INFO] running `"docker" "inspect" "e38e9b67d1617a7589ed045789b132e96ad8de4cc6e67c7e8ddf209273757d3a"`
[INFO] running `"docker" "rm" "-f" "e38e9b67d1617a7589ed045789b132e96ad8de4cc6e67c7e8ddf209273757d3a"`
[INFO] [stdout] e38e9b67d1617a7589ed045789b132e96ad8de4cc6e67c7e8ddf209273757d3a