[INFO] crate cards 1.1.2 is already in cache
[INFO] extracting crate cards 1.1.2 into work/ex/clippy-test-run/sources/stable/reg/cards/1.1.2
[INFO] extracting crate cards 1.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cards/1.1.2
[INFO] validating manifest of cards-1.1.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of cards-1.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing cards-1.1.2
[INFO] finished frobbing cards-1.1.2
[INFO] frobbed toml for cards-1.1.2 written to work/ex/clippy-test-run/sources/stable/reg/cards/1.1.2/Cargo.toml
[INFO] started frobbing cards-1.1.2
[INFO] finished frobbing cards-1.1.2
[INFO] frobbed toml for cards-1.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cards/1.1.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting cards-1.1.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cards/1.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 19aa0a96209a9454a5935b2dbb3c5581c04e47baac4e1f5f67466c0e844e26af
[INFO] running `"docker" "start" "-a" "19aa0a96209a9454a5935b2dbb3c5581c04e47baac4e1f5f67466c0e844e26af"`
[INFO] [stderr]     Checking cards v1.1.2 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/card.rs:70:15
[INFO] [stderr]    |
[INFO] [stderr] 70 |         Card{ value: value, suit: suit }
[INFO] [stderr]    |               ^^^^^^^^^^^^ help: replace it with: `value`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/card.rs:70:29
[INFO] [stderr]    |
[INFO] [stderr] 70 |         Card{ value: value, suit: suit }
[INFO] [stderr]    |                             ^^^^^^^^^^ help: replace it with: `suit`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/card.rs:70:15
[INFO] [stderr]    |
[INFO] [stderr] 70 |         Card{ value: value, suit: suit }
[INFO] [stderr]    |               ^^^^^^^^^^^^ help: replace it with: `value`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/card.rs:70:29
[INFO] [stderr]    |
[INFO] [stderr] 70 |         Card{ value: value, suit: suit }
[INFO] [stderr]    |                             ^^^^^^^^^^ help: replace it with: `suit`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/card.rs:12:21
[INFO] [stderr]    |
[INFO] [stderr] 12 |     fn short_string(&self) -> &'static str {
[INFO] [stderr]    |                     ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/card.rs:41:21
[INFO] [stderr]    |
[INFO] [stderr] 41 |     fn short_string(&self) -> &'static str {
[INFO] [stderr]    |                     ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `value` is used as a loop counter. Consider using `for (value, item) in d.cards.iter_mut().enumerate()` or similar iterators
[INFO] [stderr]   --> src/deck.rs:59:18
[INFO] [stderr]    |
[INFO] [stderr] 59 |         for x in d.cards.iter_mut() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/card.rs:12:21
[INFO] [stderr]    |
[INFO] [stderr] 12 |     fn short_string(&self) -> &'static str {
[INFO] [stderr]    |                     ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/card.rs:41:21
[INFO] [stderr]    |
[INFO] [stderr] 41 |     fn short_string(&self) -> &'static str {
[INFO] [stderr]    |                     ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `value` is used as a loop counter. Consider using `for (value, item) in d.cards.iter_mut().enumerate()` or similar iterators
[INFO] [stderr]   --> src/deck.rs:59:18
[INFO] [stderr]    |
[INFO] [stderr] 59 |         for x in d.cards.iter_mut() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `cards`.
[INFO] [stderr]   --> tests/lib.rs:70:14
[INFO] [stderr]    |
[INFO] [stderr] 70 |     for i in 0..52 {
[INFO] [stderr]    |              ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 70 |     for <item> in &cards {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.49s
[INFO] running `"docker" "inspect" "19aa0a96209a9454a5935b2dbb3c5581c04e47baac4e1f5f67466c0e844e26af"`
[INFO] running `"docker" "rm" "-f" "19aa0a96209a9454a5935b2dbb3c5581c04e47baac4e1f5f67466c0e844e26af"`
[INFO] [stdout] 19aa0a96209a9454a5935b2dbb3c5581c04e47baac4e1f5f67466c0e844e26af