[INFO] crate card_deck 0.1.7 is already in cache
[INFO] extracting crate card_deck 0.1.7 into work/ex/clippy-test-run/sources/stable/reg/card_deck/0.1.7
[INFO] extracting crate card_deck 0.1.7 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/card_deck/0.1.7
[INFO] validating manifest of card_deck-0.1.7 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of card_deck-0.1.7 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing card_deck-0.1.7
[INFO] finished frobbing card_deck-0.1.7
[INFO] frobbed toml for card_deck-0.1.7 written to work/ex/clippy-test-run/sources/stable/reg/card_deck/0.1.7/Cargo.toml
[INFO] started frobbing card_deck-0.1.7
[INFO] finished frobbing card_deck-0.1.7
[INFO] frobbed toml for card_deck-0.1.7 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/card_deck/0.1.7/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting card_deck-0.1.7 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/card_deck/0.1.7:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ddac0f7353b738f31746c287cf610cd23c84065dc529222a208b481696a72691
[INFO] running `"docker" "start" "-a" "ddac0f7353b738f31746c287cf610cd23c84065dc529222a208b481696a72691"`
[INFO] [stderr]     Checking card_deck v0.1.7 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/playing_card.rs:120:13
[INFO] [stderr]     |
[INFO] [stderr] 120 |             suit:suit,
[INFO] [stderr]     |             ^^^^^^^^^ help: replace it with: `suit`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/playing_card.rs:120:13
[INFO] [stderr]     |
[INFO] [stderr] 120 |             suit:suit,
[INFO] [stderr]     |             ^^^^^^^^^ help: replace it with: `suit`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/deck.rs:137:9
[INFO] [stderr]     |
[INFO] [stderr] 137 |         return self.draw(1).next();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.draw(1).next()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `deck::DeckBuilder<C>`
[INFO] [stderr]   --> src/deck.rs:27:5
[INFO] [stderr]    |
[INFO] [stderr] 27 | /     pub fn new()->Self{
[INFO] [stderr] 28 | |         DeckBuilder{
[INFO] [stderr] 29 | |             draw_pile:None,
[INFO] [stderr] 30 | |             discard_pile:None,
[INFO] [stderr] ...  |
[INFO] [stderr] 34 | |         }
[INFO] [stderr] 35 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 18 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]   --> src/deck.rs:80:23
[INFO] [stderr]    |
[INFO] [stderr] 80 |             draw_pile:self.draw_pile.unwrap_or(Vec::new()),
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.draw_pile.unwrap_or_default()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]   --> src/deck.rs:81:26
[INFO] [stderr]    |
[INFO] [stderr] 81 |             discard_pile:self.discard_pile.unwrap_or(Vec::new()),
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.discard_pile.unwrap_or_default()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: item `deck::Deck<C>` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/deck.rs:89:1
[INFO] [stderr]     |
[INFO] [stderr] 89  | / impl<C> Deck<C>{
[INFO] [stderr] 90  | |     ///Builds a deck using the supplied cards and defaults for all other options
[INFO] [stderr] 91  | |     pub fn new(v:Vec<C>)->Self{
[INFO] [stderr] 92  | |         Self::build().draw_pile(v).done()
[INFO] [stderr] ...   |
[INFO] [stderr] 221 | |     }
[INFO] [stderr] 222 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/deck.rs:165:9
[INFO] [stderr]     |
[INFO] [stderr] 165 | /         match self.stop_on_discards {
[INFO] [stderr] 166 | |             true => self.draw_pile.len(),
[INFO] [stderr] 167 | |             false => self.draw_pile.len() + self.discard_pile.len(),
[INFO] [stderr] 168 | |         }
[INFO] [stderr]     | |_________^ help: consider using an if/else expression: `if self.stop_on_discards { self.draw_pile.len() } else { self.draw_pile.len() + self.discard_pile.len() }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/deck.rs:252:9
[INFO] [stderr]     |
[INFO] [stderr] 252 | /         match self.stop_on_discards{
[INFO] [stderr] 253 | |             true=>(self.draw_pile).iter().chain(self.chainer.iter()),
[INFO] [stderr] 254 | |             false=>(self.draw_pile).iter().chain(self.discard_pile.iter()),
[INFO] [stderr] 255 | |         }
[INFO] [stderr]     | |_________^ help: consider using an if/else expression: `if self.stop_on_discards { (self.draw_pile).iter().chain(self.chainer.iter()) } else { (self.draw_pile).iter().chain(self.discard_pile.iter()) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/deck.rs:278:9
[INFO] [stderr]     |
[INFO] [stderr] 278 | /         match self.stop_on_discards{
[INFO] [stderr] 279 | |             true=>(self.draw_pile).iter_mut().chain(self.chainer.iter_mut()),
[INFO] [stderr] 280 | |             false=>(self.draw_pile).iter_mut().chain(self.discard_pile.iter_mut()),
[INFO] [stderr] 281 | |         }
[INFO] [stderr]     | |_________^ help: consider using an if/else expression: `if self.stop_on_discards { (self.draw_pile).iter_mut().chain(self.chainer.iter_mut()) } else { (self.draw_pile).iter_mut().chain(self.discard_pile.iter_mut()) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/deck.rs:137:9
[INFO] [stderr]     |
[INFO] [stderr] 137 |         return self.draw(1).next();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.draw(1).next()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `deck::DeckBuilder<C>`
[INFO] [stderr]   --> src/deck.rs:27:5
[INFO] [stderr]    |
[INFO] [stderr] 27 | /     pub fn new()->Self{
[INFO] [stderr] 28 | |         DeckBuilder{
[INFO] [stderr] 29 | |             draw_pile:None,
[INFO] [stderr] 30 | |             discard_pile:None,
[INFO] [stderr] ...  |
[INFO] [stderr] 34 | |         }
[INFO] [stderr] 35 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 18 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]   --> src/deck.rs:80:23
[INFO] [stderr]    |
[INFO] [stderr] 80 |             draw_pile:self.draw_pile.unwrap_or(Vec::new()),
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.draw_pile.unwrap_or_default()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]   --> src/deck.rs:81:26
[INFO] [stderr]    |
[INFO] [stderr] 81 |             discard_pile:self.discard_pile.unwrap_or(Vec::new()),
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.discard_pile.unwrap_or_default()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: item `deck::Deck<C>` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/deck.rs:89:1
[INFO] [stderr]     |
[INFO] [stderr] 89  | / impl<C> Deck<C>{
[INFO] [stderr] 90  | |     ///Builds a deck using the supplied cards and defaults for all other options
[INFO] [stderr] 91  | |     pub fn new(v:Vec<C>)->Self{
[INFO] [stderr] 92  | |         Self::build().draw_pile(v).done()
[INFO] [stderr] ...   |
[INFO] [stderr] 221 | |     }
[INFO] [stderr] 222 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/deck.rs:165:9
[INFO] [stderr]     |
[INFO] [stderr] 165 | /         match self.stop_on_discards {
[INFO] [stderr] 166 | |             true => self.draw_pile.len(),
[INFO] [stderr] 167 | |             false => self.draw_pile.len() + self.discard_pile.len(),
[INFO] [stderr] 168 | |         }
[INFO] [stderr]     | |_________^ help: consider using an if/else expression: `if self.stop_on_discards { self.draw_pile.len() } else { self.draw_pile.len() + self.discard_pile.len() }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/deck.rs:252:9
[INFO] [stderr]     |
[INFO] [stderr] 252 | /         match self.stop_on_discards{
[INFO] [stderr] 253 | |             true=>(self.draw_pile).iter().chain(self.chainer.iter()),
[INFO] [stderr] 254 | |             false=>(self.draw_pile).iter().chain(self.discard_pile.iter()),
[INFO] [stderr] 255 | |         }
[INFO] [stderr]     | |_________^ help: consider using an if/else expression: `if self.stop_on_discards { (self.draw_pile).iter().chain(self.chainer.iter()) } else { (self.draw_pile).iter().chain(self.discard_pile.iter()) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/deck.rs:278:9
[INFO] [stderr]     |
[INFO] [stderr] 278 | /         match self.stop_on_discards{
[INFO] [stderr] 279 | |             true=>(self.draw_pile).iter_mut().chain(self.chainer.iter_mut()),
[INFO] [stderr] 280 | |             false=>(self.draw_pile).iter_mut().chain(self.discard_pile.iter_mut()),
[INFO] [stderr] 281 | |         }
[INFO] [stderr]     | |_________^ help: consider using an if/else expression: `if self.stop_on_discards { (self.draw_pile).iter_mut().chain(self.chainer.iter_mut()) } else { (self.draw_pile).iter_mut().chain(self.discard_pile.iter_mut()) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.52s
[INFO] running `"docker" "inspect" "ddac0f7353b738f31746c287cf610cd23c84065dc529222a208b481696a72691"`
[INFO] running `"docker" "rm" "-f" "ddac0f7353b738f31746c287cf610cd23c84065dc529222a208b481696a72691"`
[INFO] [stdout] ddac0f7353b738f31746c287cf610cd23c84065dc529222a208b481696a72691