[INFO] crate carboxyl 0.2.1 is already in cache [INFO] extracting crate carboxyl 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/carboxyl/0.2.1 [INFO] extracting crate carboxyl 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/carboxyl/0.2.1 [INFO] validating manifest of carboxyl-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of carboxyl-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing carboxyl-0.2.1 [INFO] finished frobbing carboxyl-0.2.1 [INFO] frobbed toml for carboxyl-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/carboxyl/0.2.1/Cargo.toml [INFO] started frobbing carboxyl-0.2.1 [INFO] finished frobbing carboxyl-0.2.1 [INFO] frobbed toml for carboxyl-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/carboxyl/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting carboxyl-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/carboxyl/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8ab5ae05640d0750fe600de6b35393310d1d6d16d1d2844caccefca97a947370 [INFO] running `"docker" "start" "-a" "8ab5ae05640d0750fe600de6b35393310d1d6d16d1d2844caccefca97a947370"` [INFO] [stderr] Compiling getopts v0.2.18 [INFO] [stderr] Checking pulldown-cmark v0.0.3 [INFO] [stderr] Checking skeptic v0.6.1 [INFO] [stderr] Compiling carboxyl v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/signal.rs:396:21 [INFO] [stderr] | [INFO] [stderr] 396 | const ERR: &'static str = "sampled on forward-declaration of signal"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/signal.rs:413:25 [INFO] [stderr] | [INFO] [stderr] 413 | ret [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/signal.rs:412:35 [INFO] [stderr] | [INFO] [stderr] 412 | let ret = strong.read().unwrap().call(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `stream::Sink` [INFO] [stderr] --> src/stream/mod.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | / pub fn new() -> Sink { [INFO] [stderr] 78 | | Sink { source: Arc::new(RwLock::new(Source::new())) } [INFO] [stderr] 79 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 75 | impl Default for stream::Sink { [INFO] [stderr] 76 | fn default() -> Self { [INFO] [stderr] 77 | Self::new() [INFO] [stderr] 78 | } [INFO] [stderr] 79 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/simple.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `carboxyl`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/first_order.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `carboxyl`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stream/mod.rs:604:28 [INFO] [stderr] | [INFO] [stderr] 604 | sink.feed_async(0..100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/signal.rs:396:21 [INFO] [stderr] | [INFO] [stderr] 396 | const ERR: &'static str = "sampled on forward-declaration of signal"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/signal.rs:413:25 [INFO] [stderr] | [INFO] [stderr] 413 | ret [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/signal.rs:412:35 [INFO] [stderr] | [INFO] [stderr] 412 | let ret = strong.read().unwrap().call(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/second_order.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `carboxyl`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> /opt/crater/target/debug/build/carboxyl-436470eb1c298eba/out/skeptic-tests.rs:3:9 [INFO] [stderr] | [INFO] [stderr] 3 | let ref s = format!("{}", r####"extern crate carboxyl; [INFO] [stderr] | _____- ^^^^^ [INFO] [stderr] 4 | | [INFO] [stderr] 5 | | fn main() { [INFO] [stderr] 6 | | let sink = carboxyl::Sink::new(); [INFO] [stderr] ... | [INFO] [stderr] 16 | | } [INFO] [stderr] 17 | | "####); [INFO] [stderr] | |_______- help: try: `let s = &$ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) );` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> /opt/crater/target/debug/build/carboxyl-436470eb1c298eba/out/skeptic-tests.rs:3:17 [INFO] [stderr] | [INFO] [stderr] 3 | let ref s = format!("{}", r####"extern crate carboxyl; [INFO] [stderr] | _________________^ [INFO] [stderr] 4 | | [INFO] [stderr] 5 | | fn main() { [INFO] [stderr] 6 | | let sink = carboxyl::Sink::new(); [INFO] [stderr] ... | [INFO] [stderr] 16 | | } [INFO] [stderr] 17 | | "####); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 2 | $ crate :: fmt :: format ( r####"extern crate carboxyl; [INFO] [stderr] 3 | [INFO] [stderr] 4 | fn main() { [INFO] [stderr] 5 | let sink = carboxyl::Sink::new(); [INFO] [stderr] 6 | let stream = sink.stream(); [INFO] [stderr] 7 | let signal = stream.hold(3); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> /opt/crater/target/debug/build/carboxyl-436470eb1c298eba/out/skeptic-tests.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | let ref s = format!("{}", r####"extern crate carboxyl; [INFO] [stderr] | _____- ^^^^^ [INFO] [stderr] 23 | | [INFO] [stderr] 24 | | fn main() { [INFO] [stderr] 25 | | let sink = carboxyl::Sink::new(); [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | "####); [INFO] [stderr] | |_______- help: try: `let s = &$ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) );` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> /opt/crater/target/debug/build/carboxyl-436470eb1c298eba/out/skeptic-tests.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | let ref s = format!("{}", r####"extern crate carboxyl; [INFO] [stderr] | _________________^ [INFO] [stderr] 23 | | [INFO] [stderr] 24 | | fn main() { [INFO] [stderr] 25 | | let sink = carboxyl::Sink::new(); [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | "####); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 2 | $ crate :: fmt :: format ( r####"extern crate carboxyl; [INFO] [stderr] 3 | [INFO] [stderr] 4 | fn main() { [INFO] [stderr] 5 | let sink = carboxyl::Sink::new(); [INFO] [stderr] 6 | let stream = sink.stream(); [INFO] [stderr] 7 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> /opt/crater/target/debug/build/carboxyl-436470eb1c298eba/out/skeptic-tests.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | let ref s = format!("{}", r####"extern crate carboxyl; [INFO] [stderr] | _____- ^^^^^ [INFO] [stderr] 38 | | [INFO] [stderr] 39 | | fn main() { [INFO] [stderr] 40 | | let sink = carboxyl::Sink::new(); [INFO] [stderr] ... | [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | "####); [INFO] [stderr] | |_______- help: try: `let s = &$ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) );` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> /opt/crater/target/debug/build/carboxyl-436470eb1c298eba/out/skeptic-tests.rs:37:17 [INFO] [stderr] | [INFO] [stderr] 37 | let ref s = format!("{}", r####"extern crate carboxyl; [INFO] [stderr] | _________________^ [INFO] [stderr] 38 | | [INFO] [stderr] 39 | | fn main() { [INFO] [stderr] 40 | | let sink = carboxyl::Sink::new(); [INFO] [stderr] ... | [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | "####); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 2 | $ crate :: fmt :: format ( r####"extern crate carboxyl; [INFO] [stderr] 3 | [INFO] [stderr] 4 | fn main() { [INFO] [stderr] 5 | let sink = carboxyl::Sink::new(); [INFO] [stderr] 6 | let stream = sink.stream(); [INFO] [stderr] 7 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> /opt/crater/target/debug/build/carboxyl-436470eb1c298eba/out/skeptic-tests.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | let ref s = format!("{}", r####"extern crate carboxyl; [INFO] [stderr] | _____- ^^^^^ [INFO] [stderr] 53 | | [INFO] [stderr] 54 | | fn main() { [INFO] [stderr] 55 | | let sink = carboxyl::Sink::new(); [INFO] [stderr] ... | [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | "####); [INFO] [stderr] | |_______- help: try: `let s = &$ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) );` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> /opt/crater/target/debug/build/carboxyl-436470eb1c298eba/out/skeptic-tests.rs:52:17 [INFO] [stderr] | [INFO] [stderr] 52 | let ref s = format!("{}", r####"extern crate carboxyl; [INFO] [stderr] | _________________^ [INFO] [stderr] 53 | | [INFO] [stderr] 54 | | fn main() { [INFO] [stderr] 55 | | let sink = carboxyl::Sink::new(); [INFO] [stderr] ... | [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | "####); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 2 | $ crate :: fmt :: format ( r####"extern crate carboxyl; [INFO] [stderr] 3 | [INFO] [stderr] 4 | fn main() { [INFO] [stderr] 5 | let sink = carboxyl::Sink::new(); [INFO] [stderr] 6 | let stream = sink.stream(); [INFO] [stderr] 7 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/transaction.rs:179:31 [INFO] [stderr] | [INFO] [stderr] 179 | for guard in guards { guard.join().ok().expect("thread failed"); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `stream::Sink` [INFO] [stderr] --> src/stream/mod.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | / pub fn new() -> Sink { [INFO] [stderr] 78 | | Sink { source: Arc::new(RwLock::new(Source::new())) } [INFO] [stderr] 79 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 75 | impl Default for stream::Sink { [INFO] [stderr] 76 | fn default() -> Self { [INFO] [stderr] 77 | Self::new() [INFO] [stderr] 78 | } [INFO] [stderr] 79 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/stream/mod.rs:711:35 [INFO] [stderr] | [INFO] [stderr] 711 | fn f(n: i32) -> i64 { (n + 3) as i64 } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(n + 3)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/signal.rs:365:21 [INFO] [stderr] | [INFO] [stderr] 365 | let n = Mutex::new(0); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/signal.rs:367:29 [INFO] [stderr] | [INFO] [stderr] 367 | let mut n = n.lock().unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/testing.rs:45:20 [INFO] [stderr] | [INFO] [stderr] 45 | if &a == &b { Ok(()) } [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 45 | if a == b { Ok(()) } [INFO] [stderr] | ^ ^ [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "8ab5ae05640d0750fe600de6b35393310d1d6d16d1d2844caccefca97a947370"` [INFO] running `"docker" "rm" "-f" "8ab5ae05640d0750fe600de6b35393310d1d6d16d1d2844caccefca97a947370"` [INFO] [stdout] 8ab5ae05640d0750fe600de6b35393310d1d6d16d1d2844caccefca97a947370