[INFO] crate carbon 0.1.0 is already in cache [INFO] extracting crate carbon 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/carbon/0.1.0 [INFO] extracting crate carbon 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/carbon/0.1.0 [INFO] validating manifest of carbon-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of carbon-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing carbon-0.1.0 [INFO] finished frobbing carbon-0.1.0 [INFO] frobbed toml for carbon-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/carbon/0.1.0/Cargo.toml [INFO] started frobbing carbon-0.1.0 [INFO] finished frobbing carbon-0.1.0 [INFO] frobbed toml for carbon-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/carbon/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting carbon-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/carbon/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1c04993b5ed9714b3c18b4351395c0d879102c4c6c59b2f8981110320649bbba [INFO] running `"docker" "start" "-a" "1c04993b5ed9714b3c18b4351395c0d879102c4c6c59b2f8981110320649bbba"` [INFO] [stderr] Checking carbon v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | tm: tm, [INFO] [stderr] | ^^^^^^ help: replace it with: `tm` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | tm: tm, [INFO] [stderr] | ^^^^^^ help: replace it with: `tm` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/start.rs:30:26 [INFO] [stderr] | [INFO] [stderr] 30 | for m in (0..self.date_time.tm.tm_mon) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/end.rs:30:30 [INFO] [stderr] | [INFO] [stderr] 30 | for month in (0..self.date_time.tm.tm_mon + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/end.rs:60:29 [INFO] [stderr] | [INFO] [stderr] 60 | copied_tm.tm_nsec = 999999999; [INFO] [stderr] | ^^^^^^^^^ help: consider: `999_999_999` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:136:167 [INFO] [stderr] | [INFO] [stderr] 136 | january: Tm { tm_sec: 59, tm_min: 59, tm_hour: 23, tm_mday: 31, tm_mon: 0, tm_year: 115, tm_wday: 6, tm_yday: 30, tm_isdst: 0, tm_utcoff: 0, tm_nsec: 999999999, }, [INFO] [stderr] | ^^^^^^^^^ help: consider: `999_999_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:137:167 [INFO] [stderr] | [INFO] [stderr] 137 | february: Tm { tm_sec: 59, tm_min: 59, tm_hour: 23, tm_mday: 28, tm_mon: 1, tm_year: 115, tm_wday: 6, tm_yday: 58, tm_isdst: 0, tm_utcoff: 0, tm_nsec: 999999999 }, [INFO] [stderr] | ^^^^^^^^^ help: consider: `999_999_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:138:167 [INFO] [stderr] | [INFO] [stderr] 138 | march: Tm { tm_sec: 59, tm_min: 59, tm_hour: 23, tm_mday: 31, tm_mon: 2, tm_year: 115, tm_wday: 2, tm_yday: 89, tm_isdst: 0, tm_utcoff: 0, tm_nsec: 999999999 }, [INFO] [stderr] | ^^^^^^^^^ help: consider: `999_999_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:139:168 [INFO] [stderr] | [INFO] [stderr] 139 | april: Tm { tm_sec: 59, tm_min: 59, tm_hour: 23, tm_mday: 30, tm_mon: 3, tm_year: 115, tm_wday: 4, tm_yday: 119, tm_isdst: 0, tm_utcoff: 0, tm_nsec: 999999999 }, [INFO] [stderr] | ^^^^^^^^^ help: consider: `999_999_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:140:168 [INFO] [stderr] | [INFO] [stderr] 140 | may: Tm { tm_sec: 59, tm_min: 59, tm_hour: 23, tm_mday: 31, tm_mon: 4, tm_year: 115, tm_wday: 0, tm_yday: 150, tm_isdst: 0, tm_utcoff: 0, tm_nsec: 999999999 }, [INFO] [stderr] | ^^^^^^^^^ help: consider: `999_999_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:141:168 [INFO] [stderr] | [INFO] [stderr] 141 | june: Tm { tm_sec: 59, tm_min: 59, tm_hour: 23, tm_mday: 30, tm_mon: 5, tm_year: 115, tm_wday: 2, tm_yday: 180, tm_isdst: 0, tm_utcoff: 0, tm_nsec: 999999999 }, [INFO] [stderr] | ^^^^^^^^^ help: consider: `999_999_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:142:168 [INFO] [stderr] | [INFO] [stderr] 142 | july: Tm { tm_sec: 59, tm_min: 59, tm_hour: 23, tm_mday: 31, tm_mon: 6, tm_year: 115, tm_wday: 5, tm_yday: 211, tm_isdst: 0, tm_utcoff: 0, tm_nsec: 999999999 }, [INFO] [stderr] | ^^^^^^^^^ help: consider: `999_999_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:143:168 [INFO] [stderr] | [INFO] [stderr] 143 | august: Tm { tm_sec: 59, tm_min: 59, tm_hour: 23, tm_mday: 31, tm_mon: 7, tm_year: 115, tm_wday: 1, tm_yday: 242, tm_isdst: 0, tm_utcoff: 0, tm_nsec: 999999999 }, [INFO] [stderr] | ^^^^^^^^^ help: consider: `999_999_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:144:168 [INFO] [stderr] | [INFO] [stderr] 144 | september: Tm { tm_sec: 59, tm_min: 59, tm_hour: 23, tm_mday: 30, tm_mon: 8, tm_year: 115, tm_wday: 3, tm_yday: 272, tm_isdst: 0, tm_utcoff: 0, tm_nsec: 999999999 }, [INFO] [stderr] | ^^^^^^^^^ help: consider: `999_999_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:145:168 [INFO] [stderr] | [INFO] [stderr] 145 | october: Tm { tm_sec: 59, tm_min: 59, tm_hour: 23, tm_mday: 31, tm_mon: 9, tm_year: 115, tm_wday: 6, tm_yday: 303, tm_isdst: 0, tm_utcoff: 0, tm_nsec: 999999999 }, [INFO] [stderr] | ^^^^^^^^^ help: consider: `999_999_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:146:169 [INFO] [stderr] | [INFO] [stderr] 146 | november: Tm { tm_sec: 59, tm_min: 59, tm_hour: 23, tm_mday: 30, tm_mon: 10, tm_year: 115, tm_wday: 1, tm_yday: 333, tm_isdst: 0, tm_utcoff: 0, tm_nsec: 999999999 }, [INFO] [stderr] | ^^^^^^^^^ help: consider: `999_999_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:147:169 [INFO] [stderr] | [INFO] [stderr] 147 | december: Tm { tm_sec: 59, tm_min: 59, tm_hour: 23, tm_mday: 31, tm_mon: 11, tm_year: 115, tm_wday: 4, tm_yday: 364, tm_isdst: 0, tm_utcoff: 0, tm_nsec: 999999999 }, [INFO] [stderr] | ^^^^^^^^^ help: consider: `999_999_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/start.rs:30:26 [INFO] [stderr] | [INFO] [stderr] 30 | for m in (0..self.date_time.tm.tm_mon) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/end.rs:30:30 [INFO] [stderr] | [INFO] [stderr] 30 | for month in (0..self.date_time.tm.tm_mon + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/end.rs:60:29 [INFO] [stderr] | [INFO] [stderr] 60 | copied_tm.tm_nsec = 999999999; [INFO] [stderr] | ^^^^^^^^^ help: consider: `999_999_999` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/end.rs:30:30 [INFO] [stderr] | [INFO] [stderr] 30 | for month in (0..self.date_time.tm.tm_mon + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=self.date_time.tm.tm_mon)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: static variable `Testnow` should have an upper case name such as `TESTNOW` [INFO] [stderr] --> src/lib.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | static mut Testnow: Option = None; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_upper_case_globals)] on by default [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:81:8 [INFO] [stderr] | [INFO] [stderr] 81 | if mm == 1.0 || mm == 2.0 { [INFO] [stderr] | ^^^^^^^^^ help: consider comparing them within some error: `(mm - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:81:8 [INFO] [stderr] | [INFO] [stderr] 81 | if mm == 1.0 || mm == 2.0 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:81:21 [INFO] [stderr] | [INFO] [stderr] 81 | if mm == 1.0 || mm == 2.0 { [INFO] [stderr] | ^^^^^^^^^ help: consider comparing them within some error: `(mm - 2.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:81:21 [INFO] [stderr] | [INFO] [stderr] 81 | if mm == 1.0 || mm == 2.0 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `carbon`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/end.rs:30:30 [INFO] [stderr] | [INFO] [stderr] 30 | for month in (0..self.date_time.tm.tm_mon + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=self.date_time.tm.tm_mon)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: static variable `Testnow` should have an upper case name such as `TESTNOW` [INFO] [stderr] --> src/lib.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | static mut Testnow: Option = None; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_upper_case_globals)] on by default [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:81:8 [INFO] [stderr] | [INFO] [stderr] 81 | if mm == 1.0 || mm == 2.0 { [INFO] [stderr] | ^^^^^^^^^ help: consider comparing them within some error: `(mm - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:81:8 [INFO] [stderr] | [INFO] [stderr] 81 | if mm == 1.0 || mm == 2.0 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:81:21 [INFO] [stderr] | [INFO] [stderr] 81 | if mm == 1.0 || mm == 2.0 { [INFO] [stderr] | ^^^^^^^^^ help: consider comparing them within some error: `(mm - 2.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:81:21 [INFO] [stderr] | [INFO] [stderr] 81 | if mm == 1.0 || mm == 2.0 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `carbon`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "1c04993b5ed9714b3c18b4351395c0d879102c4c6c59b2f8981110320649bbba"` [INFO] running `"docker" "rm" "-f" "1c04993b5ed9714b3c18b4351395c0d879102c4c6c59b2f8981110320649bbba"` [INFO] [stdout] 1c04993b5ed9714b3c18b4351395c0d879102c4c6c59b2f8981110320649bbba