[INFO] crate captcha 0.0.7 is already in cache [INFO] extracting crate captcha 0.0.7 into work/ex/clippy-test-run/sources/stable/reg/captcha/0.0.7 [INFO] extracting crate captcha 0.0.7 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/captcha/0.0.7 [INFO] validating manifest of captcha-0.0.7 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of captcha-0.0.7 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing captcha-0.0.7 [INFO] finished frobbing captcha-0.0.7 [INFO] frobbed toml for captcha-0.0.7 written to work/ex/clippy-test-run/sources/stable/reg/captcha/0.0.7/Cargo.toml [INFO] started frobbing captcha-0.0.7 [INFO] finished frobbing captcha-0.0.7 [INFO] frobbed toml for captcha-0.0.7 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/captcha/0.0.7/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting captcha-0.0.7 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/captcha/0.0.7:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 86646d7e3a3e6b4467c806f763ab393bbc1063dd153dfc11d16a8427ee36fd8d [INFO] running `"docker" "start" "-a" "86646d7e3a3e6b4467c806f763ab393bbc1063dd153dfc11d16a8427ee36fd8d"` [INFO] [stderr] Compiling lodepng v1.2.2 [INFO] [stderr] Checking captcha v0.0.7 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filters/noise.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | prob: prob [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `prob` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filters/grid.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | x_gap: x_gap, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `x_gap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filters/grid.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | y_gap: y_gap [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `y_gap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filters/cow.rs:29:15 [INFO] [stderr] | [INFO] [stderr] 29 | Cow { n: n, .. self } [INFO] [stderr] | ^^^^ help: replace it with: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filters/cow.rs:33:15 [INFO] [stderr] | [INFO] [stderr] 33 | Cow { min_radius: min_radius, .. self } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min_radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filters/cow.rs:37:15 [INFO] [stderr] | [INFO] [stderr] 37 | Cow { max_radius: max_radius, .. self } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/filters/cow.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | let h = i.height() as i32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/filters/cow.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | let w = i.width() as i32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/filters/cow.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | let mut v = vec![]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/filters/cow.rs:54:21 [INFO] [stderr] | [INFO] [stderr] 54 | let d = ((dy * dy + dx * dx) as f32).sqrt() as i32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/filters/cow.rs:89:17 [INFO] [stderr] | [INFO] [stderr] 89 | let v = Self::get_pixels(p.0 as i32, p.1 as i32, r, i); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filters/dots.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | n: n, [INFO] [stderr] | ^^^^ help: replace it with: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filters/wave.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | f: f, [INFO] [stderr] | ^^^^ help: replace it with: `f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filters/wave.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | amp: amp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `amp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filters/wave.rs:35:16 [INFO] [stderr] | [INFO] [stderr] 35 | Wave { d: d, .. self } [INFO] [stderr] | ^^^^ help: replace it with: `d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/images/mod.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | let h = self.height(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/images/mod.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | let w = self.width(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/images/mod.rs:94:21 [INFO] [stderr] | [INFO] [stderr] 94 | let d = ((dy * dy + dx * dx) as f32).sqrt() as u32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | left: left, right: right, top: top, bottom: bottom [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:88:25 [INFO] [stderr] | [INFO] [stderr] 88 | left: left, right: right, top: top, bottom: bottom [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:88:39 [INFO] [stderr] | [INFO] [stderr] 88 | left: left, right: right, top: top, bottom: bottom [INFO] [stderr] | ^^^^^^^^ help: replace it with: `top` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:88:49 [INFO] [stderr] | [INFO] [stderr] 88 | left: left, right: right, top: top, bottom: bottom [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bottom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filters/noise.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | prob: prob [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `prob` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filters/grid.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | x_gap: x_gap, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `x_gap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filters/grid.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | y_gap: y_gap [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `y_gap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filters/cow.rs:29:15 [INFO] [stderr] | [INFO] [stderr] 29 | Cow { n: n, .. self } [INFO] [stderr] | ^^^^ help: replace it with: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filters/cow.rs:33:15 [INFO] [stderr] | [INFO] [stderr] 33 | Cow { min_radius: min_radius, .. self } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min_radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filters/cow.rs:37:15 [INFO] [stderr] | [INFO] [stderr] 37 | Cow { max_radius: max_radius, .. self } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/filters/cow.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | let h = i.height() as i32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/filters/cow.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | let w = i.width() as i32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/filters/cow.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | let mut v = vec![]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/filters/cow.rs:54:21 [INFO] [stderr] | [INFO] [stderr] 54 | let d = ((dy * dy + dx * dx) as f32).sqrt() as i32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/filters/cow.rs:89:17 [INFO] [stderr] | [INFO] [stderr] 89 | let v = Self::get_pixels(p.0 as i32, p.1 as i32, r, i); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filters/dots.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | n: n, [INFO] [stderr] | ^^^^ help: replace it with: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filters/wave.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | f: f, [INFO] [stderr] | ^^^^ help: replace it with: `f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filters/wave.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | amp: amp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `amp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filters/wave.rs:35:16 [INFO] [stderr] | [INFO] [stderr] 35 | Wave { d: d, .. self } [INFO] [stderr] | ^^^^ help: replace it with: `d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/images/mod.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | let h = self.height(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/images/mod.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | let w = self.width(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/images/mod.rs:94:21 [INFO] [stderr] | [INFO] [stderr] 94 | let d = ((dy * dy + dx * dx) as f32).sqrt() as u32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | left: left, right: right, top: top, bottom: bottom [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:88:25 [INFO] [stderr] | [INFO] [stderr] 88 | left: left, right: right, top: top, bottom: bottom [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:88:39 [INFO] [stderr] | [INFO] [stderr] 88 | left: left, right: right, top: top, bottom: bottom [INFO] [stderr] | ^^^^^^^^ help: replace it with: `top` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:88:49 [INFO] [stderr] | [INFO] [stderr] 88 | left: left, right: right, top: top, bottom: bottom [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bottom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `filters::cow::Cow` [INFO] [stderr] --> src/filters/cow.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> Cow { [INFO] [stderr] 19 | | Cow { [INFO] [stderr] 20 | | min_radius: 10, [INFO] [stderr] 21 | | max_radius: 20, [INFO] [stderr] ... | [INFO] [stderr] 25 | | } [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/filters/cow.rs:86:21 [INFO] [stderr] | [INFO] [stderr] 86 | let p = thread_rng().choose_mut(&mut pixels).expect("failed").clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*thread_rng().choose_mut(&mut pixels).expect("failed")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/filters/wave.rs:49:30 [INFO] [stderr] | [INFO] [stderr] 49 | let f = (x as f64 * 2.0 * consts::PI * self.f / i.width() as f64).sin() * self.amp; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/filters/wave.rs:49:69 [INFO] [stderr] | [INFO] [stderr] 49 | let f = (x as f64 * 2.0 * consts::PI * self.f / i.width() as f64).sin() * self.amp; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(i.width())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/filters/wave.rs:60:30 [INFO] [stderr] | [INFO] [stderr] 60 | let f = (y as f64 * 2.0 * consts::PI * self.f / i.width() as f64).sin() * self.amp; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/filters/wave.rs:60:69 [INFO] [stderr] | [INFO] [stderr] 60 | let f = (y as f64 * 2.0 * consts::PI * self.f / i.width() as f64).sin() * self.amp; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(i.width())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/images/mod.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | let p = self.img.get_pixel(x, y).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.img.get_pixel(x, y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Captcha` [INFO] [stderr] --> src/lib.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | / pub fn new() -> Captcha { [INFO] [stderr] 104 | | // TODO fixed width + height [INFO] [stderr] 105 | | let w = 400; [INFO] [stderr] 106 | | let h = 300; [INFO] [stderr] ... | [INFO] [stderr] 112 | | } [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 101 | impl Default for Captcha { [INFO] [stderr] 102 | fn default() -> Self { [INFO] [stderr] 103 | Self::new() [INFO] [stderr] 104 | } [INFO] [stderr] 105 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:150:42 [INFO] [stderr] | [INFO] [stderr] 150 | Some(i) => Some((c.clone(), i)) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | / match self.random_char_as_image() { [INFO] [stderr] 160 | | Some((c, i)) => { [INFO] [stderr] 161 | | let x = self.text_area.right; [INFO] [stderr] 162 | | let y = (self.text_area.bottom + self.text_area.top) / 2 - i.height() / 2; [INFO] [stderr] ... | [INFO] [stderr] 170 | | _ => { } [INFO] [stderr] 171 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 159 | if let Some((c, i)) = self.random_char_as_image() { [INFO] [stderr] 160 | let x = self.text_area.right; [INFO] [stderr] 161 | let y = (self.text_area.bottom + self.text_area.top) / 2 - i.height() / 2; [INFO] [stderr] 162 | self.img.add_image(x, y, &i); [INFO] [stderr] 163 | [INFO] [stderr] 164 | self.text_area.top = min(self.text_area.top, y); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:202:24 [INFO] [stderr] | [INFO] [stderr] 202 | for (y, iy) in (area.top..area.bottom + 1).zip(0..h + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(area.top..=area.bottom)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:202:56 [INFO] [stderr] | [INFO] [stderr] 202 | for (y, iy) in (area.top..area.bottom + 1).zip(0..h + 1) { [INFO] [stderr] | ^^^^^^^^ help: use: `0..=h` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:203:28 [INFO] [stderr] | [INFO] [stderr] 203 | for (x, ix) in (area.left..area.right + 1).zip(0..w + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(area.left..=area.right)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:203:60 [INFO] [stderr] | [INFO] [stderr] 203 | for (x, ix) in (area.left..area.right + 1).zip(0..w + 1) { [INFO] [stderr] | ^^^^^^^^ help: use: `0..=w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `filters::cow::Cow` [INFO] [stderr] --> src/filters/cow.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> Cow { [INFO] [stderr] 19 | | Cow { [INFO] [stderr] 20 | | min_radius: 10, [INFO] [stderr] 21 | | max_radius: 20, [INFO] [stderr] ... | [INFO] [stderr] 25 | | } [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/filters/cow.rs:86:21 [INFO] [stderr] | [INFO] [stderr] 86 | let p = thread_rng().choose_mut(&mut pixels).expect("failed").clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*thread_rng().choose_mut(&mut pixels).expect("failed")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/filters/wave.rs:49:30 [INFO] [stderr] | [INFO] [stderr] 49 | let f = (x as f64 * 2.0 * consts::PI * self.f / i.width() as f64).sin() * self.amp; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/filters/wave.rs:49:69 [INFO] [stderr] | [INFO] [stderr] 49 | let f = (x as f64 * 2.0 * consts::PI * self.f / i.width() as f64).sin() * self.amp; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(i.width())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/filters/wave.rs:60:30 [INFO] [stderr] | [INFO] [stderr] 60 | let f = (y as f64 * 2.0 * consts::PI * self.f / i.width() as f64).sin() * self.amp; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/filters/wave.rs:60:69 [INFO] [stderr] | [INFO] [stderr] 60 | let f = (y as f64 * 2.0 * consts::PI * self.f / i.width() as f64).sin() * self.amp; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(i.width())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/images/mod.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | let p = self.img.get_pixel(x, y).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.img.get_pixel(x, y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Captcha` [INFO] [stderr] --> src/lib.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | / pub fn new() -> Captcha { [INFO] [stderr] 104 | | // TODO fixed width + height [INFO] [stderr] 105 | | let w = 400; [INFO] [stderr] 106 | | let h = 300; [INFO] [stderr] ... | [INFO] [stderr] 112 | | } [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 101 | impl Default for Captcha { [INFO] [stderr] 102 | fn default() -> Self { [INFO] [stderr] 103 | Self::new() [INFO] [stderr] 104 | } [INFO] [stderr] 105 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:150:42 [INFO] [stderr] | [INFO] [stderr] 150 | Some(i) => Some((c.clone(), i)) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | / match self.random_char_as_image() { [INFO] [stderr] 160 | | Some((c, i)) => { [INFO] [stderr] 161 | | let x = self.text_area.right; [INFO] [stderr] 162 | | let y = (self.text_area.bottom + self.text_area.top) / 2 - i.height() / 2; [INFO] [stderr] ... | [INFO] [stderr] 170 | | _ => { } [INFO] [stderr] 171 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 159 | if let Some((c, i)) = self.random_char_as_image() { [INFO] [stderr] 160 | let x = self.text_area.right; [INFO] [stderr] 161 | let y = (self.text_area.bottom + self.text_area.top) / 2 - i.height() / 2; [INFO] [stderr] 162 | self.img.add_image(x, y, &i); [INFO] [stderr] 163 | [INFO] [stderr] 164 | self.text_area.top = min(self.text_area.top, y); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:202:24 [INFO] [stderr] | [INFO] [stderr] 202 | for (y, iy) in (area.top..area.bottom + 1).zip(0..h + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(area.top..=area.bottom)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:202:56 [INFO] [stderr] | [INFO] [stderr] 202 | for (y, iy) in (area.top..area.bottom + 1).zip(0..h + 1) { [INFO] [stderr] | ^^^^^^^^ help: use: `0..=h` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:203:28 [INFO] [stderr] | [INFO] [stderr] 203 | for (x, ix) in (area.left..area.right + 1).zip(0..w + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(area.left..=area.right)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:203:60 [INFO] [stderr] | [INFO] [stderr] 203 | for (x, ix) in (area.left..area.right + 1).zip(0..w + 1) { [INFO] [stderr] | ^^^^^^^^ help: use: `0..=w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.54s [INFO] running `"docker" "inspect" "86646d7e3a3e6b4467c806f763ab393bbc1063dd153dfc11d16a8427ee36fd8d"` [INFO] running `"docker" "rm" "-f" "86646d7e3a3e6b4467c806f763ab393bbc1063dd153dfc11d16a8427ee36fd8d"` [INFO] [stdout] 86646d7e3a3e6b4467c806f763ab393bbc1063dd153dfc11d16a8427ee36fd8d