[INFO] crate capnp-gj 0.2.1 is already in cache [INFO] extracting crate capnp-gj 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/capnp-gj/0.2.1 [INFO] extracting crate capnp-gj 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/capnp-gj/0.2.1 [INFO] validating manifest of capnp-gj-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of capnp-gj-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing capnp-gj-0.2.1 [INFO] finished frobbing capnp-gj-0.2.1 [INFO] frobbed toml for capnp-gj-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/capnp-gj/0.2.1/Cargo.toml [INFO] started frobbing capnp-gj-0.2.1 [INFO] finished frobbing capnp-gj-0.2.1 [INFO] frobbed toml for capnp-gj-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/capnp-gj/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting capnp-gj-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/capnp-gj/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f6d270201e1933cd82c2b86c19bdd3f1c8331402c7efd1ac6e4709a5af9fccdd [INFO] running `"docker" "start" "-a" "f6d270201e1933cd82c2b86c19bdd3f1c8331402c7efd1ac6e4709a5af9fccdd"` [INFO] [stderr] Checking gj v0.2.0 [INFO] [stderr] Checking capnp v0.7.5 [INFO] [stderr] Checking gjio v0.1.3 [INFO] [stderr] Checking capnp-gj v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:144:44 [INFO] [stderr] | [INFO] [stderr] 144 | let segments = OwnedSegments { segment_slices: segment_slices, owned_space: vec.0 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_slices` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | segments: segments [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `segments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:233:36 [INFO] [stderr] | [INFO] [stderr] 233 | let buf = WritingSegment { idx: idx, segments: segments }; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:233:46 [INFO] [stderr] | [INFO] [stderr] 233 | let buf = WritingSegment { idx: idx, segments: segments }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `segments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:144:44 [INFO] [stderr] | [INFO] [stderr] 144 | let segments = OwnedSegments { segment_slices: segment_slices, owned_space: vec.0 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_slices` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | segments: segments [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `segments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:233:36 [INFO] [stderr] | [INFO] [stderr] 233 | let buf = WritingSegment { idx: idx, segments: segments }; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:233:46 [INFO] [stderr] | [INFO] [stderr] 233 | let buf = WritingSegment { idx: idx, segments: segments }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `segments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/serialize.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / fn get_segment<'a>(&'a self, id: u32) -> Option<&'a [Word]> { [INFO] [stderr] 34 | | if id < self.segment_slices.len() as u32 { [INFO] [stderr] 35 | | let (a, b) = self.segment_slices[id as usize]; [INFO] [stderr] 36 | | Some(&self.owned_space[a..b]) [INFO] [stderr] ... | [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/serialize.rs:72:29 [INFO] [stderr] | [INFO] [stderr] 72 | -> Promise<(S, Option<(usize, Vec<(usize, usize)>)>), ::capnp::Error> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/serialize.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | / fn as_ref<'a>(&'a self) -> &'a [u8] { [INFO] [stderr] 122 | | Word::words_to_bytes(&self.0[..]) [INFO] [stderr] 123 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/serialize.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | / fn as_mut<'a>(&'a mut self) -> &'a mut [u8] { [INFO] [stderr] 128 | | Word::words_to_bytes_mut (&mut self.0[..]) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/serialize.rs:169:5 [INFO] [stderr] | [INFO] [stderr] 169 | / fn get<'a>(&'a self) -> &'a ::capnp::OutputSegments<'a> { [INFO] [stderr] 170 | | &self.segments [INFO] [stderr] 171 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/serialize.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | / fn as_ref<'a>(&'a self) -> &'a [u8] { [INFO] [stderr] 212 | | Word::words_to_bytes(self.segments.get()[self.idx]) [INFO] [stderr] 213 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/serialize.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / fn get_segment<'a>(&'a self, id: u32) -> Option<&'a [Word]> { [INFO] [stderr] 34 | | if id < self.segment_slices.len() as u32 { [INFO] [stderr] 35 | | let (a, b) = self.segment_slices[id as usize]; [INFO] [stderr] 36 | | Some(&self.owned_space[a..b]) [INFO] [stderr] ... | [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/serialize.rs:72:29 [INFO] [stderr] | [INFO] [stderr] 72 | -> Promise<(S, Option<(usize, Vec<(usize, usize)>)>), ::capnp::Error> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/serialize.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | / fn as_ref<'a>(&'a self) -> &'a [u8] { [INFO] [stderr] 122 | | Word::words_to_bytes(&self.0[..]) [INFO] [stderr] 123 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/serialize.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | / fn as_mut<'a>(&'a mut self) -> &'a mut [u8] { [INFO] [stderr] 128 | | Word::words_to_bytes_mut (&mut self.0[..]) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/serialize.rs:169:5 [INFO] [stderr] | [INFO] [stderr] 169 | / fn get<'a>(&'a self) -> &'a ::capnp::OutputSegments<'a> { [INFO] [stderr] 170 | | &self.segments [INFO] [stderr] 171 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/serialize.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | / fn as_ref<'a>(&'a self) -> &'a [u8] { [INFO] [stderr] 212 | | Word::words_to_bytes(self.segments.get()[self.idx]) [INFO] [stderr] 213 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.41s [INFO] running `"docker" "inspect" "f6d270201e1933cd82c2b86c19bdd3f1c8331402c7efd1ac6e4709a5af9fccdd"` [INFO] running `"docker" "rm" "-f" "f6d270201e1933cd82c2b86c19bdd3f1c8331402c7efd1ac6e4709a5af9fccdd"` [INFO] [stdout] f6d270201e1933cd82c2b86c19bdd3f1c8331402c7efd1ac6e4709a5af9fccdd